New issue
Advanced search Search tips

Issue 830179 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in blink::PaintLayer::UpdateHasSelfPaintingLayerDescendant

Project Member Reported by ClusterFuzz, Apr 7 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4682427344355328

Fuzzer: marty_html_twiddler
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x1194ca4cd820
Crash State:
  blink::PaintLayer::UpdateHasSelfPaintingLayerDescendant
  blink::PaintLayer::MarkCompositingContainerChainForNeedsRepaint
  blink::PaintInvalidationCapableScrollableArea::WillRemoveScrollbar
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=548210:548215

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4682427344355328

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 7 2018

Components: Blink>Paint
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Apr 7 2018

Labels: Test-Predator-Auto-Owner
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/af3e961ab018262a08de4b9c73e1ddeefce7160f ([PE] Invalidate parent layer for non-self-painting layer having self-painting descendants).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 8 2018

Labels: M-67
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 8 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 8 2018

Labels: Pri-1
Cc: chrishtr@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d2708714bd787b9f336cb62e5b69ceb969796b4

commit 6d2708714bd787b9f336cb62e5b69ceb969796b4
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Mon Apr 09 21:23:14 2018

[PE] Don't call HasSelfPaintingLayerDescendant() from PaintLayer::SetNeedsRepaint()

because we may be during changing the layer tree and
HasSelfPaintingLayerDescendant() may traverse the descendants.

Bug:  830179 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I091c60343d81a4286eb4ebada91bd1f8e3dd6289
Reviewed-on: https://chromium-review.googlesource.com/1002891
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549279}
[modify] https://crrev.com/6d2708714bd787b9f336cb62e5b69ceb969796b4/third_party/blink/renderer/core/paint/paint_layer.cc

Project Member

Comment 8 by ClusterFuzz, Apr 10 2018

ClusterFuzz has detected this issue as fixed in range 549278:549280.

Detailed report: https://clusterfuzz.com/testcase?key=4682427344355328

Fuzzer: marty_html_twiddler
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x1194ca4cd820
Crash State:
  blink::PaintLayer::UpdateHasSelfPaintingLayerDescendant
  blink::PaintLayer::MarkCompositingContainerChainForNeedsRepaint
  blink::PaintInvalidationCapableScrollableArea::WillRemoveScrollbar
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=548210:548215
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=549278:549280

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4682427344355328

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Apr 10 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4682427344355328 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Apr 10 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 12 by sheriffbot@chromium.org, Jul 17

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment