New issue
Advanced search Search tips

Issue 830157 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

wallpaperPrivate.resetWallpaper does not return

Project Member Reported by lazyboy@chromium.org, Apr 7 2018

Issue description

Found this during code review:
https://chromium-review.googlesource.com/c/chromium/src/+/997096/2/chrome/browser/chromeos/extensions/wallpaper_private_api.cc#b501

wallpaperPrivate.resetWallpaper never calls SendResponse. Note that even if the function does not have a callback, we ought to call SendResponse for *all* ExtensionFunctions.
I'm going to fix this while migrating the function from AsyncExtensionFunction to UIThreadExtensionFunction.
 
Labels: -OS-Mac
Status: Fixed (was: Started)
Fix by https://chromium.googlesource.com/chromium/src/+/cb2837fb977d7f2754e2c417d69cda5648b6a67f

Sign in to add a comment