New issue
Advanced search Search tips

Issue 830145 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Performance issues with blink_http_parsers_fuzzer

Project Member Reported by ClusterFuzz, Apr 7 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5864069484249088

Fuzzer: libFuzzer_blink_http_parsers_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  blink_http_parsers_fuzzer
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=547324:547332

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5864069484249088

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 7 2018

Labels: OS-Mac
Cc: brajkumar@chromium.org
Components: Blink
Labels: -Pri-1 -Type-Bug M-67 Test-Predator-Wrong Pri-2 Type-Bug-Regression
Owner: tsepez@chromium.org
Status: Assigned (was: Untriaged)
Predator could not provide any possible suspects.

From the below CL observing some changes related to 'HTTPParsersFuzzer.cpp' , hence suspecting the same
https://chromium.googlesource.com/chromium/src/+log/74fa7a35d6258d0cc0cb21273c8df4f398507e7e..2298aca2e030f8d3214c43c06b9cfd03dc18701b?pretty=fuller&n=10000

Suspect CL: https://chromium.googlesource.com/chromium/src/+/ccf522325512910bc5fa65e0701e30086a48effa

tsepez@ -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Comment 3 by kojii@chromium.org, Apr 9 2018

Components: -Blink Blink>Loader
Owner: ----
Status: Available (was: Assigned)
The regression range shows the addition of the fuzzer, issue pre-existing.
Project Member

Comment 5 by ClusterFuzz, Oct 15

Labels: OS-Windows
Cc: -brajkumar@chromium.org
Owner: infe...@chromium.org
Status: Started (was: Available)
Summary: Performance issues with blink_http_parsers_fuzzer (was: Timeout in blink_http_parsers_fuzzer)
https://clusterfuzz.com/v2/performance-report/libFuzzer_blink_http_parsers_fuzzer/libfuzzer_chrome_asan/2018-10-30

Top issue is the crash

[1029/230628.349670:FATAL:vector.h(1049)] Check failed: i < size() (0 vs. 0)
#0 0x000005517de1 <unknown>
#1 0x00000c9ea98a <unknown>
#2 0x00000c7e4c76 <unknown>
#3 0x0000073af0d5 <unknown>
#4 0x0000091de9d5 <unknown>
#5 0x0000055a2286 <unknown>
#6 0x0000055cadd6 <unknown>
#7 0x0000055c9a5e <unknown>
#8 0x0000055cdd90 <unknown>
#9 0x0000055cf608 <unknown>
#10 0x0000055b5133 <unknown>
#11 0x0000055dbe7d <unknown>
#12 0x7fc0672de830 <unknown>
#13 0x0000054ca02a <unknown>

AddressSanitizer:DEADLYSIGNAL
=================================================================
==67948==ERROR: AddressSanitizer: ABRT on unknown address 0x05390001096c (pc 0x7fc0672f3428 bp 0x7ffe47e02f50 sp 0x7ffe47e02e18 T0)
SCARINESS: 10 (signal)
    #0 0x7fc0672f3427 in gsignal /build/glibc-Cl5G7W/glibc-2.23/signal/../sysdeps/unix/sysv/linux/raise.c:54
    #1 0xc7e5495 in logging::LogMessage::~LogMessage() base/logging.cc:876:7
    #2 0x73af0d4 in WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator>::at(unsigned int) third_party/blink/renderer/platform/wtf/vector.h:1049:5
    #3 0x91de9d4 in blink::ParseContentTypeOptionsHeader(WTF::String const&) third_party/blink/renderer/platform/network/http_parsers.cc:384:7
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b40c59d59daa28ba4866680b267bb0ef449a028d

commit b40c59d59daa28ba4866680b267bb0ef449a028d
Author: Abhishek Arya <inferno@chromium.org>
Date: Fri Nov 09 02:27:48 2018

Fix top crash in blink_http_parsers_fuzzer.

R=bokan@chromium.org

Bug:  830145 
Change-Id: I672d9e13aa3118f7c121f6ab8bfef82f46a47ce8
Reviewed-on: https://chromium-review.googlesource.com/c/1327419
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606709}
[modify] https://crrev.com/b40c59d59daa28ba4866680b267bb0ef449a028d/third_party/blink/renderer/platform/network/http_parsers.cc
[modify] https://crrev.com/b40c59d59daa28ba4866680b267bb0ef449a028d/third_party/blink/renderer/platform/network/http_parsers_test.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a15a55f04d257a03ecef13ba5bee4965bb32b4c

commit 3a15a55f04d257a03ecef13ba5bee4965bb32b4c
Author: Abhishek Arya <inferno@chromium.org>
Date: Mon Nov 12 03:39:18 2018

Fix ooms and timeouts on large inputs for blink_http_parsers_fuzzer.

Most web servers restrict http headers to 8-48 Kb. Restrict the maximum
size for fuzzer efficiency and avoid ooms and timeouts on large inputs.
See also:
https://chromium.googlesource.com/chromium/src/testing/libfuzzer/+/HEAD/getting_started.md#improving-your-fuzz-target

R=tkent@chromium.org

Bug:  830145 
Change-Id: Ib577fb88952207b2c6f00643fda343d3e1254514
Reviewed-on: https://chromium-review.googlesource.com/c/1329674
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607138}
[modify] https://crrev.com/3a15a55f04d257a03ecef13ba5bee4965bb32b4c/third_party/blink/renderer/platform/network/http_parsers_fuzzer.cc

Status: Fixed (was: Started)

Sign in to add a comment