Enable GamepadButton's touched attribute by default |
||||||
Issue descriptionThe touched attribute was added [1] to the Gamepad spec nearly two years ago but has been behind the GamepadExtensions feature flag since it was added to Blink [2]. This is the only failure for Chrome in the Gamepad IDL harness test [3]. [1] https://github.com/w3c/gamepad/pull/26 [2] https://crbug.com/628417#c5 [3] https://wpt.fyi/gamepad/idlharness.html
,
Apr 7 2018
,
Apr 12 2018
,
Jun 11 2018
,
Nov 30
,
Dec 10
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b67a2dd5ee757cb5fbd7bae04dc03ef7e86d4c7 commit 1b67a2dd5ee757cb5fbd7bae04dc03ef7e86d4c7 Author: David Dorwin <ddorwin@chromium.org> Date: Mon Dec 10 21:23:56 2018 Enable GamepadButton's touched attribute by default Per approval in https://groups.google.com/a/chromium.org/d/topic/blink-dev/pc5Jx9qcEJo/discussion Bug: 830140 Change-Id: Ib7e90aa7a5c6eb557c82c9d7389ea27f1a710286 Reviewed-on: https://chromium-review.googlesource.com/c/1003133 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by: Daniel Bratell <bratell@opera.com> Reviewed-by: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#615260} [modify] https://crrev.com/1b67a2dd5ee757cb5fbd7bae04dc03ef7e86d4c7/third_party/blink/renderer/modules/gamepad/gamepad_button.idl [modify] https://crrev.com/1b67a2dd5ee757cb5fbd7bae04dc03ef7e86d4c7/third_party/blink/web_tests/http/tests/origin_trials/webexposed/xr/webvr-gamepad-origin-trial-interfaces.html [modify] https://crrev.com/1b67a2dd5ee757cb5fbd7bae04dc03ef7e86d4c7/third_party/blink/web_tests/http/tests/origin_trials/webexposed/xr/webxr-gamepad-origin-trial-interfaces.html [modify] https://crrev.com/1b67a2dd5ee757cb5fbd7bae04dc03ef7e86d4c7/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
,
Dec 11
,
Dec 11
Verified to be working in Windows Canary 73.0.3637.0 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ddorwin@chromium.org
, Apr 7 2018