New issue
Advanced search Search tips

Issue 830122 link

Starred by 2 users
Status: Assigned
Owner:
blundell@chromium.org
Cc:
msarda@chromium.org
khorimoto@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

IdentityTestEnvironment::MakePrimaryAccountAvailable() does not produce valid AccountInfo

Project Member Reported by khorimoto@chromium.org, Apr 7 2018 
Repro:
(1) Call IdentityTestEnvironment::MakePrimaryAccountAvailable().
(2) Retrieve the account via IdentityManager::GetPrimaryAccountInfo().

Expected:
primary_account_info.IsValid() returns true

Actual:
primary_account_info.IsValid() returns false

The AccountInfo object returned has its account_id, gaia, and email fields set, but none of the other fields are set. IsValid() requires that all of them are set.

Comment 1 by blundell@chromium.org, Apr 9 2018

Cc: msarda@chromium.org
Hey Kyle,

Thanks for the report! This behavior is similar to the pre-existing behavior of SigninManagerBase: when you call SetAuthenticatedAccountId(), the AccountInfo that gets added to the AccountTrackerService is also not valid. Mihai: What are your thoughts here? Personally, I've always thought it strange that IsValid() required all of the info to be filled in. I could imagine renaming that to HasAllAdditionalInformation() or something and have validity be keyed off just the account ID/gaia/email being present.
►

Sign in to add a comment