"Enter VR" button in VR Browser triggers scroll gesture DCHECK |
||||||||
Issue descriptionChrome Version: ToT 7a0c954204c16fc4e7ef3298bb037eac28506fde OS: Android What steps will reproduce the problem? (1) Open a WebVR/XR page, enter VR (2) Use App button to exit to VR Browser (3) Hit the "Enter VR" button via pointer while moving the pointer and/or finger on the touchpad (4) goto 2 What is the expected result? enters VR What happens instead? In a dcheck_always_on build, this sequence sometimes results in a DCHECK error: 04-06 17:17:15.702 20787 20787 F DEBUG : signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr -------- 04-06 17:17:15.708 20787 20787 F DEBUG : Abort message: '[FATAL:render_widget_host_impl.cc(1237)] Check failed: !is_in_gesture_scroll_[gesture_event.SourceDevice()] || FlingCancellationIsDeferred(). I'm not sure how to reproduce it consistently. It seems to happen when the pointer and/or my finger on the touchpad was moving as I click.
,
Apr 9 2018
,
Apr 9 2018
I will take a look.
,
May 18 2018
Reclaiming to do a bit more investigation.
,
May 23 2018
When trying to repro this, I hit a separate crash in our own code. We need to sort that out first... signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr -------- [FATAL:ui_input_manager.cc(191)] Check failed: gesture_list->front()->GetType() == blink::WebInputEvent::kGestureScrollEnd (15 vs. 12) I induced this simply by clicking on and off content while my thumb was wiggling around on the touchpad.
,
May 28 2018
I'll be looking into this.
,
May 28 2018
,
May 31 2018
We solved the DCHECK on our side. The issue was that we were overriding a kGestureScrollEnd by a kGestureFlingCancel. So, we were probably sending kGestureScrollBegin when another scrolling was in curse. However, I don't see how our DCHECK was not failing before, given that it has been there for quite some time. Transfering ownership back to sahel@. Feel free to close if the work on our side is enough to do so.
,
Today
(16 hours ago)
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by klausw@chromium.org
, Apr 7 2018