New issue
Advanced search Search tips

Issue 830119 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Changing default font size does not re-evaluate media queries

Project Member Reported by futhark@chromium.org, Apr 7 2018

Issue description

Load this demo in Chrome:

<!DOCTYPE html>
<style>
  @media (max-width: 30em) { body { background: pink } }
</style>
<body>
  pink?
</body>

Notice it's not pink.

Increase the minimum font size in chrome://settings so that 30em is narrower than 30em.

Still not pink. Reload => pink.

The reload should not be necessary to make it go pink.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d899e4f29364d1337e51aa9bb133dd25a2fc389

commit 7d899e4f29364d1337e51aa9bb133dd25a2fc389
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Apr 13 13:20:49 2018

Re-evaluate media queries for initial style changes.

If the default font-size changed, and media queries have font relative
lengths, then media query evaluations may have changed.

Bug:  830119 
Change-Id: I912adddcdbd05b729678cff14d16245a35bca3e1
Reviewed-on: https://chromium-review.googlesource.com/1000852
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550606}
[modify] https://crrev.com/7d899e4f29364d1337e51aa9bb133dd25a2fc389/third_party/blink/renderer/core/css/style_engine.cc
[modify] https://crrev.com/7d899e4f29364d1337e51aa9bb133dd25a2fc389/third_party/blink/renderer/core/css/style_engine_test.cc

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d899e4f29364d1337e51aa9bb133dd25a2fc389

commit 7d899e4f29364d1337e51aa9bb133dd25a2fc389
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Apr 13 13:20:49 2018

Re-evaluate media queries for initial style changes.

If the default font-size changed, and media queries have font relative
lengths, then media query evaluations may have changed.

Bug:  830119 
Change-Id: I912adddcdbd05b729678cff14d16245a35bca3e1
Reviewed-on: https://chromium-review.googlesource.com/1000852
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550606}
[modify] https://crrev.com/7d899e4f29364d1337e51aa9bb133dd25a2fc389/third_party/blink/renderer/core/css/style_engine.cc
[modify] https://crrev.com/7d899e4f29364d1337e51aa9bb133dd25a2fc389/third_party/blink/renderer/core/css/style_engine_test.cc

Sign in to add a comment