The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56febb92462c9f5da84f4018103d9dfbb15c85de

commit 56febb92462c9f5da84f4018103d9dfbb15c85de
Author: Karan Bhatia <karandeepb@chromium.org>
Date: Wed Apr 11 22:34:20 2018

ExtensionInfoGeneratorUnitTest: Use ChromeTestExtensionLoader.

This CL makes the following improvements in ExtensionInfoGenerator unittests:

- Changes CreateExtensionInfoFromPath to use ChromeTestExtensionLoader. This has
  the benefit of better mocking the non-test code, since this would use
  UnpackedInstaller for the test extension, and end up granting it file access
  (like non-test code). This also necessitates modifying some test expectations.
- Changes WrapUnique to std::make_unique.

BUG= 830112 

Change-Id: I420a8e871abef3ebe8db0aedef64cc87fe4b4835
Reviewed-on: https://chromium-review.googlesource.com/1006486
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549956}
[modify] https://crrev.com/56febb92462c9f5da84f4018103d9dfbb15c85de/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
[modify] https://crrev.com/56febb92462c9f5da84f4018103d9dfbb15c85de/chrome/test/data/extensions/api_test/developer/generated_output/behllobkkfkfnphdnhnkndlbkcpglgmj.json
[modify] https://crrev.com/56febb92462c9f5da84f4018103d9dfbb15c85de/chrome/test/data/extensions/api_test/developer/generated_output/bjafgdebaacbbbecmhlhpofkepfkgcpa.json
[modify] https://crrev.com/56febb92462c9f5da84f4018103d9dfbb15c85de/chrome/test/data/extensions/api_test/developer/generated_output/hpiknbiabeeppbpihjehijgoemciehgk.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5989deec60645e6e58f7cccc2d93b4f4a2432c3

commit f5989deec60645e6e58f7cccc2d93b4f4a2432c3
Author: Karan Bhatia <karandeepb@chromium.org>
Date: Fri Apr 13 07:34:01 2018

Extensions Page: Show "Allow access to file URLs" setting for unpacked extensions.

By default, all unpacked extensions are granted file access. However, if the
extension did not request scriptable or host permissions for the same, we don't
show the "Allow access to file URLs" checkbox for the extension on the
chrome://extensions page.

This CL resolves this discrepancy by modifying the condition to show the file
access checkbox, to also take care of the unpacked extension case.

BUG= 830112 
TEST=Load an unpacked extension on chrome with no host or scripting permissions.
Open chrome://extensions. Ensure that "Allow access to file URLs" checkbox is
shown for the extension and is checked. Do this both for the old and the MD
Extensions page.

Change-Id: Idbb1deae88448f390576fb39ed18876314848f13
Reviewed-on: https://chromium-review.googlesource.com/1006196
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550535}
[modify] https://crrev.com/f5989deec60645e6e58f7cccc2d93b4f4a2432c3/chrome/browser/extensions/api/developer_private/extension_info_generator.cc
[modify] https://crrev.com/f5989deec60645e6e58f7cccc2d93b4f4a2432c3/chrome/test/data/extensions/api_test/developer/generated_output/bjafgdebaacbbbecmhlhpofkepfkgcpa.json
[modify] https://crrev.com/f5989deec60645e6e58f7cccc2d93b4f4a2432c3/chrome/test/data/extensions/api_test/developer/generated_output/hpiknbiabeeppbpihjehijgoemciehgk.json

Able to reproduce the issue on build without fix(checked on 67.0.3390.0) and not seeing  "Allow access to file URLs" checkbox here. Hence verifying the fix on latest canary 68.0.3397.0.

Checked with Document Scanning API example from https://developer.chrome.com/extensions/samples#page-redder.

Observing "Allow access to file URLs" on both chrome://extensions with material design and without MD. Attaching screencast for reference.

As fix is working as expected adding Verified labels. 

Thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5989deec60645e6e58f7cccc2d93b4f4a2432c3

commit f5989deec60645e6e58f7cccc2d93b4f4a2432c3
Author: Karan Bhatia <karandeepb@chromium.org>
Date: Fri Apr 13 07:34:01 2018

Extensions Page: Show "Allow access to file URLs" setting for unpacked extensions.

By default, all unpacked extensions are granted file access. However, if the
extension did not request scriptable or host permissions for the same, we don't
show the "Allow access to file URLs" checkbox for the extension on the
chrome://extensions page.

This CL resolves this discrepancy by modifying the condition to show the file
access checkbox, to also take care of the unpacked extension case.

BUG= 830112 
TEST=Load an unpacked extension on chrome with no host or scripting permissions.
Open chrome://extensions. Ensure that "Allow access to file URLs" checkbox is
shown for the extension and is checked. Do this both for the old and the MD
Extensions page.

Change-Id: Idbb1deae88448f390576fb39ed18876314848f13
Reviewed-on: https://chromium-review.googlesource.com/1006196
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550535}
[modify] https://crrev.com/f5989deec60645e6e58f7cccc2d93b4f4a2432c3/chrome/browser/extensions/api/developer_private/extension_info_generator.cc
[modify] https://crrev.com/f5989deec60645e6e58f7cccc2d93b4f4a2432c3/chrome/test/data/extensions/api_test/developer/generated_output/bjafgdebaacbbbecmhlhpofkepfkgcpa.json
[modify] https://crrev.com/f5989deec60645e6e58f7cccc2d93b4f4a2432c3/chrome/test/data/extensions/api_test/developer/generated_output/hpiknbiabeeppbpihjehijgoemciehgk.json