Issue metadata
Sign in to add a comment
|
STS still shows focus ring/word highlight if text is offscreen but under the shelf |
||||||||||||||||||||||||
Issue descriptionChrome OS with flag enabled: #enable-experimental-accessibility-features Google Chrome 67.0.3383.0 (Official Build) dev (64-bit) Google_Samus.6300.276.0 # Enable STS # Navigate to https://en.wikipedia.org/wiki/Echidna # Select a large amount of text, more than one screen's worth # Scroll back up to the top of the page so that some selected text is offscreen # Invoke the feature with search + s # Watch highlight as you are near the bottom of the page Expected: since text is offscreen, visual focus ring/highlights shouldn't be over the shelf Actual: focus ring is on the bottom of the page and there is no text shown because it's under the shelf. Words being read are off the screen.
,
Apr 10 2018
,
Apr 10 2018
I think this is P3 -- we want to fix it, but it's more polish than functionality. Outcome: Focus rect and highlight should be clipped by the shelf
,
Apr 12 2018
Agree with P3 change. SGTM.
,
Jul 2
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0e452422d56ad93dde15fe843dd85dcfe97cb42 commit c0e452422d56ad93dde15fe843dd85dcfe97cb42 Author: Katie D <katie@chromium.org> Date: Wed Jul 11 17:35:52 2018 Clips Automation.BoundsForRange to clipped location. Instead of returning BoundsForRange compared to the unclipped node location, clips bounds to the clipped location, so that BoundsForRange can never be outside the visible node bounds. This will stop the highlight from showing up when text is scrolled below the bottom of the screen or overflows its parent node, for example. Only SelectToSpeak seems to use BoundsForRange, so this change should not break any other a11y features. Bug: 832548 , 830104 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I763ae2df2228450b9b5d7f1fed0316c74abe470f Reviewed-on: https://chromium-review.googlesource.com/1123030 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#574222} [modify] https://crrev.com/c0e452422d56ad93dde15fe843dd85dcfe97cb42/chrome/renderer/extensions/automation_internal_custom_bindings.cc [modify] https://crrev.com/c0e452422d56ad93dde15fe843dd85dcfe97cb42/chrome/test/data/extensions/api_test/automation/sites/bounds_for_range.html [modify] https://crrev.com/c0e452422d56ad93dde15fe843dd85dcfe97cb42/chrome/test/data/extensions/api_test/automation/tests/tabs/bounds_for_range.js [modify] https://crrev.com/c0e452422d56ad93dde15fe843dd85dcfe97cb42/third_party/closure_compiler/externs/automation.js
,
Jul 11
,
Jul 11
,
Jul 20
Google Chrome 69.0.3473.0 (Official Build) dev (64-bit) Firmware Version Google_Lulu.6301.136.57 Flipping to assigned since I can still reproduce per this video: https://drive.google.com/file/d/1vmeMhdMF8BhFJgbzahMVMs2vZF36tgP-/view
,
Jul 20
I just noticed that my Chromebook may not be updating in the Dev channel. Please let me know if I am not at the minimum version I need to be able to test this and then put the a11y-testers label back on please. Thanks!
,
Jul 20
This landed in 69.0.3489.0.
,
Jul 30
Google Chrome 70.0.3505.0 (Official Build) canary (64-bit) Firmware Version Google_Eve.9584.160.0 Verified using steps above. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by leberly@chromium.org
, Apr 10 2018Summary: STS still shows focus ring/word highlight if text is offscreen but under the shelf (was: STS doesn't scroll page to get to selected text)