New issue
Advanced search Search tips

Issue 830100 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug-Security

Blocked on:
issue 768565



Sign in to add a comment

Heap-use-after-free in cc::VideoResourceUpdater::HardwarePlaneResource::~HardwarePlaneResource

Project Member Reported by ClusterFuzz, Apr 6 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6577068817776640

Fuzzer: inferno_twister
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x61800013ca00
Crash State:
  cc::VideoResourceUpdater::HardwarePlaneResource::~HardwarePlaneResource
  cc::VideoResourceUpdater::~VideoResourceUpdater
  blink::VideoFrameResourceProvider::~VideoFrameResourceProvider
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=548267:548286

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6577068817776640

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 6 2018

Components: Blink>Paint Internals>Compositing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Owner: lethalantidote@chromium.org
Status: Assigned (was: Untriaged)
Probably related to https://bugs.chromium.org/p/chromium/issues/detail?id=829280
Labels: M-67
Labels: Pri-1
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 7 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: -Blink>Paint -Internals>Compositing Blink>Media>Video
Friendly Security Sheriff Ping: Are there any updates on the status of this? This is a high severity security issue.
Labels: -Security_Impact-Head -ReleaseBlock-Stable
This was a bug found in a finch experiment. The experiment is now disabled. It should not impact stable. 
Project Member

Comment 9 by sheriffbot@chromium.org, Apr 17 2018

Labels: Security_Impact-Head
Project Member

Comment 10 by sheriffbot@chromium.org, Apr 17 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, Apr 18 2018

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 12 by ClusterFuzz, Apr 19 2018

Labels: OS-Linux

Comment 13 by vakh@chromium.org, Apr 19 2018

Labels: -ReleaseBlock-Stable ReleaseBlock-NA
Project Member

Comment 14 by sheriffbot@chromium.org, May 1 2018

lethalantidote: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blockedon: 768565
Project Member

Comment 16 by ClusterFuzz, May 12 2018

ClusterFuzz has detected this issue as fixed in range 557982:558008.

Detailed report: https://clusterfuzz.com/testcase?key=6577068817776640

Fuzzer: inferno_twister
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x61800013ca00
Crash State:
  cc::VideoResourceUpdater::HardwarePlaneResource::~HardwarePlaneResource
  cc::VideoResourceUpdater::~VideoResourceUpdater
  blink::VideoFrameResourceProvider::~VideoFrameResourceProvider
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=548267:548286
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=557982:558008

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6577068817776640

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 17 by ClusterFuzz, May 12 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6577068817776640 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 18 by sheriffbot@chromium.org, May 12 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 19 by sheriffbot@chromium.org, Jun 8 2018

Labels: Merge-Request-68
Project Member

Comment 20 by sheriffbot@chromium.org, Jun 8 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-68
no merge needed
Project Member

Comment 22 by sheriffbot@chromium.org, Aug 18

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment