+xiyuan

do you have a crash stack? might be due to https://chromium-review.googlesource.com/c/chromium/src/+/963619 or https://chromium-review.googlesource.com/c/chromium/src/+/969541

+yoshiki for ARC notifications

Looks like infinite recursion for a view preferred size change. Will take a look.

ArcNotificationContentView::UpdatePreferredSize ->
views::View::PreferredSizeChanged () ->
ash::MessageCenterView::OnViewPreferredSizeChanged ->
ash::MessageCenterView::UpdateNotification ->
ash::MessageListView::UpdateNotification ->
arc::ArcNotificationContentView::Update ->
arc::ArcNotificationContentView::UpdateSnapshot -> Goes back to the first one.


(gdb) bt                                                                                                                              
#0  0x00005f28d634fa7c in (anonymous namespace)::do_malloc () at ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1099
#1  0x00005f28dcf234bd in tc_malloc () at ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1045
#2  0x00005f28d86791fe in ShimCppNew () at ../../base/allocator/allocator_shim.cc:159
#3  operator new () at ../../base/allocator/allocator_shim_override_cpp_symbols.h:19
#4  0x00005f28da885b23 in __allocate () at /usr/local/google/home/xiyuan/src/cros/.cache/chrome-sdk/tarballs/samus+10548.0.0+target_toolchain/usr/bin/../include/c++/v1/new:227
#5  allocate () at /usr/local/google/home/xiyuan/src/cros/.cache/chrome-sdk/tarballs/samus+10548.0.0+target_toolchain/usr/bin/../include/c++/v1/memory:1771
#6  allocate () at /usr/local/google/home/xiyuan/src/cros/.cache/chrome-sdk/tarballs/samus+10548.0.0+target_toolchain/usr/bin/../include/c++/v1/memory:1526
#7  __init () at /usr/local/google/home/xiyuan/src/cros/.cache/chrome-sdk/tarballs/samus+10548.0.0+target_toolchain/usr/bin/../include/c++/v1/string:1562
#8  basic_string () at /usr/local/google/home/xiyuan/src/cros/.cache/chrome-sdk/tarballs/samus+10548.0.0+target_toolchain/usr/bin/../include/c++/v1/string:1624
#9  notification_id () at ../../ui/message_center/views/message_view.h:107                          
#10 ash::MessageCenterView::OnViewPreferredSizeChanged () at ../../ash/message_center/message_center_view.cc:566
#11 0x00005f28d9e56b81 in views::View::PreferredSizeChanged () at ../../ui/views/view.cc:1524
#12 0x00005f28d9e56afb in views::View::PreferredSizeChanged () at ../../ui/views/view.cc:1522
#13 0x00005f28dae9f348 in UpdatePreferredSize () at ../../ui/arc/notification/arc_notification_content_view.cc:451
#14 arc::ArcNotificationContentView::UpdateSnapshot () at ../../ui/arc/notification/arc_notification_content_view.cc:459
#15 0x00005f28dae9ed04 in arc::ArcNotificationContentView::Update () at ../../ui/arc/notification/arc_notification_content_view.cc:307
#16 0x00005f28da887357 in ash::MessageListView::UpdateNotification () at ../../ash/message_center/message_list_view.cc:166
#17 0x00005f28da8857b0 in ash::MessageCenterView::UpdateNotification () at ../../ash/message_center/message_center_view.cc:708
#18 0x00005f28da885b55 in ash::MessageCenterView::OnViewPreferredSizeChanged () at ../../ash/message_center/message_center_view.cc:565
#19 0x00005f28d9e56b81 in views::View::PreferredSizeChanged () at ../../ui/views/view.cc:1524
#20 0x00005f28d9e56afb in views::View::PreferredSizeChanged () at ../../ui/views/view.cc:1522
#21 0x00005f28dae9f348 in UpdatePreferredSize () at ../../ui/arc/notification/arc_notification_content_view.cc:451
#22 arc::ArcNotificationContentView::UpdateSnapshot () at ../../ui/arc/notification/arc_notification_content_view.cc:459
#23 0x00005f28dae9ed04 in arc::ArcNotificationContentView::Update () at ../../ui/arc/notification/arc_notification_content_view.cc:307
#24 0x00005f28da887357 in ash::MessageListView::UpdateNotification () at ../../ash/message_center/message_list_view.cc:166
#25 0x00005f28da8857b0 in ash::MessageCenterView::UpdateNotification () at ../../ash/message_center/message_center_view.cc:708
#26 0x00005f28da885b55 in ash::MessageCenterView::OnViewPreferredSizeChanged () at ../../ash/message_center/message_center_view.cc:565
#27 0x00005f28d9e56b81 in views::View::PreferredSizeChanged () at ../../ui/views/view.cc:1524
#28 0x00005f28d9e56afb in views::View::PreferredSizeChanged () at ../../ui/views/view.cc:1522
#29 0x00005f28dae9f348 in UpdatePreferredSize () at ../../ui/arc/notification/arc_notification_content_view.cc:451

Proposed fix:
https://chromium-review.googlesource.com/c/chromium/src/+/1002918

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21b59335be8f6a00f06f70acfd58b117cccc195b

commit 21b59335be8f6a00f06f70acfd58b117cccc195b
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Mon Apr 09 21:36:12 2018

views: Remove NativeViewHost::SetPreferredSize

Remove NativeViewHost::SetPreferredSize since it is implemented in
View now. The View impl notifies parent only when the preferred
size really changes.

Bug:  830093 
Change-Id: I3887b3103e45fc06771f68c469258fb4e53bf4e0
Reviewed-on: https://chromium-review.googlesource.com/1002918
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549285}
[modify] https://crrev.com/21b59335be8f6a00f06f70acfd58b117cccc195b/ui/views/controls/native/native_view_host.cc
[modify] https://crrev.com/21b59335be8f6a00f06f70acfd58b117cccc195b/ui/views/controls/native/native_view_host.h

Issue 830326 has been merged into this issue.

Adding M67 Dev blocker labels after the fact since the DUP was such....

Verified on ChromeOS 10575.3.0, 67.0.3396.0