New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 830090 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add N-up support to UI

Project Member Reported by xlou@chromium.org, Apr 6 2018

Issue description

Adding N-up support to chrome by rerendering PDFs includes changes to PDFium, Print Preview, UI, and maybe other components.

Creates this bug to track the changes to UI code.
 

Comment 1 by xlou@chromium.org, Apr 9 2018

Labels: -Pri-3 Pri-2

Comment 2 by xlou@chromium.org, Apr 9 2018

Components: Internals>Printing>CUPS UI>Browser>PrintPreview
Cc: weifangsun@chromium.org
Labels: M-68 OS-Chrome
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00963708e9af115abc9bf2bc94daefeaeb946073

commit 00963708e9af115abc9bf2bc94daefeaeb946073
Author: xlou <xlou@chromium.org>
Date: Fri May 11 21:23:32 2018

Add N-up support to the new print preview UI.

In printing, 2-up, 3-up, or more generally N-up refers to a page
layout strategy in which multiple pages are composited onto a
single page.

1. Added new select label and button "Pages Per Sheet".
2. Added functionality to pass UI settings to the print preview
   renderer.
3. Added a new constant for N-up printing feature.

Design doc for N-up printing feature is here:
https://docs.google.com/document/d/1rA91PzWDLh6CFrAupgUwv7XYSIqbSpffEnDEQrpEdEQ/

Bug:  830090 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4c9621fcfc8aa9f657960883e6c1ee981905d2bf
Reviewed-on: https://chromium-review.googlesource.com/1050933
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Shirleen Lou <xlou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558022}
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/chrome/app/generated_resources.grd
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/chrome/browser/printing/print_test_utils.cc
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/chrome/browser/resources/print_preview/new/BUILD.gn
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/chrome/browser/resources/print_preview/new/model.js
[add] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/chrome/browser/resources/print_preview/new/pages_per_sheet_settings.html
[add] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/chrome/browser/resources/print_preview/new/pages_per_sheet_settings.js
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/chrome/browser/resources/print_preview/new/preview_area.js
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/chrome/browser/resources/print_preview/new/settings_behavior.js
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/chrome/browser/resources/print_preview/print_preview_resources.grd
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/printing/print_job_constants.cc
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/printing/print_job_constants.h
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/printing/print_settings_conversion.cc
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/printing/printing_context.cc
[modify] https://crrev.com/00963708e9af115abc9bf2bc94daefeaeb946073/tools/metrics/histograms/enums.xml

Comment 5 by xlou@chromium.org, May 14 2018

Status: Started (was: Assigned)
Labels: -M-68 M-69

Comment 7 by xlou@chromium.org, May 21 2018

Status: Fixed (was: Started)

Sign in to add a comment