New issue
Advanced search Search tips

Issue 830085 link

Starred by 2 users
Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use base::span<const uint8_t> in //crypto

Project Member Reported by davidben@chromium.org, Apr 6 2018 
We currently are a haphazard mix of StringPiece and const uint8_t * pointers. The discussion in issue #559302 went back and forth a bit, but the one clear agreement is that people generally prefer not encouraging binary data in StringPiece, so StringPiece is out.

Passing pointer/length pairs is cumbersome and also invites users to mix up the two, whereas base::span<const uint8_t> is fun, shiny, and can benefit from work such as issue #817982.

Therefore, let's inch things towards base::span<const uint8_t>.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ed923199807d58dff353246227099a5d803eef2

commit 8ed923199807d58dff353246227099a5d803eef2
Author: David Benjamin <davidben@chromium.org>
Date: Fri Apr 13 23:17:06 2018

Switch crypto::SignatureVerifier to base::span.

Bug: 830085, 559302
Change-Id: I5dc2bc41154846fd69e276c8d64727ecd6764052
Reviewed-on: https://chromium-review.googlesource.com/919318
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550795}
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/chrome/browser/extensions/install_signer.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/components/client_update_protocol/ecdsa.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/components/crx_file/crx_verifier.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/components/policy/core/common/cloud/cloud_policy_validator.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/components/variations/variations_seed_store.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/crypto/ec_signature_creator_unittest.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/crypto/signature_creator_unittest.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/crypto/signature_verifier.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/crypto/signature_verifier.h
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/crypto/signature_verifier_unittest.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/extensions/browser/content_verifier/content_hash.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/extensions/browser/content_verifier/content_hash.h
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/extensions/browser/content_verifier/content_verifier_key.h
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/extensions/browser/verified_contents.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/extensions/browser/verified_contents.h
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/extensions/browser/verified_contents_unittest.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/net/quic/chromium/crypto/proof_verifier_chromium.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ed923199807d58dff353246227099a5d803eef2

commit 8ed923199807d58dff353246227099a5d803eef2
Author: David Benjamin <davidben@chromium.org>
Date: Fri Apr 13 23:17:06 2018

Switch crypto::SignatureVerifier to base::span.

Bug: 830085, 559302
Change-Id: I5dc2bc41154846fd69e276c8d64727ecd6764052
Reviewed-on: https://chromium-review.googlesource.com/919318
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550795}
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/chrome/browser/extensions/install_signer.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/components/client_update_protocol/ecdsa.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/components/crx_file/crx_verifier.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/components/policy/core/common/cloud/cloud_policy_validator.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/components/variations/variations_seed_store.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/content/browser/web_package/signed_exchange_signature_verifier.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/crypto/ec_signature_creator_unittest.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/crypto/signature_creator_unittest.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/crypto/signature_verifier.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/crypto/signature_verifier.h
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/crypto/signature_verifier_unittest.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/extensions/browser/content_verifier/content_hash.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/extensions/browser/content_verifier/content_hash.h
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/extensions/browser/content_verifier/content_verifier_key.h
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/extensions/browser/verified_contents.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/extensions/browser/verified_contents.h
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/extensions/browser/verified_contents_unittest.cc
[modify] https://crrev.com/8ed923199807d58dff353246227099a5d803eef2/net/quic/chromium/crypto/proof_verifier_chromium.cc
►

Sign in to add a comment