Handle infinite js dialog boxes while in VR |
||||
Issue descriptionIn VR, we currently never show a suppress dialog checkbox for modal dialogs. This could be problematic. If a website harass user with infinite modal dialogs, user don't have a good way to close the webpage while in VR. In 2D, user could still tap the top controls to either close the tab or navigate to a new site. We should have a way to handle the infinite dialog issue. There are probably a few options: 1. show a suppress dialog checkbox the second time a website try to show a dialog 2. making omnibox clickable when show a dialog 3. provide a way for user to close the tab (i.e. press app button) Gordon, do you mind to provide us the correct UX here? I dont think this is a MVP. But mark it as MVP for triage.
,
Apr 13 2018
IIRC, Clank already handles this in its alert boxes. That would mean that we should get this "for free" (the "stop sending me alerts" action will be part of the dialog box that we scrape from Clank and rerender in VR).
,
Apr 13 2018
Please update if my assumption is not correct.
,
Apr 13 2018
Re #2, the suppress option is the existing behavior. However, we are moving to match the desktop behavior (not launched yet, targeting 67) that makes the omnibox clickable but removes the suppress option on Android. 1. it is "for free" if VR uses the existing code path. - The work here would be changing the JavaScriptDialogManager used on VR side (VR currently adopts the new code path which removes the suppress option), and a bit refactor on the Java side to make the old code path supports VR. 2. This is the new code path that we are moving to, but it is VR's decision what behavior is more suitable for VR. - The work here can be to pipe VR support to handle user interactions on the omnibox while a JS dialog is showing. 3. I'm not sure what the app button is but it sounds like this is a VR specific thing.
,
Apr 16 2018
yeah. Unfortunately, we don't get it for free while in VR. 2D Chrome handles infinite js dialog through making omnibox still available while the js dialog shows up. So user can break the loop by close the page from omnibox. Currently, if a dialog is showing in VR, everything else is disabled and user won't be able to get out of the js dialog loop.
,
Jul 5
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sko...@chromium.org
, Apr 13 2018