New issue
Advanced search Search tips

Issue 830047 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

pdf: Mac dictionary look up opens blank dictionary app

Project Member Reported by ccameron@chromium.org, Apr 6 2018

Issue description

To reproduce:
1. Go to http://www.pdf995.com/samples/pdf.pdf
2. Select any text.
3. Right-click and select "Look up"

Note that an empty Dictionary.app instance opens -- it does not open the selected word.

The code to open Dictionary.app was introduced in crrev.com/350164. It's not clear when it stopped working.

 
dictionary.mov
3.4 MB View Download
Labels: Needs-Bisect
We should also check to see if this ever worked for PDFs.
We do indeed get the selected text correctly from PDFs, we just fail to open Dictionary.app correctly.
Labels: -Needs-Bisect
I tried r400000 as a quick test and it didn't work there either. With a regular webpage, there's a look up that happens without Dictionary.app opening.

Let's wait for Mac folks to triage this?
Components: -Internals>Plugins>PDF
Owner: thestig@chromium.org
Lei, what's the component for Mac? Can you route please?
Cc: asvitk...@chromium.org
Components: Internals>PlatformIntegration
Owner: ellyjo...@chromium.org
Over to ellyjones. I traced some of the potentially relevant code back to r65537, so CC asvitkine.
Here's an older bug about the same issue that was fixed at some point:

https://bugs.chromium.org/p/chromium/issues/detail?id=152438
Cc: shuchen@chromium.org
But there's still a reference to  bug 152438  in the code. The only CL mentioned on that bug got reverted. I did not check to see if it relanded.

r549421 added comments to RenderWidgetHostViewMac::OnGotStringForDictionaryOverlay() referring to this bug as well.
Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)
spqchan@, can you take a peek at this?
Owner: ----
Status: Untriaged (was: Assigned)
Status: WontFix (was: Untriaged)
[mac bug triage] Cannot reproduce

Sign in to add a comment