New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 830046 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows
Pri: 1
Type: Bug

Blocked on:
issue 644740
issue 906889

Blocking:
issue 662644
issue 844308
issue 847998


Show other hotlists

Hotlists containing this issue:
webgl-conformance-all


Sign in to add a comment

Win/Linux NVIDIA/OpenGL context loss(?) in conformance2/rendering/blitframebuffer-size-overflow.html

Project Member Reported by kainino@chromium.org, Apr 6 2018

Issue description

In builds on this PS: http://crrev.com/c/996896/3
such as:
https://ci.chromium.org/buildbot/tryserver.chromium.angle/win_angle_rel_ng/10003
, we see failures in webgl2_conformance_gl_tests, on the test immediately after WebglConformance_conformance2_rendering_blitframebuffer_size_overflow (in this case, WebglConformance_conformance2_rendering_draw_buffers_driver_hang).

(Thanks to Mo for help in figuring out that the crash was due to blitframebuffer-size-overflow.)

To reproduce, run Chrome with --use-angle=gl and open
https://www.khronos.org/registry/webgl/sdk/tests/conformance2/rendering/blitframebuffer-size-overflow.html .

Marking test "Skip" in that WebGL roll CL (crrev.com/c/996896).
 

Comment 1 Deleted

Description: Show this description
Description: Show this description
Description: Show this description
Actually, this may or may not be a crash in the driver itself. I need to look at the crash report from zmo's machine and will report back.
Cc: zmo@chromium.org
Summary: Win/NVIDIA/OpenGL context loss(?) in conformance2/rendering/blitframebuffer-size-overflow.html (was: Win/NVIDIA/OpenGL driver crash in conformance2/rendering/blitframebuffer-size-overflow.html)
Looks like some kind of context loss.

Comment 7 by kbr@chromium.org, Apr 7 2018

Cc: yunchao...@intel.com
CC'ing Yunchao who added that test.

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb70ffc00e568cd5c6b7ebd52142697fa58d0573

commit eb70ffc00e568cd5c6b7ebd52142697fa58d0573
Author: Kai Ninomiya <kainino@chromium.org>
Date: Mon Apr 09 20:41:33 2018

Roll WebGL da5abe6..aef0b3a

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/da5abe6..aef0b3a

Bug:  806557 ,  829541 , 830046
Change-Id: I2c1b6f58e8005094f3174b7c9a228a67ee2d379b
Cq-Include-Trybots: master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;master.tryserver.chromium.angle:win_angle_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/996896
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549265}
[modify] https://crrev.com/eb70ffc00e568cd5c6b7ebd52142697fa58d0573/DEPS
[modify] https://crrev.com/eb70ffc00e568cd5c6b7ebd52142697fa58d0573/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/eb70ffc00e568cd5c6b7ebd52142697fa58d0573/content/test/gpu/gpu_tests/webgl_conformance_revision.txt

Comment 9 by oetu...@nvidia.com, Apr 12 2018

Did this regress due to a browser change? The test has been there a fairly long time. Or was the framework just not reliably detecting the context loss?
I think it's that the framework was not reliably detecting the context loss.

The only thing that changed in this roll should have been the ordering/sharding of tests - so I think it was just luck that it wasn't caught before. (issue 830051)

Comment 11 by oetu...@nvidia.com, Apr 19 2018

I've reported the driver bug inside NVIDIA and also started to work on a partial workaround. When I started to test the workaround I noticed that there are widespread issues with this functionality on desktop GL drivers. I'm seeing some failures related to this on at least the following drivers:

AMD Windows OpenGL
Intel Windows OpenGL
NVIDIA OpenGL (across platforms)
Intel Linux OpenGL

I'm not sure about AMD Linux OpenGL since trybots don't run angle_end2end_tests on that config. It might be affected too. Android seems to be unaffected.

Maybe we should restrict this in the spec, since so many drivers are failing and this is a corner case that real-world apps are very unlikely to hit? I can put up a pull request against the WebGL repo for discussion.

Comment 12 by kbr@chromium.org, Apr 19 2018

Sounds OK to me to restrict this in the spec to work around these widespread driver bugs. Thanks for getting to the bottom of it.

Comment 13 by oetu...@nvidia.com, Apr 20 2018

Pull request against the conformance suite here: https://github.com/KhronosGroup/WebGL/pull/2639

Comment 14 by oetu...@nvidia.com, Apr 23 2018

The WebGL pull request was merged. This patch implements the specified checks in ANGLE:

https://chromium-review.googlesource.com/c/angle/angle/+/1023856
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/8d5571ac99c8188d7c2ed32db196c794139cbda8

commit 8d5571ac99c8188d7c2ed32db196c794139cbda8
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Mon Apr 23 18:17:24 2018

Restrict BlitFramebuffer dimensions in WebGL mode

Don't allow blitFramebuffer dimensions to overflow 32-bit integer
range as specified in WebGL 2.0 section 5.41.

BUG=chromium:830046
TEST=WebGL 2 conformance tests, angle_end2end_tests

Change-Id: Ia232291b09c94e1e4f837441c6720a78bab672fb
Reviewed-on: https://chromium-review.googlesource.com/1023856
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/8d5571ac99c8188d7c2ed32db196c794139cbda8/src/tests/gl_tests/WebGLCompatibilityTest.cpp
[modify] https://crrev.com/8d5571ac99c8188d7c2ed32db196c794139cbda8/src/libANGLE/validationES.cpp
[modify] https://crrev.com/8d5571ac99c8188d7c2ed32db196c794139cbda8/src/libANGLE/ErrorStrings.h

Project Member

Comment 16 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/b3474d9d77de3b3b204a5e559cf645dbb5b93981

commit b3474d9d77de3b3b204a5e559cf645dbb5b93981
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Mon Apr 23 18:52:05 2018

Clean up ClipRectangle

It's not necessary to set the intersection rectangle in case the
intersection is empty.

BUG=chromium:830046
TEST=angle_end2end_tests

Change-Id: I0b99cdb7d6623b2d8a95dbe946a6eead6a44351d
Reviewed-on: https://chromium-review.googlesource.com/1021695
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

[modify] https://crrev.com/b3474d9d77de3b3b204a5e559cf645dbb5b93981/src/libANGLE/angletypes.cpp
[modify] https://crrev.com/b3474d9d77de3b3b204a5e559cf645dbb5b93981/src/libANGLE/renderer/d3d/d3d11/Blit11.cpp

Project Member

Comment 17 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abde1d14895b54f360a2459ed18726219a4ae822

commit abde1d14895b54f360a2459ed18726219a4ae822
Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Apr 23 22:56:06 2018

Roll src/third_party/angle/ af2b33be5..b3474d9d7 (2 commits)

https://chromium.googlesource.com/angle/angle.git/+log/af2b33be5a3a..b3474d9d77de

$ git log af2b33be5..b3474d9d7 --date=short --no-merges --format='%ad %ae %s'
2018-04-20 oetuaho Clean up ClipRectangle
2018-04-23 oetuaho Restrict BlitFramebuffer dimensions in WebGL mode

Created with:
  roll-dep src/third_party/angle
BUG=chromium:830046,chromium:830046


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Ia3181cdc2541c174f2c8b7f5fd3001448ec2b470
Reviewed-on: https://chromium-review.googlesource.com/1024535
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#552874}
[modify] https://crrev.com/abde1d14895b54f360a2459ed18726219a4ae822/DEPS

Comment 18 by oetu...@nvidia.com, Apr 30 2018

Now Canary is passing the test in --use-angle=gl --use-cmd-decoder=passthrough. With the validating commend buffer this still fails. I suppose Chrome is not running ANGLE in WebGL mode in case the validating cmd decoder is being used.

Once ANGLE is being used with the passthrough command buffer across all platforms, this issue should be taken care of.
Status: Fixed (was: Available)
Let's mark this as fixed.  We don't intend on supporting the validating command decoder + ANGLE GL right now.
Project Member

Comment 20 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/47155b1718bbd91fe29980ab5fce3f8086614062

commit 47155b1718bbd91fe29980ab5fce3f8086614062
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Wed May 02 08:22:45 2018

Clean up BlitGL

Simplify handling of reversing the blitted area and calculate shader
parameters in a way that doesn't require lengthy explanation.

BUG=chromium:830046
TEST=angle_end2end_tests

Change-Id: Ie9bce812be4ef04a969153fc7c484039fc48a198
Reviewed-on: https://chromium-review.googlesource.com/1030172
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/47155b1718bbd91fe29980ab5fce3f8086614062/src/libANGLE/angletypes.cpp
[modify] https://crrev.com/47155b1718bbd91fe29980ab5fce3f8086614062/src/libANGLE/angletypes.h
[modify] https://crrev.com/47155b1718bbd91fe29980ab5fce3f8086614062/src/libANGLE/renderer/gl/BlitGL.cpp

Project Member

Comment 21 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/9aef81c7cec0989b9f8a072082d946989d59b541

commit 9aef81c7cec0989b9f8a072082d946989d59b541
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Wed May 02 09:02:17 2018

Validate blitFramebuffer for overflows on all platforms

We can validate to avoid triggering driver issues even if the native
GLES spec is not telling us to.

This will fix WebGL in Chromium when it's being run with the
--use-cmd-decoder=validating --use-angle=gl config.

BUG=chromium:830046
TEST=WebGL conformance tests

Change-Id: I2d61182cb6cbe46b52e1d9b7ed6b4035defee082
Reviewed-on: https://chromium-review.googlesource.com/1033743
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/9aef81c7cec0989b9f8a072082d946989d59b541/src/tests/gl_tests/BlitFramebufferANGLETest.cpp
[modify] https://crrev.com/9aef81c7cec0989b9f8a072082d946989d59b541/src/tests/gl_tests/WebGLCompatibilityTest.cpp
[modify] https://crrev.com/9aef81c7cec0989b9f8a072082d946989d59b541/src/libANGLE/validationES.cpp

Project Member

Comment 22 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06471c751ecab77cf62e9cb4521626fb9e40cf4c

commit 06471c751ecab77cf62e9cb4521626fb9e40cf4c
Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 02 11:27:34 2018

Roll src/third_party/angle/ 57d9cbb67..9aef81c7c (2 commits)

https://chromium.googlesource.com/angle/angle.git/+log/57d9cbb67f2d..9aef81c7cec0

$ git log 57d9cbb67..9aef81c7c --date=short --no-merges --format='%ad %ae %s'
2018-04-30 oetuaho Validate blitFramebuffer for overflows on all platforms
2018-04-26 oetuaho Clean up BlitGL

Created with:
  roll-dep src/third_party/angle
BUG=chromium:830046,chromium:830046


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: If5d19b20e6dc7096d7724d9fac6702427f560351
Reviewed-on: https://chromium-review.googlesource.com/1039067
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555350}
[modify] https://crrev.com/06471c751ecab77cf62e9cb4521626fb9e40cf4c/DEPS

Project Member

Comment 23 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32cf029fdc88c543b7d2e6a362874ca522cc7728

commit 32cf029fdc88c543b7d2e6a362874ca522cc7728
Author: Yunchao He <yunchao.he@intel.com>
Date: Wed May 30 06:21:30 2018

Fix bugs for blitFramebuffer when we limit src/dst rect size.

According to WebGL 2 spec. the width/height of src/dst blitting area
should not exceed the max value that can be stored in an integer.

Bug:  844308 , 830046
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I65833dfacabacc46c5cd3602233926e3e31aa6cf
Reviewed-on: https://chromium-review.googlesource.com/1061053
Commit-Queue: Yunchao He <yunchao.he@intel.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562748}
[modify] https://crrev.com/32cf029fdc88c543b7d2e6a362874ca522cc7728/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/32cf029fdc88c543b7d2e6a362874ca522cc7728/gpu/command_buffer/service/gles2_cmd_decoder.cc

Project Member

Comment 24 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cea7bce789fb2ea47dcf4d302cee074099c5b5e7

commit cea7bce789fb2ea47dcf4d302cee074099c5b5e7
Author: Jamie Madill <jmadill@chromium.org>
Date: Wed May 30 20:28:52 2018

Revert "Fix bugs for blitFramebuffer when we limit src/dst rect size."

This reverts commit 32cf029fdc88c543b7d2e6a362874ca522cc7728.

Reason for revert: Seems to cause the subsequent tests to fail on the 
passthrough command buffer. Example:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/1247

See issue for more details.

Bug:  847998 

Original change's description:
> Fix bugs for blitFramebuffer when we limit src/dst rect size.
> 
> According to WebGL 2 spec. the width/height of src/dst blitting area
> should not exceed the max value that can be stored in an integer.
> 
> Bug:  844308 , 830046
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I65833dfacabacc46c5cd3602233926e3e31aa6cf
> Reviewed-on: https://chromium-review.googlesource.com/1061053
> Commit-Queue: Yunchao He <yunchao.he@intel.com>
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562748}

TBR=kbr@chromium.org,yunchao.he@intel.com,kainino@chromium.org

Change-Id: I7f351aa0534b4962012b27d29245eab14a07ec24
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  844308 , 830046
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1079797
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562978}
[modify] https://crrev.com/cea7bce789fb2ea47dcf4d302cee074099c5b5e7/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/cea7bce789fb2ea47dcf4d302cee074099c5b5e7/gpu/command_buffer/service/gles2_cmd_decoder.cc

Comment 25 by kbr@chromium.org, May 31 2018

Blocking: 844308
Blocking: 847998
Status: Available (was: Fixed)
From  issue 847998  it was determined that an updated version of this test is still crashing with some ANGLE configs.

Comment 28 by kbr@chromium.org, Jun 1 2018

Owner: oetu...@nvidia.com
Status: Assigned (was: Available)
Olli, it sounds like a bug in NVIDIA's driver, perhaps just for Quadro series cards (at least the Quadro P400), is causing Chrome's GPU process to crash (or at least, the OpenGL context to be lost via the robustness extension) when running this test. Please see https://chromium-review.googlesource.com/1080003 .

Would it be possible for you to report this bug to NVIDIA's driver team? It would be ideal if it could be fixed there.

Thanks.

Project Member

Comment 29 by bugdroid1@chromium.org, Jun 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71a5107a7fa3567b43841b4c95a55ff247bb7790

commit 71a5107a7fa3567b43841b4c95a55ff247bb7790
Author: Yunchao He <yunchao.he@intel.com>
Date: Sat Jun 02 01:39:18 2018

Fix bugs for blitFramebuffer when we limit src/dst rect size.

According to WebGL 2 spec. the width/height of src/dst blitting area
should not exceed the max value that can be stored in an integer.

https://chromium-review.googlesource.com/c/chromium/src/+/1061053
was the original patch, but it was reverted because it broke ANGLE
CQ (win_angle_rel_ng bot). This new patch simply skipped the updated test
blitframebuffer-size-overflow.html on win/linux + NV + gl + passthrough,
because it still lead to context lost for this config and make subsequent
webgl tests fail. After we skip the test as what it was in the
expectation file, ANGLE CQ like win_angle_rel_ng turns green.

Bug:  844308 , 830046,  847998 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib934814a63a77e2e8a2e7e327bfe500b56e3c63d
Reviewed-on: https://chromium-review.googlesource.com/1080003
Commit-Queue: Yunchao He <yunchao.he@intel.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563906}
[modify] https://crrev.com/71a5107a7fa3567b43841b4c95a55ff247bb7790/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/71a5107a7fa3567b43841b4c95a55ff247bb7790/gpu/command_buffer/service/gles2_cmd_decoder.cc

The bug has already been reported against NVIDIA driver. However, if the validation required by the WebGL spec is in place in the browser, the bug should not be triggered.
Cc: kbr@chromium.org
 Issue 709320  has been merged into this issue.
Owner: ----
Status: Available (was: Assigned)
This still seems to reproduce - it might be that blitting with the width and height equal to max signed int32 also triggers an issue.

Unassigning myself.
Cc: -oetu...@nvidia.com kkinnu...@nvidia.com
Cc: kainino@chromium.org yang...@intel.com
 Issue 844308  has been merged into this issue.
Project Member

Comment 35 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4891a30ea3f5b6222c42595c9be931e8e8d47db

commit f4891a30ea3f5b6222c42595c9be931e8e8d47db
Author: Austin Eng <enga@chromium.org>
Date: Fri Nov 16 04:42:57 2018

Roll WebGL 0d55c88..5b6cbd7

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/0d55c88..5b6cbd7

Include suppressions for the following failures:

  conformance2/textures/misc/copy-texture-image.html
On Mac Intel:
  deqp/functional/gles3/framebufferblit/rect_03.html
  deqp/functional/gles3/framebufferblit/rect_04.html

Bug:  905531 , 830046, 658724
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng
Change-Id: I61d36e9ffab9461ee81cce80f320ab9df095f408
Reviewed-on: https://chromium-review.googlesource.com/c/1335270
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608663}
[modify] https://crrev.com/f4891a30ea3f5b6222c42595c9be931e8e8d47db/DEPS
[modify] https://crrev.com/f4891a30ea3f5b6222c42595c9be931e8e8d47db/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/f4891a30ea3f5b6222c42595c9be931e8e8d47db/content/test/gpu/gpu_tests/webgl_conformance_revision.txt

Labels: OS-Android OS-Linux
Also failing on Android.
Blockedon: 906889
Blocking: 662644
Labels: webgl-conformance
Project Member

Comment 40 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6829aab5f8698d265317183be5e6e50e4551edf9

commit 6829aab5f8698d265317183be5e6e50e4551edf9
Author: James Darpinian <jdarpinian@chromium.org>
Date: Thu Nov 29 00:44:19 2018

Add suppressions for Pixel 2 and Nvidia Shield TV

We're not yet enabling the tests to run on the waterfall due to lack
of hardware, but the tests currently pass with these suppressions.

Bug: 709351,  809233 , 830046, 850257,  874620 
Bug: 905006, 906735, 906735, 906737, 906739
Bug: 906740, 906742,  906743 , 906745, 906752
Change-Id: I7362e52e9df8ae8f591d11a4a1e272fa2b81b0b6
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1340275
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611965}
[modify] https://crrev.com/6829aab5f8698d265317183be5e6e50e4551edf9/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Cc: jhelfe...@nvidia.com
Adding James Helferty (jhelferty@nvidia.com) to CC for WebGL conformance issues on Nvidia GPUs.
Owner: kkinnu...@nvidia.com
Status: Assigned (was: Available)
Kimmo or James at NVIDIA: could one of you please highlight this failure to the OpenGL driver team? If this isn't fixed in the driver then we'll have to introduce some arbitrary limits on BlitFramebuffer's accepted sizes - which would be highly unfortunate.

Thanks.

Summary: Win/Linux NVIDIA/OpenGL context loss(?) in conformance2/rendering/blitframebuffer-size-overflow.html (was: Win/NVIDIA/OpenGL context loss(?) in conformance2/rendering/blitframebuffer-size-overflow.html)
Cc: enga@chromium.org samans@chromium.org
 Issue 906889  has been merged into this issue.
Thanks for pinging. This is nvidia bug number 2215452. For progress: it is being worked on.
Blockedon: 644740
Owner: yunchao...@intel.com
Thanks Kimmo.

Yunchao: this test continues to be problematic on multiple platforms. I would have thought the driver bug workaround adjust_src_dst_region_for_blitframebuffer introduced in https://chromium.googlesource.com/chromium/src/+/b6c1222980a7ed3761601d4a5455fa366eb134f6 for Issue 644740 would have clipped the source and destination rectangles so that large values aren't passed to the driver, but that isn't happening. (Enabling that workaround on my Linux workstation with NVIDIA GPU continues to cause context loss when running this test.)

Would you please revisit this workaround and change it so that it appropriately clips and scales the source and destination rectangles to avoid this context loss? Then we can turn on that workaround for all operating systems and GPU types.

Thank you!

Labels: -Pri-2 Pri-1
Upgrading to P1; this is blocking the WebGL 2.0.1 conformance effort.

Comment 49 by jdarpinian@chromium.org, Jan 16 (6 days ago)

Owner: enga@chromium.org
Austin: this may need spec or test changes.

Sign in to add a comment