New issue
Advanced search Search tips

Issue 830038 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

out of bounds access in GrAAConvexTessellator

Project Member Reported by ClusterFuzz, Apr 6 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5958943768313856

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x0539000017a2
Crash State:
  sk_abort_no_print
  SkTDArray<GrAAConvexTessellator::Ring::PointData>::operator
  SkTDArray<GrAAConvexTessellator::Ring::PointData>::operator
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=529162:529166

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5958943768313856

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Apr 6 2018

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 2 by enne@chromium.org, Apr 25 2018

Owner: enne@chromium.org
Status: Assigned (was: Untriaged)
Summary: out of bounds access in GrAAConvexTessellator (was: Abrt in sk_abort_no_print)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/890a8cc60478ca3d54645ee15e6d3389015bf38e

commit 890a8cc60478ca3d54645ee15e6d3389015bf38e
Author: Adrienne Walker <enne@chromium.org>
Date: Wed Apr 25 23:15:30 2018

Fix GrAAConvexTessellator trying to fan a 0 point ring

This prevents accessing off an empty array.

Bug:  chromium:830038 
Change-Id: I5ad019d56659c667564efc498dcef7fb112da4af
Reviewed-on: https://skia-review.googlesource.com/123800
Commit-Queue: Adrienne Walker <enne@chromium.org>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Adrienne Walker <enne@chromium.org>
Reviewed-by: Mike Klein <mtklein@google.com>

[modify] https://crrev.com/890a8cc60478ca3d54645ee15e6d3389015bf38e/src/gpu/ops/GrAAConvexTessellator.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34f0f203718a104254678606e72712dea0e11074

commit 34f0f203718a104254678606e72712dea0e11074
Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Apr 26 04:56:37 2018

Roll src/third_party/skia/ 25af671a3..6b043cb9c (10 commits)

https://skia.googlesource.com/skia.git/+log/25af671a3d7d..6b043cb9cc1a

$ git log 25af671a3..6b043cb9c --date=short --no-merges --format='%ad %ae %s'
2018-04-26 angle-skia-autoroll Roll third_party/externals/angle2/ f827123d9..197d52949 (2 commits)
2018-04-25 fmalita [skottie] Add support for inverse mask paths
2018-04-25 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ c8eedebdf..840f47ea8 (5 commits)
2018-04-25 enne Fix GrAAConvexTessellator trying to fan a 0 point ring
2018-04-25 bsalomon Reland "Revert "Add arcs as a specialized geometry to GrShape.""
2018-04-25 liyuqian Remove SkASSERT(fConvexity == kUnknown_Convexity) due to racing
2018-04-25 bsalomon Make SkString::appendf safe for long strings.
2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 2c9b55f..ba9fcb3 (1 commits)
2018-04-25 reed fix android-framework
2018-04-25 csmartdalton Remove the MSAA path renderer

Created with:
  roll-dep src/third_party/skia
BUG= chromium:830038 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I027b96e1a3a856ef003b64a2fbc01864671fea9b
Reviewed-on: https://chromium-review.googlesource.com/1029611
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553921}
[modify] https://crrev.com/34f0f203718a104254678606e72712dea0e11074/DEPS

Project Member

Comment 5 by ClusterFuzz, Apr 26 2018

ClusterFuzz has detected this issue as fixed in range 553919:553934.

Detailed report: https://clusterfuzz.com/testcase?key=5958943768313856

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x0539000017a2
Crash State:
  sk_abort_no_print
  SkTDArray<GrAAConvexTessellator::Ring::PointData>::operator
  SkTDArray<GrAAConvexTessellator::Ring::PointData>::operator
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=529162:529166
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=553919:553934

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5958943768313856

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Apr 26 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5958943768313856 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment