New issue
Advanced search Search tips

Issue 830035 link

Starred by 1 user
Status: Fixed
Owner:
dtseng@chromium.org
Closed: Jul 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Gneralize chrome.automation's support for actions

Project Member Reported by dtseng@chromium.org, Apr 6 2018 
The underlying actions support in Chrome has been extended since chrome.automation was initially written.

This bug tracks the work to adopt the same support.

As a result, chrome.automation clients will have two ways to call actions:
1. via specific bindings such as
AutomationNode.prototype.focus()
AutomationNode.prototype.doDefault()
AutomationNode.prototype.setSelection(long start, long end)
etc

2. AutomationNode.prototype.performAction(string actionType)

This alternate version only takes an actionType. It won't allow for clients to call actions that require additional arguments.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/710bbab5b055959b355e647be4484d5c45c087bb

commit 710bbab5b055959b355e647be4484d5c45c087bb
Author: David Tseng <dtseng@chromium.org>
Date: Mon Apr 09 23:47:38 2018

Add generic action support in chrome.automation

- ARC++ actions
- web actions
- new apis to retrieve (AutomationNode.prototype.standardActions), trigger (AutomationNode.prototype.performAction)
- add PRESUBMIT to ensure actions keeps in sync
- add internal action type; public action type

TBR=dcheng@chromium.org

Bug:  830035 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I37ef59bd2dc977278595e3902d52aea7662308d0
Reviewed-on: https://chromium-review.googlesource.com/996795
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549324}
[modify] https://crrev.com/710bbab5b055959b355e647be4484d5c45c087bb/chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
[modify] https://crrev.com/710bbab5b055959b355e647be4484d5c45c087bb/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/710bbab5b055959b355e647be4484d5c45c087bb/chrome/common/extensions/api/automation.idl
[modify] https://crrev.com/710bbab5b055959b355e647be4484d5c45c087bb/chrome/common/extensions/api/automation_internal.idl
[modify] https://crrev.com/710bbab5b055959b355e647be4484d5c45c087bb/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/710bbab5b055959b355e647be4484d5c45c087bb/chrome/renderer/resources/extensions/automation/automation_node.js
[modify] https://crrev.com/710bbab5b055959b355e647be4484d5c45c087bb/chrome/test/data/extensions/api_test/automation/tests/tabs/actions.js
[modify] https://crrev.com/710bbab5b055959b355e647be4484d5c45c087bb/components/arc/common/accessibility_helper.mojom
[modify] https://crrev.com/710bbab5b055959b355e647be4484d5c45c087bb/third_party/closure_compiler/externs/automation.js
[modify] https://crrev.com/710bbab5b055959b355e647be4484d5c45c087bb/ui/accessibility/PRESUBMIT.py
[modify] https://crrev.com/710bbab5b055959b355e647be4484d5c45c087bb/ui/accessibility/ax_enums.mojom

Comment 2 by dtseng@chromium.org, Jul 10

Status: fixed (was: Started)
►

Sign in to add a comment