New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 830028 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Improve the integration test story for telemetry stories

Project Member Reported by dproy@chromium.org, Apr 6 2018

Issue description

We need better integration tests for metrics. The current model we're thinking of is
- We will have a test web page
- We run a telemetry metric against that page, and assert basic behavior assumptions. 

We already seem to have something that does something similar here for paint metrics [1]. We should make this more systematic and do this for other metrics. 

[1] https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py?l=206&rcl=70c6b404a5d0c59c3c3ce32956e5a3ae373bbedb
 
Cc: benjhayden@chromium.org eakuefner@chromium.org
+Ben/Ethan since we should use the histogram python API to query the metrics to assert instead of the old results API

Comment 2 by dproy@chromium.org, Apr 9 2018

Status: Assigned (was: Untriaged)
Ping. Any update? I guess this can be postponed due to the introduction of Perfetto and  the plan to rewrite the metrics in C++?
No update so far. I've been busy with Perfetto. It will be a while before we can migrate all our metrics to C++ so this is still worth doing. 
Cc: -eakuefner@chromium.org

Comment 6 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 7 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment