New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 830013 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 824501



Sign in to add a comment

Replace the usage of icon "settings:security" with "cr:security"

Project Member Reported by jialiul@chromium.org, Apr 6 2018

Issue description

Move "settings:security" icon to ui/webui/resources/cr_elements/icons.html, such that it can be used by non-settings WebUIs.  

Replace existing usage of "settings:security" with "cr:security"

 
Description: Show this description
Blocking: 824501
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe3ee2b387c466206354f808b5b21b52d81aabfb

commit fe3ee2b387c466206354f808b5b21b52d81aabfb
Author: Jialiu Lin <jialiul@chromium.org>
Date: Tue Apr 10 03:41:14 2018

move "settings:security" icon to cr_elements/icons.html

Move "settings:security" icon from chrome/browser/resources/settings/icon.html
to ui/webui/resources/cr_elements/icons.html, such that it can be used
outside of settings WebUI.

Bug:  830013 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I430227fb442597a2d1faf2d9ccf0723c1d3eac3c
Reviewed-on: https://chromium-review.googlesource.com/1003600
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549410}
[modify] https://crrev.com/fe3ee2b387c466206354f808b5b21b52d81aabfb/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
[modify] https://crrev.com/fe3ee2b387c466206354f808b5b21b52d81aabfb/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/fe3ee2b387c466206354f808b5b21b52d81aabfb/chrome/browser/resources/settings/incompatible_applications_page/incompatible_applications_page.html
[modify] https://crrev.com/fe3ee2b387c466206354f808b5b21b52d81aabfb/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/fe3ee2b387c466206354f808b5b21b52d81aabfb/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/fe3ee2b387c466206354f808b5b21b52d81aabfb/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
[modify] https://crrev.com/fe3ee2b387c466206354f808b5b21b52d81aabfb/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/fe3ee2b387c466206354f808b5b21b52d81aabfb/ui/webui/resources/cr_elements/icons.html

Status: Fixed (was: Assigned)

Sign in to add a comment