"MediaEngagementAutoplayBrowserTest.DoNotBypassAutoplayLowEngagement/1" is flaky |
|||||
Issue description"MediaEngagementAutoplayBrowserTest.DoNotBypassAutoplayLowEngagement/1" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUAsSBUZsYWtlIkVNZWRpYUVuZ2FnZW1lbnRBdXRvcGxheUJyb3dzZXJUZXN0LkRvTm90QnlwYXNzQXV0b3BsYXlMb3dFbmdhZ2VtZW50LzEM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 9 2018
According to the flakiness dashboard, MediaEngagementAutoplayBrowserTest.DoNotBypassAutoplayLowEngagement/0 looks also flaky. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=MediaEngagementAutoplayBrowserTest.DoNotBypassAutoplayLowEngagement I'll disable the test tentatively. Please re-enable it once it's fixed.
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/206e196f3ee033873450efa55aae34a3e3bfa98a commit 206e196f3ee033873450efa55aae34a3e3bfa98a Author: Makoto Shimazu <shimazu@chromium.org> Date: Mon Apr 09 05:11:33 2018 Disable a flaky browser test in MediaEngagementAutoplayBrowserTest MediaEngagementAutoplayBrowserTest.DoNotBypassAutoplayLowEngagement/* are flaky. TBR=mlamouri@chromium.org Bug: 830003 Change-Id: I7bfd20eee54e2467231544f63c4afb5e7b6964ce Reviewed-on: https://chromium-review.googlesource.com/1002341 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#549109} [modify] https://crrev.com/206e196f3ee033873450efa55aae34a3e3bfa98a/chrome/browser/media/media_engagement_autoplay_browsertest.cc
,
Apr 9 2018
,
Apr 9 2018
+lethalantidote@, given that the issue in comment #1 let me thinks that this may be related to SurfaceLayer.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88055afd28f7401e8d10654f7fea850cf714b3e0 commit 88055afd28f7401e8d10654f7fea850cf714b3e0 Author: kylechar <kylechar@chromium.org> Date: Tue Apr 17 21:52:28 2018 Check if parent FrameSinkId is registered. Add a check that the parent FrameSinkId is registered before creating an OffscreeCanvasSurfaceImpl, which is really a generic embedded surface and not just used for offscreen canvas. The IPC channel that controls the destruction of the parent CompositorFrameSink, and subsequent invalidation of parent FrameSinkId, is different than the IPC channel used to create embedded surfaces. We can't rely on ordering of messages between them. It's possible the parent FrameSinkId is invalidated before the browser gets the request to create an embedded surface. If this state is detected then just drop the request for the embedded surface. This will avoid triggering the DCHECK that the parent FrameSinkId is registered and avoid doing work for something that is about to be destroyed. The experiment to enable UseSurfaceLayerForVideo, which uses OffscreenCanvasSurfaceImpl, had tests running into this problem and hitting a DCHECK in HostFrameSinkManager::RegisterFrameSinkHierarchy(). Bug: 830003 , 829306 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I4e8cb26548444ecbf941a87a984b21aa4c846580 Reviewed-on: https://chromium-review.googlesource.com/1014330 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551489} [modify] https://crrev.com/88055afd28f7401e8d10654f7fea850cf714b3e0/components/viz/host/host_frame_sink_manager.cc [modify] https://crrev.com/88055afd28f7401e8d10654f7fea850cf714b3e0/components/viz/host/host_frame_sink_manager.h [modify] https://crrev.com/88055afd28f7401e8d10654f7fea850cf714b3e0/content/browser/renderer_host/offscreen_canvas_provider_impl_unittest.cc [modify] https://crrev.com/88055afd28f7401e8d10654f7fea850cf714b3e0/content/browser/renderer_host/offscreen_canvas_surface_impl.cc
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b2582ffceba86af134b6a66c4248dacdc9c134b commit 2b2582ffceba86af134b6a66c4248dacdc9c134b Author: kylechar <kylechar@chromium.org> Date: Thu Apr 19 15:32:53 2018 Enable DoNotBypassAutoplayLowEngagement again. The issue causing flake was fixed by https://crrev.com/c/1014330. Bug: 830003 Change-Id: Id860baa4ddeb3fd90bd1bf23c71ca380dbe8c7e9 Reviewed-on: https://chromium-review.googlesource.com/1017776 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#552025} [modify] https://crrev.com/2b2582ffceba86af134b6a66c4248dacdc9c134b/chrome/browser/media/media_engagement_autoplay_browsertest.cc
,
Apr 19 2018
,
Apr 19 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by taku...@chromium.org
, Apr 6 2018Status: Assigned (was: Untriaged)