New issue
Advanced search Search tips

Issue 829980 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Feature

Blocked on:
issue 831384
issue 850642

Blocking:
issue 822474



Sign in to add a comment

Ozone Scenic platform

Project Member Reported by sergeyu@chromium.org, Apr 6 2018

Issue description

For WebContentService on Fuchsia we will need to add a new Ozone platforms that integrates with Mozart/Scenic.
 
Blockedon: 831384
Labels: -Pri-3 Pri-1
Owner: sergeyu@chromium.org
Status: Started (was: Available)

Comment 3 by w...@chromium.org, May 31 2018

Labels: M-69
P1 -> adding milestone.
Blockedon: 850642
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a4c5046d806adebcb5acbe2171702dfae29b7e0

commit 3a4c5046d806adebcb5acbe2171702dfae29b7e0
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Sat Jun 09 07:46:02 2018

[Fuchsia, ozone] Add Ozone platform for Scenic on Fuchsia.

This is a skeleton for Scenic Ozone platform implementation. It doesn't
talk to Scenic yet.

Bug:  829980 
Change-Id: I19d800d7183a932a4793c9fccf193540f1e6df55
Reviewed-on: https://chromium-review.googlesource.com/1081473
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565871}
[modify] https://crrev.com/3a4c5046d806adebcb5acbe2171702dfae29b7e0/ui/ozone/BUILD.gn
[modify] https://crrev.com/3a4c5046d806adebcb5acbe2171702dfae29b7e0/ui/ozone/ozone.gni
[add] https://crrev.com/3a4c5046d806adebcb5acbe2171702dfae29b7e0/ui/ozone/platform/scenic/BUILD.gn
[add] https://crrev.com/3a4c5046d806adebcb5acbe2171702dfae29b7e0/ui/ozone/platform/scenic/DEPS
[add] https://crrev.com/3a4c5046d806adebcb5acbe2171702dfae29b7e0/ui/ozone/platform/scenic/OWNERS
[add] https://crrev.com/3a4c5046d806adebcb5acbe2171702dfae29b7e0/ui/ozone/platform/scenic/client_native_pixmap_factory_scenic.cc
[add] https://crrev.com/3a4c5046d806adebcb5acbe2171702dfae29b7e0/ui/ozone/platform/scenic/client_native_pixmap_factory_scenic.h
[add] https://crrev.com/3a4c5046d806adebcb5acbe2171702dfae29b7e0/ui/ozone/platform/scenic/ozone_platform_scenic.cc
[add] https://crrev.com/3a4c5046d806adebcb5acbe2171702dfae29b7e0/ui/ozone/platform/scenic/ozone_platform_scenic.h
[add] https://crrev.com/3a4c5046d806adebcb5acbe2171702dfae29b7e0/ui/ozone/platform/scenic/scenic_surface_factory.cc
[add] https://crrev.com/3a4c5046d806adebcb5acbe2171702dfae29b7e0/ui/ozone/platform/scenic/scenic_surface_factory.h
[add] https://crrev.com/3a4c5046d806adebcb5acbe2171702dfae29b7e0/ui/ozone/platform/scenic/scenic_window.cc
[add] https://crrev.com/3a4c5046d806adebcb5acbe2171702dfae29b7e0/ui/ozone/platform/scenic/scenic_window.h
[add] https://crrev.com/3a4c5046d806adebcb5acbe2171702dfae29b7e0/ui/ozone/platform/scenic/scenic_window_manager.cc
[add] https://crrev.com/3a4c5046d806adebcb5acbe2171702dfae29b7e0/ui/ozone/platform/scenic/scenic_window_manager.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/919bc2c5423712c0d08b48561acb925284797948

commit 919bc2c5423712c0d08b48561acb925284797948
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Sat Jun 09 16:44:04 2018

[Fuchsia, ozone] Add ScenicSession and scenic_helpers

Add some helper code for Scenic:
1. ScenicSession is a wrapper around a scenic::Session,
   which is responsible for queuing Scenic messages and allocating
   resource IDs within the session.
2. scenic_helper.h/cc contain functions that simplify construction of
   scenic commands.

Bug:  829980 
Change-Id: Ib9d5a5f7d6b9e77c657d84f42f0a1f0e99652cb5
Reviewed-on: https://chromium-review.googlesource.com/1081244
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565885}
[modify] https://crrev.com/919bc2c5423712c0d08b48561acb925284797948/ui/ozone/platform/scenic/BUILD.gn
[add] https://crrev.com/919bc2c5423712c0d08b48561acb925284797948/ui/ozone/platform/scenic/scenic_session.cc
[add] https://crrev.com/919bc2c5423712c0d08b48561acb925284797948/ui/ozone/platform/scenic/scenic_session.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/739639609176977515537f1aabf05a66348cc4f9

commit 739639609176977515537f1aabf05a66348cc4f9
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Jun 18 20:50:14 2018

Pass PlatformWindowInitProperties by value instead of const-ref.

Previously PlatformWindowInitProperties was passed to Ozone platform
implementations as a const reference. This doesn't allow to pass movable
parameters (e.g. handles) when creating platform windows. On Fuchsia it
is necessary to pass view_owner_request when creating a view.
view_owner_request wraps an handle, so it's not copyable. Updated all
code that works with PlatformWindowInitProperties to pass it by value.

Also updated DesktopWindowTreeHostPlatform to default to POPUP window
type for any widget types other then WINDOW and MENU.

Bug:  829980 
Change-Id: I34c7a8fe957f364833a5e4eafd272794eec99b56
Reviewed-on: https://chromium-review.googlesource.com/1103223
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568153}
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/services/ui/ws/platform_display.cc
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/aura/window_tree_host_platform.cc
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/aura/window_tree_host_platform.h
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/compositor/test/test_compositor_host_ozone.cc
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/ozone/demo/demo_window.cc
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/ozone/platform/cast/ozone_platform_cast.cc
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/ozone/platform/drm/ozone_platform_gbm.cc
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/ozone/platform/headless/ozone_platform_headless.cc
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/ozone/platform/scenic/ozone_platform_scenic.cc
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/ozone/platform/wayland/ozone_platform_wayland.cc
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/ozone/platform/wayland/wayland_pointer_unittest.cc
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/ozone/platform/wayland/wayland_test.cc
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/ozone/platform/wayland/wayland_window.cc
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/ozone/platform/wayland/wayland_window.h
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/ozone/platform/wayland/wayland_window_unittest.cc
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/ozone/platform/windows/ozone_platform_windows.cc
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/ozone/platform/x11/ozone_platform_x11.cc
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/ozone/public/ozone_platform.h
[modify] https://crrev.com/739639609176977515537f1aabf05a66348cc4f9/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/502b5a8a3b9bce9f2a5dca83ca34b0c8b1111e09

commit 502b5a8a3b9bce9f2a5dca83ca34b0c8b1111e09
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Jun 19 01:54:38 2018

[Fuchsia, ozone] Implement ScenicWindow

ScenicWindow now creates View and listens to input events (mouse and keyboard).

Bug:  829980 
Change-Id: If5d05bf1107fec553aecf2537fd197d177d2fbb1
Reviewed-on: https://chromium-review.googlesource.com/1081609
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568293}
[modify] https://crrev.com/502b5a8a3b9bce9f2a5dca83ca34b0c8b1111e09/ui/ozone/platform/scenic/BUILD.gn
[modify] https://crrev.com/502b5a8a3b9bce9f2a5dca83ca34b0c8b1111e09/ui/ozone/platform/scenic/ozone_platform_scenic.cc
[modify] https://crrev.com/502b5a8a3b9bce9f2a5dca83ca34b0c8b1111e09/ui/ozone/platform/scenic/scenic_window.cc
[modify] https://crrev.com/502b5a8a3b9bce9f2a5dca83ca34b0c8b1111e09/ui/ozone/platform/scenic/scenic_window.h
[modify] https://crrev.com/502b5a8a3b9bce9f2a5dca83ca34b0c8b1111e09/ui/ozone/platform/scenic/scenic_window_manager.cc
[modify] https://crrev.com/502b5a8a3b9bce9f2a5dca83ca34b0c8b1111e09/ui/ozone/platform/scenic/scenic_window_manager.h
[modify] https://crrev.com/502b5a8a3b9bce9f2a5dca83ca34b0c8b1111e09/ui/platform_window/BUILD.gn
[add] https://crrev.com/502b5a8a3b9bce9f2a5dca83ca34b0c8b1111e09/ui/platform_window/platform_window_init_properties.cc
[modify] https://crrev.com/502b5a8a3b9bce9f2a5dca83ca34b0c8b1111e09/ui/platform_window/platform_window_init_properties.h
[modify] https://crrev.com/502b5a8a3b9bce9f2a5dca83ca34b0c8b1111e09/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/156afe2aa39dd26b9a5ab769b586449c312ad361

commit 156afe2aa39dd26b9a5ab769b586449c312ad361
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Tue Jun 19 03:12:34 2018

Revert "[Fuchsia, ozone] Implement ScenicWindow"

This reverts commit 502b5a8a3b9bce9f2a5dca83ca34b0c8b1111e09.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 568293 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzUwMmI1YThhM2I5YmNlOWYyYTVkY2E4M2NhMzRiMGM4YjExMTFlMDkM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/6372

Sample Failed Step: compile

Original change's description:
> [Fuchsia, ozone] Implement ScenicWindow
> 
> ScenicWindow now creates View and listens to input events (mouse and keyboard).
> 
> Bug:  829980 
> Change-Id: If5d05bf1107fec553aecf2537fd197d177d2fbb1
> Reviewed-on: https://chromium-review.googlesource.com/1081609
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568293}

Change-Id: I79c4bcd4615d058aa4080d01c9a3107ab8835bc3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  829980 
Reviewed-on: https://chromium-review.googlesource.com/1105440
Cr-Commit-Position: refs/heads/master@{#568319}
[modify] https://crrev.com/156afe2aa39dd26b9a5ab769b586449c312ad361/ui/ozone/platform/scenic/BUILD.gn
[modify] https://crrev.com/156afe2aa39dd26b9a5ab769b586449c312ad361/ui/ozone/platform/scenic/ozone_platform_scenic.cc
[modify] https://crrev.com/156afe2aa39dd26b9a5ab769b586449c312ad361/ui/ozone/platform/scenic/scenic_window.cc
[modify] https://crrev.com/156afe2aa39dd26b9a5ab769b586449c312ad361/ui/ozone/platform/scenic/scenic_window.h
[modify] https://crrev.com/156afe2aa39dd26b9a5ab769b586449c312ad361/ui/ozone/platform/scenic/scenic_window_manager.cc
[modify] https://crrev.com/156afe2aa39dd26b9a5ab769b586449c312ad361/ui/ozone/platform/scenic/scenic_window_manager.h
[modify] https://crrev.com/156afe2aa39dd26b9a5ab769b586449c312ad361/ui/platform_window/BUILD.gn
[delete] https://crrev.com/37b13a74195e3b6bb729d0473151a55d378cd176/ui/platform_window/platform_window_init_properties.cc
[modify] https://crrev.com/156afe2aa39dd26b9a5ab769b586449c312ad361/ui/platform_window/platform_window_init_properties.h
[modify] https://crrev.com/156afe2aa39dd26b9a5ab769b586449c312ad361/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/915401e3066c67ffea63aa80fe4fa81acce5f0c9

commit 915401e3066c67ffea63aa80fe4fa81acce5f0c9
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Jun 19 06:57:18 2018

Reland "[Fuchsia, ozone] Implement ScenicWindow"

This is a reland of 502b5a8a3b9bce9f2a5dca83ca34b0c8b1111e09

TBR=sky@chromium.org

Original change's description:
> [Fuchsia, ozone] Implement ScenicWindow
>
> ScenicWindow now creates View and listens to input events (mouse and keyboard).
>
> Bug:  829980 
> Change-Id: If5d05bf1107fec553aecf2537fd197d177d2fbb1
> Reviewed-on: https://chromium-review.googlesource.com/1081609
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568293}

Bug:  829980 
Change-Id: I8e3d6f83d4f38d40da065922f85866a1419712d8
Reviewed-on: https://chromium-review.googlesource.com/1105098
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568361}
[modify] https://crrev.com/915401e3066c67ffea63aa80fe4fa81acce5f0c9/ui/compositor/BUILD.gn
[modify] https://crrev.com/915401e3066c67ffea63aa80fe4fa81acce5f0c9/ui/ozone/platform/scenic/BUILD.gn
[modify] https://crrev.com/915401e3066c67ffea63aa80fe4fa81acce5f0c9/ui/ozone/platform/scenic/ozone_platform_scenic.cc
[modify] https://crrev.com/915401e3066c67ffea63aa80fe4fa81acce5f0c9/ui/ozone/platform/scenic/scenic_window.cc
[modify] https://crrev.com/915401e3066c67ffea63aa80fe4fa81acce5f0c9/ui/ozone/platform/scenic/scenic_window.h
[modify] https://crrev.com/915401e3066c67ffea63aa80fe4fa81acce5f0c9/ui/ozone/platform/scenic/scenic_window_manager.cc
[modify] https://crrev.com/915401e3066c67ffea63aa80fe4fa81acce5f0c9/ui/ozone/platform/scenic/scenic_window_manager.h
[modify] https://crrev.com/915401e3066c67ffea63aa80fe4fa81acce5f0c9/ui/platform_window/BUILD.gn
[add] https://crrev.com/915401e3066c67ffea63aa80fe4fa81acce5f0c9/ui/platform_window/platform_window_init_properties.cc
[modify] https://crrev.com/915401e3066c67ffea63aa80fe4fa81acce5f0c9/ui/platform_window/platform_window_init_properties.h
[modify] https://crrev.com/915401e3066c67ffea63aa80fe4fa81acce5f0c9/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/528cf76e0329742e44fcfcce440fe2582d783dba

commit 528cf76e0329742e44fcfcce440fe2582d783dba
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Wed Jun 20 22:49:08 2018

Update WindowTreeHost::Create() to take ui::PlatformWindowInitProperties

Previously WindowTreeHost::Create() was taking one argument for bounds.
That didn't allow to pass any other window initialization parameters.
Updated Create() to take PlatformWindowInitProperties instead of bounds.
Also updated it to return std::unique_ptr<> instead of raw pointer.

Bug:  829980 
Change-Id: I8789cf9c8fb4deaca86eaff128f125cf7490994a
Reviewed-on: https://chromium-review.googlesource.com/1105130
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569061}
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ash/host/ash_window_tree_host.cc
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ash/host/ash_window_tree_host_mirroring_unified.cc
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ash/host/ash_window_tree_host_platform.cc
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ash/host/ash_window_tree_host_platform.h
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/chromecast/graphics/BUILD.gn
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/chromecast/graphics/DEPS
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/chromecast/graphics/cast_focus_client_aura_test.cc
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/chromecast/graphics/cast_window_manager_aura.cc
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/content/shell/BUILD.gn
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/content/shell/DEPS
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/content/shell/browser/shell_platform_data_aura.cc
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/extensions/shell/BUILD.gn
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/extensions/shell/browser/DEPS
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/extensions/shell/browser/root_window_controller.cc
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/extensions/shell/browser/shell_screen_unittest.cc
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/aura/BUILD.gn
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/aura/test/test_screen.cc
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/aura/window_event_dispatcher_unittest.cc
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/aura/window_tree_host.cc
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/aura/window_tree_host.h
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/aura/window_tree_host_platform.cc
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/aura/window_tree_host_platform.h
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/aura_extra/DEPS
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/aura_extra/window_occlusion_impl_unittest_win.cc
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/platform_window/platform_window_init_properties.cc
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/platform_window/platform_window_init_properties.h
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/wm/BUILD.gn
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/wm/core/DEPS
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/wm/core/capture_controller_unittest.cc
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/wm/test/DEPS
[modify] https://crrev.com/528cf76e0329742e44fcfcce440fe2582d783dba/ui/wm/test/wm_test_helper.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c7f51e9cfef79acfc9f337a4f1568b7bcca4b48

commit 3c7f51e9cfef79acfc9f337a4f1568b7bcca4b48
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Jun 22 18:39:29 2018

[Ozone, Fuchsia] Add OzonePlatform::GetPlatformProperties()

Scenic Ozone platform requires view_owner_request field to be set in
PlatformWindowInitProperties when creating a window. Previously
there was no mechanism for upper layers to discover that the current
Ozone platform expects that field. To solve this problem this CL adds
GetPlatformProperties() method in OzonePlatform. The returned
PlatformProperties struct contains just one field, but in future it
can be extended as needed for other platforms.

Bug:  829980 
Change-Id: Idcd8c1b645cdeca36975c7feb5a1cf720fd592dd
Reviewed-on: https://chromium-review.googlesource.com/1110877
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569706}
[modify] https://crrev.com/3c7f51e9cfef79acfc9f337a4f1568b7bcca4b48/ui/ozone/platform/scenic/ozone_platform_scenic.cc
[modify] https://crrev.com/3c7f51e9cfef79acfc9f337a4f1568b7bcca4b48/ui/ozone/public/ozone_platform.cc
[modify] https://crrev.com/3c7f51e9cfef79acfc9f337a4f1568b7bcca4b48/ui/ozone/public/ozone_platform.h

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88b0ba9dbc38a3e3e70059c3e80978353e310ae7

commit 88b0ba9dbc38a3e3e70059c3e80978353e310ae7
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Jun 26 02:17:37 2018

[Fuchsia, ozone] Implement ScenicSurfaceFactory

ScenicSurfaceFactory is a simple SurfaceFactory implementation for
the Scenic ozone platform that allows displaying 2D images on the
screen on Fuchsia.

Bug:  829980 
Change-Id: Ic8326b4fcc000a2e435e63a6e6778d861f5f17a7
Reviewed-on: https://chromium-review.googlesource.com/1080980
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570296}
[modify] https://crrev.com/88b0ba9dbc38a3e3e70059c3e80978353e310ae7/ui/ozone/platform/scenic/BUILD.gn
[modify] https://crrev.com/88b0ba9dbc38a3e3e70059c3e80978353e310ae7/ui/ozone/platform/scenic/ozone_platform_scenic.cc
[modify] https://crrev.com/88b0ba9dbc38a3e3e70059c3e80978353e310ae7/ui/ozone/platform/scenic/scenic_session.cc
[modify] https://crrev.com/88b0ba9dbc38a3e3e70059c3e80978353e310ae7/ui/ozone/platform/scenic/scenic_session.h
[modify] https://crrev.com/88b0ba9dbc38a3e3e70059c3e80978353e310ae7/ui/ozone/platform/scenic/scenic_surface_factory.cc
[modify] https://crrev.com/88b0ba9dbc38a3e3e70059c3e80978353e310ae7/ui/ozone/platform/scenic/scenic_surface_factory.h
[add] https://crrev.com/88b0ba9dbc38a3e3e70059c3e80978353e310ae7/ui/ozone/platform/scenic/scenic_window_canvas.cc
[add] https://crrev.com/88b0ba9dbc38a3e3e70059c3e80978353e310ae7/ui/ozone/platform/scenic/scenic_window_canvas.h
[modify] https://crrev.com/88b0ba9dbc38a3e3e70059c3e80978353e310ae7/ui/ozone/public/surface_ozone_canvas.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9731d58b23630a33af9519188d9dbcb6c29a789

commit e9731d58b23630a33af9519188d9dbcb6c29a789
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Thu Jul 19 03:52:14 2018

[Fuchsia] use scenic ozone platform by default.

Previously headless ozone platform was used on Fuchsia. Switched it to
scenic. content_unittests fail with scenic, so this change also adds
--ozone-platforms=headless flag in the unittests, until this issue
is resolved.

Bug:  829980 , 865172
Change-Id: I8a0b282953cf90554dc78ed1575d927b53374c58
Reviewed-on: https://chromium-review.googlesource.com/1142492
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576360}
[modify] https://crrev.com/e9731d58b23630a33af9519188d9dbcb6c29a789/content/public/test/DEPS
[modify] https://crrev.com/e9731d58b23630a33af9519188d9dbcb6c29a789/content/public/test/unittest_test_suite.cc
[modify] https://crrev.com/e9731d58b23630a33af9519188d9dbcb6c29a789/ui/ozone/ozone.gni

Summary: Ozone Scenic platform (was: Ozone Fuchsia platform)
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a57e9063d10bc3d1ad0b0c39a2b93f48b0c3500

commit 3a57e9063d10bc3d1ad0b0c39a2b93f48b0c3500
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Fri Aug 24 20:53:17 2018

Enable DesktopWindowtreeHostPlatform on Fuchsia

With this change it will be possible to build //ui/views on Fuchsia.

Bug:  829980 ,  877264 
Change-Id: I9fb7be4a76f942ffc9945f87c4430a6457cd6f87
Reviewed-on: https://chromium-review.googlesource.com/1187649
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585985}
[modify] https://crrev.com/3a57e9063d10bc3d1ad0b0c39a2b93f48b0c3500/ui/views/BUILD.gn

Project Member

Comment 17 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/539b6d93fb8fba2537c1c20e0a1364bb180784b5

commit 539b6d93fb8fba2537c1c20e0a1364bb180784b5
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Thu Aug 30 21:37:09 2018

[fuchsia] Add touch input support.

This CL adds support for touch/gesture input (touch, swipe, pinch, etc.)
to the ContextProvider service.

Also included in this CL:
* Adds input focus event handling.
* Populate Screen/Display dimensions on window size events.
* Miscellaneous IWYU fixes.

Bug:  876933 ,  878439 , 829980 
Change-Id: Ic4e5a8123bac2360e40f2affe6e1ec1e242260d4
Reviewed-on: https://chromium-review.googlesource.com/1194973
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587782}
[modify] https://crrev.com/539b6d93fb8fba2537c1c20e0a1364bb180784b5/ui/ozone/platform/scenic/scenic_screen.cc
[modify] https://crrev.com/539b6d93fb8fba2537c1c20e0a1364bb180784b5/ui/ozone/platform/scenic/scenic_screen.h
[modify] https://crrev.com/539b6d93fb8fba2537c1c20e0a1364bb180784b5/ui/ozone/platform/scenic/scenic_window.cc
[modify] https://crrev.com/539b6d93fb8fba2537c1c20e0a1364bb180784b5/ui/ozone/platform/scenic/scenic_window.h

Status: Fixed (was: Started)

Sign in to add a comment