New issue
Advanced search Search tips

Issue 829975 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Delete TESTS files in chrome/tools/build/

Project Member Reported by jbroman@chromium.org, Apr 6 2018

Issue description

It's not obvious whether these are used, or for what. They haven't been touched in a long time, so it's quite possible that they can simply be deleted.

https://cs.chromium.org/search/?q=package:%5Echromium$+f:chrome/tools/build/.*/TESTS$&type=cs
 

Comment 1 by hzl@chromium.org, Apr 6 2018

Status: Available (was: Untriaged)
Owner: hs1217....@samsung.com
i will make patch.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b90be86cccf9bf19ac3bac9b3da1374a32eaa70d

commit b90be86cccf9bf19ac3bac9b3da1374a32eaa70d
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Thu Apr 26 04:32:27 2018

Delete TESTS files in chrome/tools/build/

according to previous git log[1],
it looks likes used to store test files
in official Chrome build gs:// drops.
these files haven't been touched in a long time.
and it seems like not used any more.

[1]https://codereview.chromium.org/545103003

Bug:  829975 
Change-Id: Ida8e887c64d4d18b7eb877f3cda2001a1871b844
Reviewed-on: https://chromium-review.googlesource.com/1027598
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hwanseung Lee <hwanseung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553915}
[delete] https://crrev.com/5a40ea2527d1ef1a16859a96449b085d9884903f/chrome/tools/build/chromeos/TESTS
[delete] https://crrev.com/5a40ea2527d1ef1a16859a96449b085d9884903f/chrome/tools/build/linux/TESTS
[delete] https://crrev.com/5a40ea2527d1ef1a16859a96449b085d9884903f/chrome/tools/build/mac/TESTS
[delete] https://crrev.com/5a40ea2527d1ef1a16859a96449b085d9884903f/chrome/tools/build/win/TESTS

Status: Fixed (was: Available)
after the patch merged, it has been about one month.
it seems doesn't make any trouble.
so i will change this issue's status to "fixed".

Sign in to add a comment