New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829920 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Use Gitiles directly instead of Gerrit for cr informaiton

Project Member Reported by wylieb@chromium.org, Apr 6 2018

Issue description

refactoring bug
 

Comment 1 by chanli@chromium.org, Jun 26 2018

Owner: chanli@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/abec83dc48383906c9c24d9c5d1738d0a89fefc6

commit abec83dc48383906c9c24d9c5d1738d0a89fefc6
Author: Chan <chanli@chromium.org>
Date: Fri Jul 20 22:26:41 2018

[Findit] Get commit info from gitiles instead of gerrit.

Get information like author's email and commit time from gitiles instead of gerrit.

Also move some checks for if a revert can be committed or not from services/gerrit to services/culprit_action.py because of the change.

Bug:  829920 

Change-Id: Ic13552391af4bf1e7815685559f967f42a1b9490
Reviewed-on: https://chromium-review.googlesource.com/1124937
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/services/compile_failure/test/compile_try_job_test.py
[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/pipelines/test_failure/analyze_test_failure_pipeline.py
[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/services/gerrit.py
[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/services/test_failure/test/test_try_job_test.py
[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/services/flake_failure/culprit_util.py
[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/services/git.py
[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/services/test_failure/test/test_culprit_action_test.py
[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/services/constants.py
[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/services/compile_failure/test/compile_culprit_action_test.py
[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/services/culprit_action.py
[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/services/flake_failure/test/culprit_util_test.py
[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/services/test/gerrit_test.py
[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/pipelines/test/submit_revert_cl_pipeline_test.py
[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/services/test/culprit_action_test.py
[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/services/test/git_test.py
[modify] https://crrev.com/abec83dc48383906c9c24d9c5d1738d0a89fefc6/appengine/findit/pipelines/compile_failure/analyze_compile_failure_pipeline.py

Status: Fixed (was: Assigned)

Sign in to add a comment