New issue
Advanced search Search tips

Issue 829919 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

Puffin fuzz target is not well-formed

Project Member Reported by cmt...@chromium.org, Apr 6 2018

Issue description

The puffin fuzz target, although it works, is not well-formeda s the main function calls three different functions that accept different formats.  

It ought to be split into three different fuzz targets.

This is particularly important, as it is being help up as an example in the fuzzer user documentation.
 
I thought more about it and looked at the code more. There are many common part of code that I rather not to separate. Besides it adds to much unneeded complexity to the source, gyp files and ebuilds.

If we want a simple example, then we should write a simple one instead of complicating the other ones. If you really need it to be three executables. I can set up macros that creates three executables based on parameters in the gyp file. But even that I don't really see it necessary.
Cc: infe...@chromium.org
I guess we don't need 3 separate binaries, but it would be awesome to have a target that the fuzzed only format, so that the main example fuzzer isn't flawed in any way.

Would you mind creating another target, let's say "puffin_huff_fuzzer" that only called FuzzHuff. This could be used as the primary example fuzzer without accidentally teaching people not-great practices.

I suppose you could keep the call to FuzzHuff in puffin_fuzzer, or you could remove it (which is preferable) but what happens here is less important since it isn't going to be the primary example fuzzer.
I had in mind to create a new fuzzer for bsdiff program (https://cs.corp.google.com/chromeos_public/src/aosp/external/bsdiff/). That would only have one function: bspatch(). Would that be something you would be interested instead?
Sure. Sounds good.

Thanks!
submitted aosp/663027 for review. Will send the ebuild stuff after it lands.
Status: Fixed (was: Untriaged)

Sign in to add a comment