Puffin fuzz target is not well-formed |
|||
Issue descriptionThe puffin fuzz target, although it works, is not well-formeda s the main function calls three different functions that accept different formats. It ought to be split into three different fuzz targets. This is particularly important, as it is being help up as an example in the fuzzer user documentation.
,
Apr 9 2018
I guess we don't need 3 separate binaries, but it would be awesome to have a target that the fuzzed only format, so that the main example fuzzer isn't flawed in any way. Would you mind creating another target, let's say "puffin_huff_fuzzer" that only called FuzzHuff. This could be used as the primary example fuzzer without accidentally teaching people not-great practices. I suppose you could keep the call to FuzzHuff in puffin_fuzzer, or you could remove it (which is preferable) but what happens here is less important since it isn't going to be the primary example fuzzer.
,
Apr 9 2018
I had in mind to create a new fuzzer for bsdiff program (https://cs.corp.google.com/chromeos_public/src/aosp/external/bsdiff/). That would only have one function: bspatch(). Would that be something you would be interested instead?
,
Apr 9 2018
Sure. Sounds good. Thanks!
,
Apr 11 2018
submitted aosp/663027 for review. Will send the ebuild stuff after it lands.
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/36ff863d868e65dc713f22fd5e246dbdbd724fa7 commit 36ff863d868e65dc713f22fd5e246dbdbd724fa7 Author: Amin Hassani <ahassani@google.com> Date: Mon Apr 23 20:07:22 2018 Add bspatch_fuzzer to the bsdiff ebuild Add the dependency to chromium-os-fuzzers ebuild. Marking 9999 ebuild for dev-util/bsdiff as stable to pick up the latest fuzzer CL: https://android-review.googlesource.com/c/platform/external/bsdiff/+/663027 BUG= chromium:829919 TEST=puffin_fuzzer Change-Id: I040c446cc4e0d8812aa22ed5406691fe51fd17dd Reviewed-on: https://chromium-review.googlesource.com/1020147 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/36ff863d868e65dc713f22fd5e246dbdbd724fa7/dev-util/bsdiff/bsdiff-9999.ebuild [modify] https://crrev.com/36ff863d868e65dc713f22fd5e246dbdbd724fa7/virtual/chromium-os-fuzzers/chromium-os-fuzzers-1.ebuild [rename] https://crrev.com/36ff863d868e65dc713f22fd5e246dbdbd724fa7/virtual/chromium-os-fuzzers/chromium-os-fuzzers-1-r2.ebuild [rename] https://crrev.com/36ff863d868e65dc713f22fd5e246dbdbd724fa7/dev-util/bsdiff/bsdiff-4.3.1-r14.ebuild
,
May 10 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ahass...@chromium.org
, Apr 6 2018