New issue
Advanced search Search tips

Issue 829890 link

Starred by 23 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 22
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Fontconfig outdated: it should be used the system fontconfig

Reported by deced...@gmail.com, Apr 6 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36

Steps to reproduce the problem:
All info in these threads: https://bugs.archlinux.org/task/58125 https://bbs.archlinux.org/viewtopic.php?id=235643
https://bugs.freedesktop.org/show_bug.cgi?id=105818

What is the expected behavior?

What went wrong?
fontconfig validation outdated

Did this work before? N/A 

Chrome version: 65.0.3325.181  Channel: stable
OS Version: 
Flash Version:
 
Components: Blink>Fonts

Comment 2 by deced...@gmail.com, Apr 7 2018

Why doesn't Chromium use the system fontconfig?
Labels: Needs-Triage-M65

Comment 4 by r...@endlessm.com, Apr 10 2018

This is a pretty serious/conspicuous issue for any Linux system that uses the new fontconfig - the latest version of fontconfig changes the config format in a backwards-incompatible way.

The version of fontconfig bundled in Chromium is no longer compatible with the default /etc/fonts/conf.d files which come with the system fontconfig, so many of them aren't valid/loaded any more by the older fontconfig inside Chromium.

The user-visible effect is that inside Chrome (or derived Chromium, Electron, etc) apps many of the system fonts are not accessible. This can leave you with very few fonts available inside of Chromium and a commensurately terrible UI.

Comment 5 by deced...@gmail.com, Apr 10 2018

That's why I don't see much point (I guess Chromium programmers do) in not using the system's fontconfig. Why duplicate roles?

Comment 6 by r...@endlessm.com, Apr 10 2018

Well - I think you said it: I guess Chromium programmers do. This ticket isn't a good place to re-visit the Chromium policy on whether libraries are bundled or not - typically things get bundled for very valid reasons including independence from the underlying host system, including certain bugfixes which are required, things like sandboxing and threading changes, etc. The more relevant issue here is just that the bundled fontconfig is now incompatible with the current config format.

Comment 7 by r...@endlessm.com, Apr 10 2018

The minimal/quick fix would be a patch like the one attached, which picks enough of https://cgit.freedesktop.org/fontconfig/commit/?id=9a0fcb948 into fontconfig 2.12 to recognize and ignore the new syntax. If there is any kind of "stable update" process for Chromium 65, this would be a good candidate to quickly stop the config parse errors, which have worked their way into Chrome and Electron etc - then a separate ticket could consider updating to the new fontconfig version on master.
untested-madness.diff
1.8 KB Download
Labels: Triaged-ET TE-NeedsTriageHelp
This issue is out of scope of triaging from TE-end, as this issue is related to Fontconfig.
Hence adding TE-NeedsTriageHelp label and requesting Blink>Fonts team to look into this issue and help in further triaging.

Thanks..
I'm confused.  Evidence on this bug, from the source tree, and from the obvious experience of fontconfig failures messages on my own system, is that chrome uses its own custom version of fontconfig.

However, the executable still seems to require libfontconfig!  What's going on there?  Perhaps someone can explain.

> famine@gentoo /opt/google/chrome (0) $ ldd chrome |grep -i font
> 	libfontconfig.so.1 => /usr/lib64/libfontconfig.so.1 (0x00007f1ccefd8000)
> famine@gentoo /opt/google/chrome (0) $

I'd like to point out this is a major issue hitting a huge number of linux users, as a cursory search of various distro message boards will tell you - it's very strange not to use system libs, and opens you up to exactly this sort of fail and maintenance nightmare - there's no good reason not to use system fontconfig.

> very valid reasons including independence from the underlying host system, including certain bugfixes which are required, things like sandboxing and threading changes, etc

None of those are valid reasons.  There are very rarely any valid reasons for bundling your own versions of freely available third party libs.

1) independence from the underlying host system

This is a nonsense - you can't have independence from the system you're running on.  If you mean building and getting the same effect on a variety of systems, then the right answer is to use the proper tools - e.g. autotools/configure - to make sure your project is properly configured for the system it's building on / targeting.

2) including certain bugfixes which are required

No, you miss more bugfixes than you make by keeping your own versions of 3rd party software - after all, its maintainers are spending more time on it than you are.  Indeed, in the general case this is a huge security risk because there's now a lag on this software to implement any security critical bugs from upstream.  If you have a bugfix you need, get it submitted and fixed upstream.

3) sandboxing

A user has a relationship of trust with their installed libraries on their own system.  If they don't, their system is already compromised anyway, so no security gain is achieved by bypassing the libraries.  If you want sandboxing, don't call library functions that do things like write files to disk, which in most cases is never going to happen anyway.

4) threading changes

This sounds like an absolutely terrible idea - trying to add in threading support to software that a) wasn't designed for it and b) wasn't designed by you is bound to fail.  Make your use of the library threadsafe in your application, or go find a threadsafe alternative.

ldd does a recursive search; use 'readelf -d /opt/google/chrome/chrome | grep NEEDED' to get the direct dependencies. (fontconfig is a transitive dependency pulled by chrome -> libpangocairo-1.0.so.0 -> libfontconfig.so.1.)

I agree that this issue is important, just wanted to explain the ldd output.
Ah, thanks for the info - I never thought about ldd that much, but yes it makes sense for it to be recursive.
Is there any process going on to solve this issue? It has been a pain in the ass but seems nobody is trying to solve this problem. Downgrading fontconfig introduces another issues. Would anybody suggest any workaround?

Comment 14 by e...@chromium.org, Apr 23 2018

Labels: -Pri-2 Pri-3
Status: Available (was: Unconfirmed)
More people star the issue and its priority gets reduced. I thought it worked the other way around?
Affects Fedora 28 which was released May 1.

So at this point we have (I believe):

- Arch
- Gentoo
- Fedora

Ubuntu 18.04 does not seem to be affected.

Owner: thomasanderson@chromium.org
Status: Assigned (was: Available)

Comment 18 by bobp...@gmail.com, May 18 2018

Spent a couple of hours trying to figure out why emojis were no longer working, before I launched chrome from the shell and saw the Fontconfig errors.

Is this something users can workaround with LDD_PRELOAD or similar directive? Or just use Firefox until it's fixed?

Comment 19 by pet...@gmail.com, Jun 5 2018

This is not directly due to the version of fontconfig bundled in chromium. lsof shows that the system lib is being used. I have opera-developer on Arch.

/etc/fonts/fonts.conf, to pick one of the config files, has two extra elements: <its:rules> and <description>. These cause the validation errors when checked against fonts.dtd. I have hacked an alternative fonts.dtd which does validate but I do not propose that as a solution, not least because using a DTD with XML namespaces is not properly supported.

It looks to me that <its.rules> and <description> should be processed before applications like chromium use the content. What I have not discovered is when that should be done. Should /etc/fonts/* contain the <its:rules> and <description> elements? ISTM that they might either be filtered out as part of the installation of fontconfig so that the installed files have been processed. Alternatively is it up to the client to preprocess the files? The examples in the docs for fontconfig 2.13 suggest the former but the docs might be stale.

Comment 20 by bobp...@gmail.com, Jun 5 2018

Pete: see comment 11 as to why the system fontconfig is pulled in. 

Comment 21 by pet...@gmail.com, Jun 5 2018

Bob: thanks but I am not convinced that is the whole story. I was observing lsof rather than ldd. In any case LD_PRELOAD did not help me.

I have been looking at the fontconfig source code and am pretty sure that the error messages originate in fcxml.c. That effectively encapsulates the XML schema and since 2.12.91 (2017-12-14) has processed the new <its:rules> and <description> elements in the config files. I consider that the fonts.dtd and documentation are out of date and will report a bug to freedesktop.org.

I have reasonable confidence that were chromium to adopt the current fontconfig library in its binary build that old config files would be read correctly. <its:*> elements are ignored in the parser and absent <description> elements are NULL in the data structure and "No description" if converted to string.
Project Member

Comment 22 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6db40d91d0bd2afeb39f78f6d22404c3525b63c

commit e6db40d91d0bd2afeb39f78f6d22404c3525b63c
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Jun 14 22:32:23 2018

Update fontconfig to 6cc99d6a

Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
[4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
fix a use-after-free.

Fontconfig also now requires libuuid as a dependency, so whitelist it as a
dependency since we statically link fontconfig.

[1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
[2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
[3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
[4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
[5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
[6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde

BUG= 831146 ,822737, 787020 , 829890 ,847323
TBR=thestig,dnicoara

Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
Reviewed-on: https://chromium-review.googlesource.com/1095538
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567445}
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/DEPS
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/OWNERS
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/README.chromium
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/config.h
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/fc-case/fccase.h
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/e6db40d91d0bd2afeb39f78f6d22404c3525b63c/third_party/fontconfig/include/src/fcstdint.h

Project Member

Comment 23 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e

commit f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Jun 14 23:21:47 2018

Revert "Update fontconfig to 6cc99d6a"

This reverts commit e6db40d91d0bd2afeb39f78f6d22404c3525b63c.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 567445 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U2ZGI0MGQ5MWQwYmQyYWZlYjM5Zjc4ZjZkMjI0MDRjMzUyNWI2M2MM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Builder%20%28dbg%29%2832%29/83483

Sample Failed Step: compile

Original change's description:
> Update fontconfig to 6cc99d6a
> 
> Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> fix a use-after-free.
> 
> Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> dependency since we statically link fontconfig.
> 
> [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> 
> BUG= 831146 ,822737, 787020 , 829890 ,847323
> TBR=thestig,dnicoara
> 
> Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> Reviewed-on: https://chromium-review.googlesource.com/1095538
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567445}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG= 831146 ,822737, 787020 , 829890 ,847323

Change-Id: I47d475941350efc76370fa5eb5043c80c5063495
Reviewed-on: https://chromium-review.googlesource.com/1101759
Cr-Commit-Position: refs/heads/master@{#567472}
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/DEPS
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/OWNERS
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/README.chromium
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/config.h
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/fc-case/fccase.h
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/f5ad97cbf2b2b465dc61d8f93820c7e6cab49e4e/third_party/fontconfig/include/src/fcstdint.h

Project Member

Comment 24 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c91664fce2e753a65b04107ad24c7422691cf9d

commit 0c91664fce2e753a65b04107ad24c7422691cf9d
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Jun 18 23:13:53 2018

Reland "Update fontconfig to 6cc99d6a"

This is a reland of e6db40d91d0bd2afeb39f78f6d22404c3525b63c

Reason for reland: All bots should now have libuuid1 installed ( bug 853048 ).

Original change's description:
> Update fontconfig to 6cc99d6a
>
> Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> fix a use-after-free.
>
> Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> dependency since we statically link fontconfig.
>
> [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
>
> BUG= 831146 ,822737, 787020 , 829890 ,847323
> TBR=thestig,dnicoara
>
> Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> Reviewed-on: https://chromium-review.googlesource.com/1095538
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567445}

TBR=thestig,dnicoara

Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869
Reviewed-on: https://chromium-review.googlesource.com/1104759
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568221}
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/DEPS
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/OWNERS
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/README.chromium
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/config.h
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/fc-case/fccase.h
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcstdint.h

Project Member

Comment 25 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/812edd08bc908333c1c10205cbc5f52ef33c7dec

commit 812edd08bc908333c1c10205cbc5f52ef33c7dec
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Tue Jun 19 05:03:31 2018

Revert "Reland "Update fontconfig to 6cc99d6a""

This reverts commit 0c91664fce2e753a65b04107ad24c7422691cf9d.

Reason for revert: Broke Linux Builder (dbg)(32)

Still missing libuuid:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/83697

[775/4337] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x86)
FAILED: v8_context_snapshot.bin 
python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin
././v8_context_snapshot_generator: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory
./v8_context_snapshot_generator failed with exit code 127

Original change's description:
> Reland "Update fontconfig to 6cc99d6a"
> 
> This is a reland of e6db40d91d0bd2afeb39f78f6d22404c3525b63c
> 
> Reason for reland: All bots should now have libuuid1 installed ( bug 853048 ).
> 
> Original change's description:
> > Update fontconfig to 6cc99d6a
> >
> > Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> > fix a use-after-free.
> >
> > Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> > dependency since we statically link fontconfig.
> >
> > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> >
> > BUG= 831146 ,822737, 787020 , 829890 ,847323
> > TBR=thestig,dnicoara
> >
> > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> > Reviewed-on: https://chromium-review.googlesource.com/1095538
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#567445}
> 
> TBR=thestig,dnicoara
> 
> Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
> Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869
> Reviewed-on: https://chromium-review.googlesource.com/1104759
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568221}

TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org

Change-Id: Icd39638df79083776546d4283675c3e172bbefe4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
Reviewed-on: https://chromium-review.googlesource.com/1105539
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568346}
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/DEPS
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/OWNERS
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/README.chromium
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/config.h
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/fc-case/fccase.h
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcstdint.h

Project Member

Comment 26 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0c1584a2fade0146b7cd3380abe42feda02ad7c

commit a0c1584a2fade0146b7cd3380abe42feda02ad7c
Author: Thomas Anderson <thomasanderson@chromium.org>
Date: Fri Jun 22 22:01:06 2018

Reland "Reland "Update fontconfig to 6cc99d6a""

This reverts commit 812edd08bc908333c1c10205cbc5f52ef33c7dec.

Reason for revert: libuuid1:i386 should now be installed on the bots ( bug 853048 )

Original change's description:
> Revert "Reland "Update fontconfig to 6cc99d6a""
> 
> This reverts commit 0c91664fce2e753a65b04107ad24c7422691cf9d.
> 
> Reason for revert: Broke Linux Builder (dbg)(32)
> 
> Still missing libuuid:
> 
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/83697
> 
> [775/4337] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x86)
> FAILED: v8_context_snapshot.bin 
> python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin
> ././v8_context_snapshot_generator: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory
> ./v8_context_snapshot_generator failed with exit code 127
> 
> Original change's description:
> > Reland "Update fontconfig to 6cc99d6a"
> > 
> > This is a reland of e6db40d91d0bd2afeb39f78f6d22404c3525b63c
> > 
> > Reason for reland: All bots should now have libuuid1 installed ( bug 853048 ).
> > 
> > Original change's description:
> > > Update fontconfig to 6cc99d6a
> > >
> > > Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> > > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> > > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> > > fix a use-after-free.
> > >
> > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> > > dependency since we statically link fontconfig.
> > >
> > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> > > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> > > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> > > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> > > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> > > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> > >
> > > BUG= 831146 ,822737, 787020 , 829890 ,847323
> > > TBR=thestig,dnicoara
> > >
> > > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> > > Reviewed-on: https://chromium-review.googlesource.com/1095538
> > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#567445}
> > 
> > TBR=thestig,dnicoara
> > 
> > Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
> > Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869
> > Reviewed-on: https://chromium-review.googlesource.com/1104759
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#568221}
> 
> TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org
> 
> Change-Id: Icd39638df79083776546d4283675c3e172bbefe4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
> Reviewed-on: https://chromium-review.googlesource.com/1105539
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568346}

TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,ortuno@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
Change-Id: I5fe29b3ff4ba7ec81498878124a39c70d5e9a8be
Reviewed-on: https://chromium-review.googlesource.com/1112179
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Elliott Friedman <friedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569800}
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/DEPS
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/OWNERS
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/README.chromium
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/config.h
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/fc-case/fccase.h
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcstdint.h

Project Member

Comment 27 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee206c596acea3c453ec646c6002972793dbe62e

commit ee206c596acea3c453ec646c6002972793dbe62e
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Mon Jun 25 18:34:05 2018

Revert "Reland "Reland "Update fontconfig to 6cc99d6a"""

This reverts commit a0c1584a2fade0146b7cd3380abe42feda02ad7c.

Reason for revert: It broken Chrome PFQ, see  crbug.com/856142  for more details.

Original change's description:
> Reland "Reland "Update fontconfig to 6cc99d6a""
> 
> This reverts commit 812edd08bc908333c1c10205cbc5f52ef33c7dec.
> 
> Reason for revert: libuuid1:i386 should now be installed on the bots ( bug 853048 )
> 
> Original change's description:
> > Revert "Reland "Update fontconfig to 6cc99d6a""
> > 
> > This reverts commit 0c91664fce2e753a65b04107ad24c7422691cf9d.
> > 
> > Reason for revert: Broke Linux Builder (dbg)(32)
> > 
> > Still missing libuuid:
> > 
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/83697
> > 
> > [775/4337] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x86)
> > FAILED: v8_context_snapshot.bin 
> > python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin
> > ././v8_context_snapshot_generator: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory
> > ./v8_context_snapshot_generator failed with exit code 127
> > 
> > Original change's description:
> > > Reland "Update fontconfig to 6cc99d6a"
> > > 
> > > This is a reland of e6db40d91d0bd2afeb39f78f6d22404c3525b63c
> > > 
> > > Reason for reland: All bots should now have libuuid1 installed ( bug 853048 ).
> > > 
> > > Original change's description:
> > > > Update fontconfig to 6cc99d6a
> > > >
> > > > Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> > > > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> > > > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> > > > fix a use-after-free.
> > > >
> > > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> > > > dependency since we statically link fontconfig.
> > > >
> > > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> > > > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> > > > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> > > > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> > > > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> > > > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> > > >
> > > > BUG= 831146 ,822737, 787020 , 829890 ,847323
> > > > TBR=thestig,dnicoara
> > > >
> > > > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> > > > Reviewed-on: https://chromium-review.googlesource.com/1095538
> > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > > > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#567445}
> > > 
> > > TBR=thestig,dnicoara
> > > 
> > > Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
> > > Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869
> > > Reviewed-on: https://chromium-review.googlesource.com/1104759
> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#568221}
> > 
> > TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org
> > 
> > Change-Id: Icd39638df79083776546d4283675c3e172bbefe4
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
> > Reviewed-on: https://chromium-review.googlesource.com/1105539
> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#568346}
> 
> TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,ortuno@chromium.org,thomasanderson@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
> Change-Id: I5fe29b3ff4ba7ec81498878124a39c70d5e9a8be
> Reviewed-on: https://chromium-review.googlesource.com/1112179
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Elliott Friedman <friedman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569800}

TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,friedman@chromium.org,ortuno@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 
Change-Id: Ic4c518680efb4480a9568829996f5ceebaf459e7
Reviewed-on: https://chromium-review.googlesource.com/1113840
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570103}
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/DEPS
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/OWNERS
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/README.chromium
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/config.h
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/fc-case/fccase.h
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcstdint.h

Project Member

Comment 28 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81162e7432ecf59a861e5ba7be9f28b28b891dea

commit 81162e7432ecf59a861e5ba7be9f28b28b891dea
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Jun 25 22:44:09 2018

"Reland "Update fontconfig to 6cc99d6a"

Reason for reland: this CL includes a fallback for when the tests are run in an
installed environment.  Hopefully this should be sufficient to fix the CrOs bot
breakage.

Original change's description:
> Update fontconfig to 6cc99d6a
>
> Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> fix a use-after-free.
>
> Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> dependency since we statically link fontconfig.
>
> [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
>
> BUG= 831146 ,822737, 787020 , 829890 ,847323
> TBR=thestig,dnicoara
>
> Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> Reviewed-on: https://chromium-review.googlesource.com/1095538
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567445}

TBR=thestig@chromium.org,dnicoara@chromium.org

Bug:  831146 , 822737,  787020 ,  829890 , 847323,  853048 ,  856142 
Change-Id: I74037fc1e7719ab61e6a5aff52ced8845482273b
Reviewed-on: https://chromium-review.googlesource.com/1114078
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570210}
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/DEPS
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/chrome/installer/linux/debian/dist_package_versions.json
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/chrome/installer/linux/debian/update_dist_package_versions.py
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/chrome/installer/linux/rpm/dist_package_provides.json
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/chrome/installer/linux/rpm/update_package_provides.py
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/BUILD.gn
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/OWNERS
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/README.chromium
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/config.h
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/fc-case/fccase.h
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcalias.h
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcaliastail.h
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcftalias.h
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcftaliastail.h
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcobjshash.h
[modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcstdint.h

Project Member

Comment 29 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bec626a2ddc55ab82001da16d0bfc15fe0e9421f

commit bec626a2ddc55ab82001da16d0bfc15fe0e9421f
Author: Daniel Bratell <bratell@opera.com>
Date: Tue Jun 26 17:40:52 2018

Building chromium now requires uuid-dev (uuid/uuid.h)

The latest version of fontconfig requires uuid/uuid.h so
we need to install that in install-build-deps.sh.

(Only tested in Ubuntu 16.04)

Bug:  856666 , 829890 
Change-Id: I586aa703e24a1ea2c10d08948acad37ce177f70f
Reviewed-on: https://chromium-review.googlesource.com/1115129
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570454}
[modify] https://crrev.com/bec626a2ddc55ab82001da16d0bfc15fe0e9421f/build/install-build-deps.sh

Status: Fixed (was: Assigned)
Fontconfig has been updated.

Sign in to add a comment