StyleValueFactory.cpp needs to check if the value is a plain identifier and not a list?

Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/a8f7af3cb00fbabd40d5a407b5528b2d5658436b ([css-typed-om] Add support for grid properties.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

 Issue 829985  has been merged into this issue.

This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c18d9dc6f02c298c663d89bd32a087a09f33d015

commit c18d9dc6f02c298c663d89bd32a087a09f33d015
Author: Darren Shen <shend@chromium.org>
Date: Tue Apr 10 08:37:42 2018

[css-typed-om] Fix unsupported values in non-list-valued properties.

Currently, when we reify a value, we try to first reify it as a single
value. If that fails, we try reifying it as a list value. This code
was written with the incorrect assumption that only list-valued
properties are stored as CSSValueLists. This is not true, as many single
valued properties (such as grid-auto-flow) are stored as CSSValueLists.

This patch adds an additional check so that only properties that are
explicitly marked as list-valued are reified as list values.

Bug:  829881 
Change-Id: I965e38355b9859a43fcb1b940f19237f9f07fdf6
Reviewed-on: https://chromium-review.googlesource.com/1002214
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549455}
[modify] https://crrev.com/c18d9dc6f02c298c663d89bd32a087a09f33d015/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/resources/testhelper.js
[modify] https://crrev.com/c18d9dc6f02c298c663d89bd32a087a09f33d015/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
[modify] https://crrev.com/c18d9dc6f02c298c663d89bd32a087a09f33d015/third_party/blink/renderer/core/css/cssom/style_value_factory.cc

ClusterFuzz has detected this issue as fixed in range 549453:549455.

Detailed report: https://clusterfuzz.com/testcase?key=4695778384412672

Fuzzer: inferno_twister
Job Type: linux_asan_chrome_v8_arm
Platform Id: linux

Crash Type: Security DCHECK failure
Crash Address: 
Crash State:
  value.IsValueList() in CSSValueList.h
  blink::CreateStyleValueWithProperty
  blink::StyleValueFactory::CssValueToStyleValueVector
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=548295:548296
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_v8_arm&range=549453:549455

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4695778384412672

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

ClusterFuzz testcase 4695778384412672 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot