New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829846 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Two WebViewSurfaceSynchronizationTest tests flaky on Windows

Project Member Reported by smcgruer@chromium.org, Apr 6 2018

Issue description

The following tests:

WebViewTests/WebViewSurfaceSynchronizationTest.AutosizeBeforeNavigation/0
WebViewTests/WebViewSurfaceSynchronizationTest.AutoSizeHeight/0

are timeout-flaky to lesser or greater extent across most/all of the Windows bots:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=WebViewTests/WebViewSurfaceSynchronizationTest.AutosizeBeforeNavigation/0

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=WebViewTests/WebViewSurfaceSynchronizationTest.AutoSizeHeight/0

Example recent failure:

[ RUN      ] WebViewTests/WebViewSurfaceSynchronizationTest.AutosizeBeforeNavigation/0
[7588:3956:0406/061707.423:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[7588:2732:0406/061707.431:WARNING:chrome_browser_main_win.cc(630)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=WebViewTests/WebViewSurfaceSynchronizationTest.AutosizeBeforeNavigation/0 --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir1616_32021\results1616_29539\test_results.xml" --test-launcher-summary-output="e:\b\s\w\iom0gpw3\output.json" --user-data-dir="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir1616_32021\d1616_24029" --disable-offline-auto-reload --use-fake-device-for-media-stream --js-flags=--expose-gc --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=SurfaceSynchronization,TestFeatureForBrowserTest1 --disable-features=GuestViewCrossProcessFrames,NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank


[ RUN      ] WebViewTests/WebViewSurfaceSynchronizationTest.AutoSizeHeight/0
[1088:4668:0406/061706.964:WARNING:chrome_browser_main_win.cc(630)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=WebViewTests/WebViewSurfaceSynchronizationTest.AutoSizeHeight/0 --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir1616_32021\results1616_21302\test_results.xml" --test-launcher-summary-output="e:\b\s\w\iom0gpw3\output.json" --user-data-dir="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir1616_32021\d1616_15325" --disable-offline-auto-reload --use-fake-device-for-media-stream --js-flags=--expose-gc --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=SurfaceSynchronization,TestFeatureForBrowserTest1 --disable-features=GuestViewCrossProcessFrames,NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[1088:2596:0406/061706.979:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062


Assigned components and cc based on /components/guest_view/OWNERS file. I have yet to determine if the flake seems to be caused by anything recent, or if its been around for a while.
 
Owner: wjmaclean@chromium.org
Status: Assigned (was: Available)
It does look like it got worse within the last 30 builds on the flake dashboards, but I have been unable to identify any relevant CL there.

wjmaclean@, can you take a look? Thanks.

Comment 2 by mcnee@chromium.org, Apr 6 2018

Cc: wjmaclean@chromium.org lfg@chromium.org
Owner: mcnee@chromium.org
The /0 versions are for kGuestViewCrossProcessFrames disabled. I've been meaning to remove these.
Labels: -Sheriff-Chromium
Cc: -smcgruer@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fb02122d52f011c6cbe7db0d9b740a10e73385f

commit 9fb02122d52f011c6cbe7db0d9b740a10e73385f
Author: Kevin McNee <mcnee@chromium.org>
Date: Wed Apr 25 20:41:31 2018

Remove BrowserPlugin parameterization of WebView browsertests.

WebViewTests and WebViewInteractiveTests now only run for the
GuestViewCrossProcessFrames enabled case.

Bug: 533069,  544782 , 627962,  796344 , 807116,  818161 ,  818205 ,  829846 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic3a971b553fe343466a440ed4363389cd9e89214
Reviewed-on: https://chromium-review.googlesource.com/1000137
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553727}
[modify] https://crrev.com/9fb02122d52f011c6cbe7db0d9b740a10e73385f/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/9fb02122d52f011c6cbe7db0d9b740a10e73385f/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
[modify] https://crrev.com/9fb02122d52f011c6cbe7db0d9b740a10e73385f/testing/buildbot/filters/mash.browser_tests.filter
[modify] https://crrev.com/9fb02122d52f011c6cbe7db0d9b740a10e73385f/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/9fb02122d52f011c6cbe7db0d9b740a10e73385f/testing/buildbot/filters/viz.browser_tests.filter

Comment 6 by mcnee@chromium.org, Apr 26 2018

Status: Fixed (was: Assigned)
The /0 versions have been removed.

Sign in to add a comment