New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 829827 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
clamy@chromium.org
creis@chromium.org
alex...@chromium.org
█ nasko@chromium.org
wfh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

When navigating from a proxy, the appropriate transition should be set for POST navigations

Project Member Reported by clamy@chromium.org, Apr 6 2018 
RenderFrameHostProxy::OnOpenURL always sets the transition to ui::PAGE_TRANSITION_LINK. This is not appropriate if the navigation is a POST.

Comment 1 by lukasza@chromium.org, Apr 6 2018

Components: Internals>Sandbox>SiteIsolation
What are the consequences of the inappropriate transition flavour?

Comment 2 by alex...@chromium.org, Apr 6 2018 

I don't think we thought through the consequences yet; we spotted this during code review for https://chromium-review.googlesource.com/c/chromium/src/+/959012/1/content/browser/frame_host/render_frame_proxy_host.cc#304.  It seems like transition should be PAGE_TRANSITION_FORM_SUBMIT if |params.uses_post| is true.  

The transition goes on the NavigationEntry, so potentially checks like this one in search_engine_tab_helper.cc would be incorrect:  https://cs.chromium.org/chromium/src/chrome/browser/ui/search_engines/search_engine_tab_helper.cc?l=37&rcl=7997314c98e98afb41f6c6c523aaffbc70c68a94. This particular one looks like we'd autogenerate keywords for form submissions when we shouldn't, though I haven't tried to repro this.

Comment 3 by amaralp@chromium.org, Apr 13 2018

Status: Available (was: Untriaged)
►

Sign in to add a comment