Issue metadata
Sign in to add a comment
|
Voice over for encrypted passwords are read differently in settings and Autofill suggestions. |
||||||||||||||||||||||||
Issue descriptionApp Version: 67.0.3390.0 canary iOS Version: 10.3.3, 11.4 beta Device: iPhone,iPad Url : https://rsolomakhin.github.io/autofill/ Prerequisite: 1. Enable Voice over from device settings. 2. Have few passwords saved from https://rsolomakhin.github.io/autofill/ Steps to reproduce: 1. Launch chrome. 2. Tap on Menu > Settings > Save Passwords. 3. Tap on any password. 4. Scroll the Cursor to passwords. 5. Tap on Done. 6. Go to “https://rsolomakhin.github.io/autofill/‘ 7. Tap on Password in Name/password field. 8. Scroll the cursor to Autofill suggestions above the keyboard. Observed results: At Step 4 : Encrypted password is read as “9 black circles‘ At Step 8 : Encrypted password is read as “8 bullets” Expected results: Encrypted password should be read same in settings and autofill suggestions. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: NA Bug reproducible on the current beta channel build :M65, NA (New Feature) Bug reproducible on the current beta channel build :M66, NA (New Feature) Link to Video : https://drive.google.com/file/d/1aZlsclC7lssyz1FcBiM1kdJsmH08I8hA/view?usp=sharing
,
Apr 10 2018
Vasilii is better owner for this.
,
Apr 11 2018
9 vs. 8 is expected. We agreed to always show 8 bullets regardless of the length of the password. For the circle vs. bullet it's a bug. In the settings we use U+25CF symbol (Black Circle) while in the accessory bar it's U+2022 (Bullet). On desktop Views we use the bullet character (https://cs.chromium.org/chromium/src/ui/gfx/render_text.h?dr=CSs&q=2022+file:%5Esrc/ui/gfx/+package:%5Echromium$&l=192). That's why I used it here. Max, should we use it on iOS too?
,
Apr 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a19457e67a235b89a47f60a5356c63174a0e545a commit a19457e67a235b89a47f60a5356c63174a0e545a Author: vasilii <vasilii@chromium.org> Date: Fri Apr 27 12:56:23 2018 Fix accessibility label for password in the settings. - The string for masked password was using 'Black Circle' symbol instead of 'Bullet'. - The accessibility label wasn't really set. Now 'Hidden, Password' is used in case the password is masked. Bug: 829821 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9f87acefbf9289406718701af6c688f0e49424c6 Reviewed-on: https://chromium-review.googlesource.com/1030633 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#554363} [modify] https://crrev.com/a19457e67a235b89a47f60a5356c63174a0e545a/ios/chrome/browser/ui/settings/cells/password_details_item.mm [modify] https://crrev.com/a19457e67a235b89a47f60a5356c63174a0e545a/ios/chrome/browser/ui/settings/cells/password_details_item_unittest.mm [modify] https://crrev.com/a19457e67a235b89a47f60a5356c63174a0e545a/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm
,
Apr 27 2018
We ended up replacing the black circle with the bullet. Also the accessibility string for '••••' was part of the Chrome binary but not applied correctly. It's 'Hidden, Password'.
,
Apr 30 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by pkl@chromium.org
, Apr 9 2018Owner: dvadym@chromium.org
Status: Assigned (was: Untriaged)