New issue
Advanced search Search tips

Issue 829806 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 832503



Sign in to add a comment

[css-align] Update shorthands to the spec now that they are not ambiguous

Project Member Reported by emilio@chromium.org, Apr 6 2018

Issue description

The grammar was simplified, and as a result the ambiguity is gone now. See:

  https://github.com/w3c/csswg-drafts/issues/2276#issuecomment-378757319
  https://bugzilla.mozilla.org/show_bug.cgi?id=1339656

I've upstreamed tests for this spec / impl change in that Mozilla bug.
 
Asked over IRC, should be there today I'd think.

14:05 <emilio> jgraham: looks like https://bugzilla.mozilla.org/show_bug.cgi?id=1339656 didn't open any wpt-sync PR even though it upstreams a test?
14:06 <emilio> jgraham: note that there was a followup commit to the test file, maybe that confused wpt-sync?14:07 <jgraham> emilio: Upstreaming is stuck pending landing an open PR
14:07 <jgraham> Which I thought would happen last week, but now will almost certainly happen today :)
14:07 <emilio> jgraham: ah ok, blink folks asked about the test in https://bugs.chromium.org/p/chromium/issues/detail?id=829806#c1
14:08 <jgraham> emilio: Apologies for the delay
14:08 — emilio jgraham: no worries, that sounds fine, thank you!

Comment 3 by r...@igalia.com, Apr 9 2018

Ok, thanks for the information. I was just asking to verify I was looking to the right place.
Blocking: 832503
Status: Started (was: Available)
I'm working on this now.

Comment 6 by cnardi@chromium.org, Apr 19 2018

Owner: jfernan...@igalia.com

Comment 7 by emilio@chromium.org, Apr 19 2018

 Issue 834936  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3afa6045ecc3baf120c4436238807c063e5bf7a5

commit 3afa6045ecc3baf120c4436238807c063e5bf7a5
Author: Javier Fernandez <jfernandez@igalia.com>
Date: Fri Apr 20 10:03:46 2018

[css-align] Simple syntax for the Alignment shorthands

Now that the issue [1] about the syntax ambiguity has been resolved we
don´t need to use the custom syntax anymore. The Alignment shorthands
use now the simple syntax, defined based on the longhands' syntax.

Since we allow all the values valid for each longhand, we'll update
in this CL the corresponding web platform tests. Additionally, this CL
updates also the shorthand serialization tests [2], which didn't
consider the new value 'legacy' for justify-items (and place-items) due
to the bug [3] Firefox still has pending to be fixed.


[1] https://github.com/w3c/csswg-drafts/issues/1001
[2] css/css-align/default-alignment/shorthand-serialization-001.html
[3] https://bugzilla.mozilla.org/show_bug.cgi?id=1363875

Bug:  832503 ,  829806 
Change-Id: I53f803b384cc55b0b38292540262e54f803586da
Reviewed-on: https://chromium-review.googlesource.com/1013710
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#552293}
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/place-content-shorthand-001.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/content-distribution/place-content-shorthand-002.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/parse-justify-items-001.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/parse-justify-items-003.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/place-items-shorthand-001.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/place-items-shorthand-002.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/place-items-shorthand-004.html
[delete] https://crrev.com/6907b8c1532ec198277a6090afa7b295b5132d4a/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/shorthand-serialization-001-expected.txt
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/default-alignment/shorthand-serialization-001.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/resources/alignment-parsing-utils.js
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/place-self-shorthand-001.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/place-self-shorthand-002.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/WebKit/LayoutTests/external/wpt/css/css-align/self-alignment/place-self-shorthand-004.html
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/blink/renderer/core/css/properties/css_parsing_utils.h
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/blink/renderer/core/css/properties/shorthands/place_content_custom.cc
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/blink/renderer/core/css/properties/shorthands/place_items_custom.cc
[modify] https://crrev.com/3afa6045ecc3baf120c4436238807c063e5bf7a5/third_party/blink/renderer/core/css/properties/shorthands/place_self_custom.cc

Status: Fixed (was: Started)
This issue should be FIXED now.

Sign in to add a comment