New issue
Advanced search Search tips

Issue 829796 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Report EQT for renderers without main frames.

Project Member Reported by tdres...@chromium.org, Apr 6 2018

Issue description

EQT broke in the face of OOPIF, so we restricted it to only report for renderers containing a main frame.

We should separately cover the case of renderers without main frames.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74d6daa145a14c8699f50dda6fb8f20831865bb4

commit 74d6daa145a14c8699f50dda6fb8f20831865bb4
Author: Nicolas Pena <npm@chromium.org>
Date: Tue Jul 03 15:57:49 2018

Report ExpectedQueueingTime on renderers without main frames

This CL adds a histogram to record EQT on renderer processes that do not
host main frames:
RendererScheduler.ExpectedTaskQueueingDurationWithoutMainFrame

While at it, fix a typo introduced in 5ec2058 in histograms.xml.

Bug:  829796 
Change-Id: I05b3ce7a7cd3eb5432ce4f54eb54bf7100816b97
Reviewed-on: https://chromium-review.googlesource.com/1120778
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572239}
[modify] https://crrev.com/74d6daa145a14c8699f50dda6fb8f20831865bb4/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/74d6daa145a14c8699f50dda6fb8f20831865bb4/tools/metrics/histograms/histograms.xml

Do we want splits for these renderers as well or not at the moment?
I'd say lets not bother for now, unless we have a concrete use case.
Status: Fixed (was: Assigned)

Sign in to add a comment