Issue metadata
Sign in to add a comment
|
Regression : Unable to scroll the page through mouse wheel after cancelling auto scroll.
Reported by
avsha...@etouch.net,
Apr 6 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version : 67.0.3390.0 (Official Build) ae47769a6d274cb8eeca0f8e7b9198d0b043975f-refs/heads/master@{#548636} 32/64-bit OS : Windows(7,8,8.1,10) Test URL : https://www.google.com/chrome/ What steps will reproduce the problem? 1. Launch chrome and navigate to above test URL. 2. Middle click on the page (do not move the mouse cursor) and hit 'Esc' key. 3. Now try to scroll page Up/Down using mouse wheel and observe. Actual Result : Unable to scroll the page using mouse wheel after cancelling autoscroll. Expected Result : User should be able to scroll the page using mouse wheel even after cancelling the autoscroll. This is a regression issue, broken in M-67 and providing the bisect using per-revision script: Good Build : 67.0.3382.0 (Revision : 546347) Bad Build : 67.0.3383.0 (Revision : 546671) You are probably looking for a change made after 546635 (known good), but no later than 546636 (first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/ed8f674f763a5eaba8c31d417cc13d7190127186..46259cc58e11f12ca3308b694c59a14b195fc703 Suspect : https://chromium.googlesource.com/chromium/src/+/46259cc58e11f12ca3308b694c59a14b195fc703 @sahel : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : 1. Issue is not reproducible on Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS) OS 2. Issue can be reproduced on any page having long contents.
,
Apr 12 2018
,
Apr 13 2018
This also makes half of the middle button clicks on links breaking for the scroll on the current page.
,
Apr 20 2018
Issue 829093 has been merged into this issue.
,
Apr 20 2018
,
Apr 24 2018
Adding the consumer ops hotlist.
,
Apr 25 2018
M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Apr 30 2018
Issue 833078 has been merged into this issue.
,
Apr 30 2018
,
May 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd2d3effe08392fcd5277bf052c2d3ebbeaf8cd1 commit dd2d3effe08392fcd5277bf052c2d3ebbeaf8cd1 Author: Sahel Sharify <sahel@chromium.org> Date: Tue May 01 23:04:51 2018 Wheel scrolling works after autoscroll cancellation. This cl sends a GFS with zero velocity in |OnAutoscrollStart| to make sure that the GFC sent in |onAutoscrollEnd| doesn't get filtered. Processing the GFC will generate a GSE with ends the current scroll sequence. Bug: 829794 Test: WheelScrollingWorksAfterAutoscrollCancel Change-Id: I929e473018f3de9ecf8fafb1f7b2e8e6a9adfd2f Reviewed-on: https://chromium-review.googlesource.com/1026454 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555217} [add] https://crrev.com/dd2d3effe08392fcd5277bf052c2d3ebbeaf8cd1/content/browser/renderer_host/input/fling_browsertest.cc [modify] https://crrev.com/dd2d3effe08392fcd5277bf052c2d3ebbeaf8cd1/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/dd2d3effe08392fcd5277bf052c2d3ebbeaf8cd1/content/test/BUILD.gn [modify] https://crrev.com/dd2d3effe08392fcd5277bf052c2d3ebbeaf8cd1/testing/buildbot/filters/viz.content_browsertests.filter
,
May 2 2018
Merge request for the fix in comment #11. Reason for request: The bug is a release blocker and starred by 16 users.
,
May 2 2018
How is the change listed at #11 looking in canary? Is it verified in safe to merge?
,
May 2 2018
It's been in canary 68.0.3417.0, and I confirm that bug is fixed on the latest canary.
,
May 2 2018
Thank you sahel@. As discussed offline, lets wait until tomorrow for more canary coverage.
,
May 2 2018
*** Bulk Edit *** M67 Stable promotion is coming soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. If fix is already merged to M67 and nothing else is pending, pls mark the bug as fixed. Thank you.
,
May 2 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 3 2018
Update : Retested above issue in latest Canary build #68.0.3418.0 on Windows(7,8,8.1,10) OS and the issue is fixed. Page scroll through mouse wheel is working as intended. Kindly review an attached screen-cast. Thank you..!
,
May 3 2018
The NextAction date has arrived: 2018-05-03
,
May 3 2018
Approving merge to M67 branch 3396 based on comment #14 and #18. Please merge ASAP. Thank you.
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56498477c19dcf5f8b84e2f65ec8d8ba42d4de71 commit 56498477c19dcf5f8b84e2f65ec8d8ba42d4de71 Author: Sahel Sharify <sahel@chromium.org> Date: Thu May 03 15:12:40 2018 Wheel scrolling works after autoscroll cancellation. This cl sends a GFS with zero velocity in |OnAutoscrollStart| to make sure that the GFC sent in |onAutoscrollEnd| doesn't get filtered. Processing the GFC will generate a GSE with ends the current scroll sequence. TBR=bokan@chromium.org, tdresser@chromium.org, dtapuska@chromium.org Bug: 829794 Test: WheelScrollingWorksAfterAutoscrollCancel Change-Id: I929e473018f3de9ecf8fafb1f7b2e8e6a9adfd2f Reviewed-on: https://chromium-review.googlesource.com/1026454 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#555217}(cherry picked from commit dd2d3effe08392fcd5277bf052c2d3ebbeaf8cd1) Reviewed-on: https://chromium-review.googlesource.com/1042545 Cr-Commit-Position: refs/branch-heads/3396@{#454} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [add] https://crrev.com/56498477c19dcf5f8b84e2f65ec8d8ba42d4de71/content/browser/renderer_host/input/fling_browsertest.cc [modify] https://crrev.com/56498477c19dcf5f8b84e2f65ec8d8ba42d4de71/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/56498477c19dcf5f8b84e2f65ec8d8ba42d4de71/content/test/BUILD.gn [modify] https://crrev.com/56498477c19dcf5f8b84e2f65ec8d8ba42d4de71/testing/buildbot/filters/viz.content_browsertests.filter
,
May 3 2018
,
May 3 2018
Issue 838054 has been merged into this issue.
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14a7dc3519a5fbe5c0d8f8e7b1baf3530b533a3a commit 14a7dc3519a5fbe5c0d8f8e7b1baf3530b533a3a Author: Sahel Sharifymoghaddam <sahel@chromium.org> Date: Thu May 03 19:04:30 2018 Revert "Wheel scrolling works after autoscroll cancellation." This reverts commit 56498477c19dcf5f8b84e2f65ec8d8ba42d4de71. Reason for revert: Using gerrit cherry pick caused compile error. Original change's description: > Wheel scrolling works after autoscroll cancellation. > > This cl sends a GFS with zero velocity in |OnAutoscrollStart| to make sure > that the GFC sent in |onAutoscrollEnd| doesn't get filtered. Processing the > GFC will generate a GSE with ends the current scroll sequence. > > TBR=bokan@chromium.org, tdresser@chromium.org, dtapuska@chromium.org > > Bug: 829794 > Test: WheelScrollingWorksAfterAutoscrollCancel > Change-Id: I929e473018f3de9ecf8fafb1f7b2e8e6a9adfd2f > Reviewed-on: https://chromium-review.googlesource.com/1026454 > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#555217}(cherry picked from commit dd2d3effe08392fcd5277bf052c2d3ebbeaf8cd1) > Reviewed-on: https://chromium-review.googlesource.com/1042545 > Cr-Commit-Position: refs/branch-heads/3396@{#454} > Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} TBR=bokan@chromium.org,tdresser@chromium.org,dtapuska@chromium.org,sahel@chromium.org Change-Id: Ie9f0128d548094900e0bcb2cd279d4757764f259 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829794 Reviewed-on: https://chromium-review.googlesource.com/1042618 Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#462} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [delete] https://crrev.com/c2affae07d9ad7dac3aa209238a61e830de13926/content/browser/renderer_host/input/fling_browsertest.cc [modify] https://crrev.com/14a7dc3519a5fbe5c0d8f8e7b1baf3530b533a3a/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/14a7dc3519a5fbe5c0d8f8e7b1baf3530b533a3a/content/test/BUILD.gn [modify] https://crrev.com/14a7dc3519a5fbe5c0d8f8e7b1baf3530b533a3a/testing/buildbot/filters/viz.content_browsertests.filter
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a23a0ab61a528c0a322aea32b5e750315cc5690d commit a23a0ab61a528c0a322aea32b5e750315cc5690d Author: Sahel Sharify <sahel@chromium.org> Date: Thu May 03 19:33:47 2018 Reland "Wheel scrolling works after autoscroll cancellation." This is a reland of 56498477c19dcf5f8b84e2f65ec8d8ba42d4de71 Original change's description: > Wheel scrolling works after autoscroll cancellation. > > This cl sends a GFS with zero velocity in |OnAutoscrollStart| to make sure > that the GFC sent in |onAutoscrollEnd| doesn't get filtered. Processing the > GFC will generate a GSE with ends the current scroll sequence. > > TBR=bokan@chromium.org, tdresser@chromium.org, dtapuska@chromium.org > > Bug: 829794 > Test: WheelScrollingWorksAfterAutoscrollCancel > Change-Id: I929e473018f3de9ecf8fafb1f7b2e8e6a9adfd2f > Reviewed-on: https://chromium-review.googlesource.com/1026454 > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#555217}(cherry picked from commit dd2d3effe08392fcd5277bf052c2d3ebbeaf8cd1) > Reviewed-on: https://chromium-review.googlesource.com/1042545 > Cr-Commit-Position: refs/branch-heads/3396@{#454} > Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} Bug: 829794 Change-Id: I14b668a25070a4e6e504ed59f7ee212c88a4605f Reviewed-on: https://chromium-review.googlesource.com/1042925 Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#465} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [add] https://crrev.com/a23a0ab61a528c0a322aea32b5e750315cc5690d/content/browser/renderer_host/input/fling_browsertest.cc [modify] https://crrev.com/a23a0ab61a528c0a322aea32b5e750315cc5690d/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/a23a0ab61a528c0a322aea32b5e750315cc5690d/content/test/BUILD.gn [modify] https://crrev.com/a23a0ab61a528c0a322aea32b5e750315cc5690d/testing/buildbot/filters/viz.content_browsertests.filter
,
May 10 2018
Confirmed this is working properly in Windows Beta 67.0.3396.40. Thanks!
,
May 10 2018
Issue 840634 has been merged into this issue.
,
May 16 2018
Although mousewheel scrolling no longer gets stuck, now I'm seeing the opposite problem: Autoscroll tends to get stuck if you do a mouse scroll immediately followed by an autoscroll. Steps to reproduce: 1. Use mouse wheel to scroll this page. One or two ticks is enough. 2. Before moving pointer, middle-click to enter autoscroll mode. 3. Move pointer around. Sometimes the autoscroll will work normally, but in many cases, it will fail to scroll the page. I am running the latest beta, Chrome 67.0.3396.48 (Official Build) beta (64-bit) (cohort: Beta), on Windows 10. Possibly related to Issue 831796?
,
May 16 2018
>Comment 28 I believe It has been like that for at least a month (on Beta), before and after this bug fix (I thought it was my mouse).
,
May 16 2018
The bug that you see in comments #28 and #29 is related to crbug.com/835314 issue. The fix for the issue is first landed in 68.0.3412.0
,
May 16 2018
mkterra@ and human.peng@ could you please confirm that the bug that you mentioned in comment #28 and #29 is also reproducible on stable (M66)? Also please try canary if possible to confirm that the issue is fixed on the latest canary version. Thanks
,
May 16 2018
After a quick test I think it is indeed fixed on Canary. Can't test with Stable though, I don't have it installed.
,
May 18 2018
It doesn't seem to reproduce on a different Win10 computer with the latest stable version, Chrome 66.0.3359.181 (Official Build) (64-bit) (cohort: Stable).
,
May 24 2018
#28 still reproduces on today's beta, 67.0.3396.56 (Official Build) beta (64-bit) (cohort: Beta). It is fixed in the latest continuous build, 68.0.3439.0 (Developer Build) (32-bit).
,
May 24 2018
The fix for comment #28 ( crbug.com/835314 ) is landed in M68, and not merged back to M67.
,
Aug 9
Bug mentioned in #28 is not fixed in 68.0.3440.106 (stable 64-bit). Middle-click initiated autoscroll sporadically stops unexpectedly. Very annoying since you don't know how often you have to middle-click until it stays in autoscroll-mode and you can actually scroll. I have this bug since >1year...
,
Aug 9
re comment #36: What you see in comment #28 is different from the original bug described in comment #0. Please file a separate bug with steps to reproduce it. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Apr 6 2018Labels: ReleaseBlock-Stable