Issue metadata
Sign in to add a comment
|
Regression : Autoscroll pointer is not seen after middle click on PDF page.
Reported by
avsha...@etouch.net,
Apr 6 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version : 67.0.3390.0 (Official Build) ae47769a6d274cb8eeca0f8e7b9198d0b043975f-refs/heads/master@{#548636} 32/64-bit OS : Windows(7,8,8.1,10) Test URL : http://cb.vu/unixtoolbox.pdf What steps will reproduce the problem? 1. Launch chrome and navigate to above test URL. 2. Middle click on the PDF (do not move the cursor) and observe the mouse pointer. Actual Result : Auto scroll pointer is not seen after middle click on PDF page (instead, arrow pointer is shown on middle click). Expected Result : Arrow pointer should change to autoscroll pointer after middle click on PDF. This is a regression issue, broken in M-67 and providing the bisect using per-revision script: Good Build : 67.0.3389.0 (Revision : 548274) Bad Build : 67.0.3390.0 (Revision : 548636) You are probably looking for a change made after 548284 (known good), but no later than 548285 (first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/ba98a5acf0ae0d5d244407fca56cb5b1af48fed6..06f223dca0c20272c155d526e78db75d01adb0a3 Suspect : https://chromium.googlesource.com/chromium/src/+/06f223dca0c20272c155d526e78db75d01adb0a3 @Lei : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : 1. Issue is not reproducible on Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS) OS
,
Apr 7 2018
hnakashima: Have you seen this on Windows? Should we just disable changing the cursor altogether when panning on Windows? The auto-scroll pointers fights with the hand cursor and usually wins.
,
Apr 7 2018
Panning on Windows is also really janky. I think the built-in auto-scrolling is fighting with our panning code. Maybe we should disable panning on Windows. https://chromium-review.googlesource.com/1000833
,
Apr 7 2018
Thanks for looking at this, Lei. I tried on Windows and the native panning works, though it's not great. Let's disable and merge to fix the conflict, but I'll propose to, in a future CL, disable the native panning and use the mouse wheel drag. WDYT?
,
Apr 8 2018
It's not obvious how to disable the native panning though. We can try.
,
Apr 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50b9ff0982de02c4e82c658197cd645b45ef71aa commit 50b9ff0982de02c4e82c658197cd645b45ef71aa Author: Lei Zhang <thestig@chromium.org> Date: Sun Apr 08 06:51:04 2018 PDF Viewer: Disable panning code on Windows. Windows can already perform panning natively. BUG= 829791 Change-Id: I1607e85645cba201d12c415f203531459c838442 Reviewed-on: https://chromium-review.googlesource.com/1000833 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#549082} [modify] https://crrev.com/50b9ff0982de02c4e82c658197cd645b45ef71aa/pdf/pdfium/pdfium_engine.cc
,
Apr 8 2018
,
Apr 10 2018
Update : Retested above issue in latest Canary #67.0.3393.0 (64-bit) build on Windows(7,8,8.1,10) OS and the issue is fixed. Auto-scroll pointer is being shown as intended after middle click on PDF. Kindly review an attached screen-cast. (Note : Canary #67.0.3393.0 32-bit failed today, hence will update remaining details once Win 32-bit build gets triggered). Thank you!
,
Apr 11 2018
Update : Verified above issue in latest Dev #67.0.3393.4 (32 & 64-bit) build on Windows(7,8,8.1,10) OS and the issue is fixed. Auto scroll pointer is working as intended on PDF page. Hence adding TE-Verified labels using Dev build. Kindly review an attached screen-cast. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Apr 6 2018