Initialize uninitialized allocatable V8 memory Memory is currently uninitialized after receiving pages from the page pool, after sweeping, and after semi-space flip.
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/001814ee90ac882a08d1e7e8e9e3c468efc6329a commit 001814ee90ac882a08d1e7e8e9e3c468efc6329a Author: Hannes Payer <hpayer@chromium.org> Date: Mon Apr 09 06:38:20 2018 [heap] Initialize free space memory in the sweeper. Bug: chromium:829771 Change-Id: Ia3b6221cdc54c5102760665076f1cb2541d16fb4 Reviewed-on: https://chromium-review.googlesource.com/999634 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52463} [modify] https://crrev.com/001814ee90ac882a08d1e7e8e9e3c468efc6329a/src/globals.h [modify] https://crrev.com/001814ee90ac882a08d1e7e8e9e3c468efc6329a/src/heap/heap.cc [modify] https://crrev.com/001814ee90ac882a08d1e7e8e9e3c468efc6329a/src/heap/heap.h [modify] https://crrev.com/001814ee90ac882a08d1e7e8e9e3c468efc6329a/src/heap/sweeper.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/77aba17a40d75fb9f43c8d575f43423b7879534a commit 77aba17a40d75fb9f43c8d575f43423b7879534a Author: Hannes Payer <hpayer@chromium.org> Date: Wed May 02 19:15:52 2018 [heap] Verify that newly allocated MemoryChunks are pre-initialzed with 0. Bug: chromium:829771 Change-Id: I78eab59fded3f41c93ecb3d5d8a30e1bddc4576e Reviewed-on: https://chromium-review.googlesource.com/1039747 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52925} [modify] https://crrev.com/77aba17a40d75fb9f43c8d575f43423b7879534a/src/heap/spaces.cc [modify] https://crrev.com/77aba17a40d75fb9f43c8d575f43423b7879534a/src/heap/spaces.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/11f576d1cdf5ad6163f31763b9439971fbdaa61c commit 11f576d1cdf5ad6163f31763b9439971fbdaa61c Author: Sathya Gunasekaran <gsathya@chromium.org> Date: Thu May 03 01:03:00 2018 Revert "[heap] Verify that newly allocated MemoryChunks are pre-initialzed with 0." This reverts commit 77aba17a40d75fb9f43c8d575f43423b7879534a. Reason for revert: broke gc stress bot https://ci.chromium.org/buildbot/client.v8/V8%20Mac64%20GC%20Stress/743 Original change's description: > [heap] Verify that newly allocated MemoryChunks are pre-initialzed with 0. > > Bug: chromium:829771 > Change-Id: I78eab59fded3f41c93ecb3d5d8a30e1bddc4576e > Reviewed-on: https://chromium-review.googlesource.com/1039747 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52925} TBR=hpayer@chromium.org,mlippautz@chromium.org Change-Id: I3053cb9d052e520dd6a41f54a6c7e1654fa4d1f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:829771 Reviewed-on: https://chromium-review.googlesource.com/1041245 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#52927} [modify] https://crrev.com/11f576d1cdf5ad6163f31763b9439971fbdaa61c/src/heap/spaces.cc [modify] https://crrev.com/11f576d1cdf5ad6163f31763b9439971fbdaa61c/src/heap/spaces.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/494068c1c203a57bb094641ba9f366e82d03113c commit 494068c1c203a57bb094641ba9f366e82d03113c Author: Hannes Payer <hpayer@chromium.org> Date: Thu May 03 13:46:25 2018 [heap] Clear from space after garbage collection. Bug: chromium:829771 Change-Id: I9e71e6cbba347dd6951e5415332e5178df9b5122 Reviewed-on: https://chromium-review.googlesource.com/1041685 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#52957} [modify] https://crrev.com/494068c1c203a57bb094641ba9f366e82d03113c/src/heap/heap.cc
commit c280e7d4f4001ffe6da3d9a7b8658b2cd590e26a Author: Hannes Payer <hpayer@chromium.org> Date: Thu May 3 12:59:44 2018 +0200 [heap] Clear the memory of pooled pages when allocating from the pool. Change-Id: Ia7a0dd6ddc2477a7656a26548e9a247470d9143f Reviewed-on: https://chromium-review.googlesource.com/1041688 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#52948}
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/8ddaafb143bcfea456e199ece5100d4fb22931b6 commit 8ddaafb143bcfea456e199ece5100d4fb22931b6 Author: Hannes Payer <hpayer@chromium.org> Date: Tue May 08 18:04:44 2018 Revert "[heap] Clear from space after garbage collection." This reverts commit 494068c1c203a57bb094641ba9f366e82d03113c. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=840282 Original change's description: > [heap] Clear from space after garbage collection. > > Bug: chromium:829771 > Change-Id: I9e71e6cbba347dd6951e5415332e5178df9b5122 > Reviewed-on: https://chromium-review.googlesource.com/1041685 > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52957} TBR=hpayer@chromium.org,mlippautz@chromium.org Bug: chromium:829771 Change-Id: I3c36baaf849a7d5dbf48db2ae2178e15b3b886f8 Reviewed-on: https://chromium-review.googlesource.com/1049888 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53079} [modify] https://crrev.com/8ddaafb143bcfea456e199ece5100d4fb22931b6/src/heap/heap.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/cd5d72fd8fd817b64e42bb5dad3c7c6798696a56 commit cd5d72fd8fd817b64e42bb5dad3c7c6798696a56 Author: Hannes Payer <hpayer@chromium.org> Date: Thu Jun 28 12:37:24 2018 Reland "[heap] Clear from space after garbage collection. Bug: chromium:829771 Change-Id: I829b4d40bdbe1474eb7f087059be3e58b154768c Reviewed-on: https://chromium-review.googlesource.com/1106657 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54082} [modify] https://crrev.com/cd5d72fd8fd817b64e42bb5dad3c7c6798696a56/src/flag-definitions.h [modify] https://crrev.com/cd5d72fd8fd817b64e42bb5dad3c7c6798696a56/src/heap/heap.cc [modify] https://crrev.com/cd5d72fd8fd817b64e42bb5dad3c7c6798696a56/src/heap/heap.h [modify] https://crrev.com/cd5d72fd8fd817b64e42bb5dad3c7c6798696a56/src/heap/spaces.cc [modify] https://crrev.com/cd5d72fd8fd817b64e42bb5dad3c7c6798696a56/src/heap/spaces.h [modify] https://crrev.com/cd5d72fd8fd817b64e42bb5dad3c7c6798696a56/test/cctest/heap/test-spaces.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/885f99cde7068369178ca54d0a1f51544a241260 commit 885f99cde7068369178ca54d0a1f51544a241260 Author: Clemens Hammacher <clemensh@chromium.org> Date: Thu Jun 28 13:21:27 2018 Revert "Reland "[heap] Clear from space after garbage collection." This reverts commit cd5d72fd8fd817b64e42bb5dad3c7c6798696a56. Reason for revert: breaks TSAN: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/21284 Original change's description: > Reland "[heap] Clear from space after garbage collection. > > Bug: chromium:829771 > Change-Id: I829b4d40bdbe1474eb7f087059be3e58b154768c > Reviewed-on: https://chromium-review.googlesource.com/1106657 > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54082} TBR=ulan@chromium.org,hpayer@chromium.org Change-Id: I6b719266bd088f8835d2c769d471c8872256fb40 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:829771 Reviewed-on: https://chromium-review.googlesource.com/1118298 Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54086} [modify] https://crrev.com/885f99cde7068369178ca54d0a1f51544a241260/src/flag-definitions.h [modify] https://crrev.com/885f99cde7068369178ca54d0a1f51544a241260/src/heap/heap.cc [modify] https://crrev.com/885f99cde7068369178ca54d0a1f51544a241260/src/heap/heap.h [modify] https://crrev.com/885f99cde7068369178ca54d0a1f51544a241260/src/heap/spaces.cc [modify] https://crrev.com/885f99cde7068369178ca54d0a1f51544a241260/src/heap/spaces.h [modify] https://crrev.com/885f99cde7068369178ca54d0a1f51544a241260/test/cctest/heap/test-spaces.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4c9919e5f0ef3a7e5447267ff4849f34d963afec commit 4c9919e5f0ef3a7e5447267ff4849f34d963afec Author: Hannes Payer <hpayer@chromium.org> Date: Fri Jun 29 12:39:25 2018 Reland "[heap] Clear from space after garbage collection." Bug: chromium:829771 Change-Id: I0e3f81b14d971d077afba2f4065e229b99948808 Reviewed-on: https://chromium-review.googlesource.com/1119687 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54112} [modify] https://crrev.com/4c9919e5f0ef3a7e5447267ff4849f34d963afec/src/flag-definitions.h [modify] https://crrev.com/4c9919e5f0ef3a7e5447267ff4849f34d963afec/src/heap/heap.cc [modify] https://crrev.com/4c9919e5f0ef3a7e5447267ff4849f34d963afec/src/heap/heap.h [modify] https://crrev.com/4c9919e5f0ef3a7e5447267ff4849f34d963afec/src/heap/spaces.cc [modify] https://crrev.com/4c9919e5f0ef3a7e5447267ff4849f34d963afec/src/heap/spaces.h [modify] https://crrev.com/4c9919e5f0ef3a7e5447267ff4849f34d963afec/test/cctest/heap/test-spaces.cc
Comment 1 by hpayer@chromium.org
, Apr 6 2018