cookieStore_special_names.tentative.https.html is flaky |
||||
Issue descriptionhttps://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fcookie-store%2FcookieStore_special_names.tentative.https.html There have been failures (red) and fail-then-pass (gray) on many platforms. Noticed because of failures in wpt-importer: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15381 It seemed like there might be a difference between CQ bots and try bots, because we reset expectations based on try bots but then fail CQ. But maybe it's just flakiness.
,
Apr 6 2018
Failed assertion, for debugging purposes: FAIL cookieStore.set of expired __Secure- cookie name on secure origin assert_equals: expected null but got object "[object Object]"
,
Apr 6 2018
And another: FAIL cookieStore.set of expired __Host- cookie name on secure origin assert_equals: expected null but got object "[object Object]" .. which makes me think using Date.now() is not the best, given how the various browser clocks can get out of sync. Date.now() - 3600 should do it.
,
Apr 6 2018
Tentative fix up for review at https://chromium-review.googlesource.com/c/chromium/src/+/999743
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44c6f177ffcf5868f56cacb138f1393b5648fa82 commit 44c6f177ffcf5868f56cacb138f1393b5648fa82 Author: Joshua Bell <jsbell@chromium.org> Date: Fri Apr 06 19:38:04 2018 Cookie Store: Tentatively deflake special names test The "expires" cases are flaky on all platforms on the bots, although I can't reproduce locally. The test case sets a cookie that expires "now" then expects it can't read it. It may be flaky due to "now" being slightly different between processes, threads, and libraries, allowing the read to succeed. Set the expiry date to be an hour before "now", which should be sufficient. Bug: 829761 Change-Id: Icda1891310dd0a56769877f32405226390e729de Reviewed-on: https://chromium-review.googlesource.com/999743 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#548903} [modify] https://crrev.com/44c6f177ffcf5868f56cacb138f1393b5648fa82/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/44c6f177ffcf5868f56cacb138f1393b5648fa82/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_special_names.tentative.html [modify] https://crrev.com/44c6f177ffcf5868f56cacb138f1393b5648fa82/third_party/WebKit/LayoutTests/external/wpt/cookie-store/cookieStore_special_names.tentative.https.html
,
Apr 9 2018
Flakiness dashboard results look rock solid now. Calling this good. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Apr 6 2018