New issue
Advanced search Search tips

Issue 829748 link

Starred by 1 user
Status: Fixed
Owner:
eladalon@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Merge WebrtcLoggingPrivateStartEventLoggingFunction::FireCallback into super's FireCallback

Project Member Reported by eladalon@chromium.org, Apr 6 2018 
The two differ only in that WebrtcLoggingPrivateStartEventLoggingFunction::FireCallback employs DCHECKs. It would be good to move those DCHEKs into WebrtcLoggingPrivateFunctionWithGenericCallback::FireCallback. However, it would require first to make sure that none of the functions using it ever fail to set the error message.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23b63ae4a4567a265e9ea21112819bf34eb3077f

commit 23b63ae4a4567a265e9ea21112819bf34eb3077f
Author: Elad Alon <eladalon@chromium.org>
Date: Thu Jun 28 22:12:59 2018

Log ID for remote-bound WebRTC event logs

When a remote-bound WebRTC event log is successfully started,
its ID is sent to the calling JS code.

This ID is incorporated into the log's filename, allowing it to
later be retrieved, e.g. if a bug report is submitted.

Bug: 775415,  829748 
Change-Id: Ie3d68b7b9cf6ee94eb468135ad5e25caf3204603
Reviewed-on: https://chromium-review.googlesource.com/1116958
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571295}
[modify] https://crrev.com/23b63ae4a4567a265e9ea21112819bf34eb3077f/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
[modify] https://crrev.com/23b63ae4a4567a265e9ea21112819bf34eb3077f/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h
[modify] https://crrev.com/23b63ae4a4567a265e9ea21112819bf34eb3077f/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc
[modify] https://crrev.com/23b63ae4a4567a265e9ea21112819bf34eb3077f/chrome/browser/media/webrtc/webrtc_event_log_manager.cc
[modify] https://crrev.com/23b63ae4a4567a265e9ea21112819bf34eb3077f/chrome/browser/media/webrtc/webrtc_event_log_manager.h
[modify] https://crrev.com/23b63ae4a4567a265e9ea21112819bf34eb3077f/chrome/browser/media/webrtc/webrtc_event_log_manager_common.h
[modify] https://crrev.com/23b63ae4a4567a265e9ea21112819bf34eb3077f/chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc
[modify] https://crrev.com/23b63ae4a4567a265e9ea21112819bf34eb3077f/chrome/browser/media/webrtc/webrtc_event_log_manager_remote.h
[modify] https://crrev.com/23b63ae4a4567a265e9ea21112819bf34eb3077f/chrome/browser/media/webrtc/webrtc_event_log_manager_unittest.cc
[modify] https://crrev.com/23b63ae4a4567a265e9ea21112819bf34eb3077f/chrome/browser/media/webrtc/webrtc_event_log_uploader.cc
[modify] https://crrev.com/23b63ae4a4567a265e9ea21112819bf34eb3077f/chrome/browser/media/webrtc/webrtc_event_log_uploader_impl_unittest.cc
[modify] https://crrev.com/23b63ae4a4567a265e9ea21112819bf34eb3077f/chrome/browser/media/webrtc/webrtc_logging_handler_host.cc
[modify] https://crrev.com/23b63ae4a4567a265e9ea21112819bf34eb3077f/chrome/browser/media/webrtc/webrtc_logging_handler_host.h
[modify] https://crrev.com/23b63ae4a4567a265e9ea21112819bf34eb3077f/chrome/common/extensions/api/webrtc_logging_private.idl

Comment 2 by eladalon@chromium.org, Jun 28 2018

Owner: eladalon@chromium.org
Status: Fixed (was: Assigned)
►

Sign in to add a comment