New issue
Advanced search Search tips

Issue 829724 link

Starred by 1 user
Status: Fixed
Owner:
pbos@chromium.org
Closed: Apr 2018
Cc:
bsep@chromium.org
nyerramilli@chromium.org
pbomm...@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Incognito icon overlaps on chrome logo in inspect window.

Reported by db...@etouch.net, Apr 6 2018 
Chrome Version: 67.0.3390.0 Revision ae47769a6d274cb8eeca0f8e7b9198d0b043975f-refs/heads/master@{#548636}(32/64 bit)
Windows(10) 

What steps will reproduce the problem?
(1) Launch chrome, press Ctrl+Shift +N to open incognito window.
(2) Give Print command on incognito window,right click on preview page and select inspect option..
(3) Observe on left side corner of devtools wwindow.

Actual: Incognito icon overlaps on chrome logo in inspect window.

Expected: Incognito icon should not overlaps on chrome logo in inspect window.

This is a regression issue, broekn in 'M67', provinding bisect using bisect per revision:
Good Build:67.0.3377.0(Revision : 544611)
Bad Build: 67.0.3378.0(Revision : 544931)

You are probably looking for a change made after 544787 (known good), but no later than 544788 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/cd54fed5e109370d5dd84d59e01819c1b786aefd..979c3c4d8355e456339c648db65c8201991b43af

Suspect: https://chromium.googlesource.com/chromium/src/+/979c3c4d8355e456339c648db65c8201991b43af

Note: This is Win-10 specific issue and it is working fine on Windows(7,8,8.1), Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.4) OS.
Actual_Window.mp4
595 KB View Download
Expected_window.mp4
327 KB View Download
screenshot.png
50.4 KB View Download

Comment 1 by bsep@chromium.org, Apr 6 2018

Cc: bsep@chromium.org
Owner: pbos@chromium.org
This is related to my patch, thanks for the report! Delegating to pbos@
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b5ee6345d13e3067a67ac782070df0bbcbcff51

commit 5b5ee6345d13e3067a67ac782070df0bbcbcff51
Author: Peter Boström <pbos@chromium.org>
Date: Wed Apr 11 00:09:22 2018

Don't render custom icon in incognito on Windows

Prevents popup favicon and Developer Tools window Icon from being
rendered on top of the incognito badge. Drawing the icon next to the
incognito badge was also tested but looked weird (like double icons).

The favicon / Developer Tools icon is still the icon used in the
Windows window switcher and not the incognito badge.

Bug:  chromium:829724 
Change-Id: Ie850cec31d51e808ad718ba96e32eac6b0942158
Reviewed-on: https://chromium-review.googlesource.com/1003378
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549686}
[modify] https://crrev.com/5b5ee6345d13e3067a67ac782070df0bbcbcff51/chrome/browser/ui/views/frame/glass_browser_frame_view.cc

Comment 3 by pbos@chromium.org, Apr 11 2018

Status: Fixed (was: Assigned)

Comment 4 by db...@etouch.net, Apr 11 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3394.0
Update :
Retested This issue on Windows(10)machines using latest Canary #67.0.3394.0 and issue is fixed. Kindly review the attached screen-cast.

Thank you.
Fix_Actual.mp4
583 KB View Download
►

Sign in to add a comment