New issue
Advanced search Search tips

Issue 829722 link

Starred by 1 user
Status: Fixed
Owner:
aee@chromium.org
Closed: Apr 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unwanted extra spacing is seen in 'Spell check' section in chrome://settings page.

Reported by rp...@etouch.net, Apr 6 2018 
Chrome version: 67.0.3390.0 (Official Build) Revision ae47769a6d274cb8eeca0f8e7b9198d0b043975f-refs/heads/master@{#548636}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome,navigate to chrome://settings/languages and click to open 'Spell check' and observe 
 
Actual: Unwanted extra spacing is seen in 'Spell check' section
Expected: Unwanted extra spacing should not be seen in 'Spell check' section

This is regression issue, broken in ‘M 67’ and will soon update other info :
Good build: 67.0.3384.0  (Revision: 547001).
Bad build: 67.0.3385.0 (Revision: 547349).

Note : Issue is not seen on Mac OS X(10.12.6,10.13.1,10.13.4)
Actual_video.mp4
91.9 KB View Download
Expected_video.mp4
185 KB View Download
Actual_screenshot.png
99 KB View Download
Expected_screenshot.png
101 KB View Download

Comment 1 by rp...@etouch.net, Apr 6 2018

Labels: hasbisect-per-revision RegressedIn-67 Target-67 FoundIn-67
Owner: aee@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 547014 (known good), but no later than 547015 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/3d3ff73a6cb26c9661dd1f5abfed8b299157ea26..3f225c8b741e8a079f6a3d3ae58ecf1b727623ac

Suspect : https://chromium.googlesource.com/chromium/src/+/3f225c8b741e8a079f6a3d3ae58ecf1b727623ac

From the CL above, assigning the issue to the concern owner 

@aee- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Comment 2 by aee@chromium.org, Apr 6 2018

Status: Started (was: Assigned)

Comment 3 by aee@chromium.org, Apr 9 2018

before.png
15.3 KB View Download
after.png
15.2 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ade9f57f6b42a2f3eed071cd9bd3fcd70a661e0

commit 3ade9f57f6b42a2f3eed071cd9bd3fcd70a661e0
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue Apr 10 05:18:50 2018

Settings WebUI: remove extra spacing in spellcheck settings list

Bug:  829722 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I372a6f71ff768fdcc5b113b86617db5b92b10e1c
Reviewed-on: https://chromium-review.googlesource.com/998979
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549427}
[modify] https://crrev.com/3ade9f57f6b42a2f3eed071cd9bd3fcd70a661e0/chrome/browser/resources/settings/languages_page/languages_page.html

Comment 5 by aee@chromium.org, Apr 10 2018

Status: Fixed (was: Started)

Comment 6 by khushal....@etouch.net, Apr 11 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3394.0
Rechecked the above issue on latest Canary build #67.0.3394.0 for Windows OS (7, 8, 8.1, 10), Linux OS (14.04 LTS) and the issue is fixed. Please refer the attached screencast.
Fixed_Video.mp4
390 KB View Download
►

Sign in to add a comment