New issue
Advanced search Search tips

Issue 829720 link

Starred by 1 user
Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 678905



Sign in to add a comment

Make interception of workers after redirects follow the spec

Project Member Reported by falken@chromium.org, Apr 6 2018 
Make interception of workers after redirects follow the spec.

For shared workers, right now we differ from the spec since shared workers act like navigations, whereas the spec has more tricky behavior.

For dedicated workers, we also differ since the request for the dedicated worker and requests from dedicated workers are treated like a subresource requests from the parent page.

See discussion in https://github.com/w3c/ServiceWorker/issues/1289

This issue is filed to track the WPT test that will fail at:
https://chromium-review.googlesource.com/c/chromium/src/+/999241

See also issue 731604 and issue 724371
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/481c8679fc2c338abc1a54c45a98c8d4831d8107

commit 481c8679fc2c338abc1a54c45a98c8d4831d8107
Author: Matt Falkenhagen <falken@chromium.org>
Date: Mon Apr 09 08:30:29 2018

service worker: Add tests for inteception of workers after redirects.

This tests behavior discussed here:
https://github.com/w3c/ServiceWorker/issues/1289

Namely it tests when a request for a worker goes through a redirect
chain:
1) On redirect from A -> B, whether the service worker at B
sees the request.
2) After the final redirect, which service worker controls the
resulting client.

The tests are written as specified today. Therefore, Firefox
passes this test (verified in Nightly) and Chrome does not.
(Actually a small change is required to the test to make Firefox
pass it, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1452528)

Currently it only tests shared worker but dedicated worker can
be added in a follow-up patch.

Bug: 829720
Change-Id: Id3b1ea8b952760be0ef9917f2c6a3afe60ca1fb5
Reviewed-on: https://chromium-review.googlesource.com/999241
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549125}
[add] https://crrev.com/481c8679fc2c338abc1a54c45a98c8d4831d8107/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/scope1/redirect.py
[add] https://crrev.com/481c8679fc2c338abc1a54c45a98c8d4831d8107/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/scope2/worker_interception_redirect_webworker.py
[add] https://crrev.com/481c8679fc2c338abc1a54c45a98c8d4831d8107/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/worker-interception-redirect-serviceworker.js
[add] https://crrev.com/481c8679fc2c338abc1a54c45a98c8d4831d8107/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/worker-interception-redirect-webworker.js
[add] https://crrev.com/481c8679fc2c338abc1a54c45a98c8d4831d8107/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/worker_interception_redirect_webworker.py
[add] https://crrev.com/481c8679fc2c338abc1a54c45a98c8d4831d8107/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/worker-interception-redirect.https-expected.txt
[add] https://crrev.com/481c8679fc2c338abc1a54c45a98c8d4831d8107/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/worker-interception-redirect.https.html
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab18be089fb2906d84bb3069e0dab4d2e713269e

commit ab18be089fb2906d84bb3069e0dab4d2e713269e
Author: Matt Falkenhagen <falken@chromium.org>
Date: Mon Apr 23 03:49:37 2018

service worker: Add importScripts() to worker interception test.

Also remove the Firefox-specific comment as they fixed the mentioned
bug.

Bug: 829720
Change-Id: I76727361ff9c7d61931fbf018035917ac5aa71d8
Reviewed-on: https://chromium-review.googlesource.com/1023616
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552629}
[modify] https://crrev.com/ab18be089fb2906d84bb3069e0dab4d2e713269e/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/worker-interception-redirect-serviceworker.js
[modify] https://crrev.com/ab18be089fb2906d84bb3069e0dab4d2e713269e/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/worker-interception-redirect-webworker.js
[modify] https://crrev.com/ab18be089fb2906d84bb3069e0dab4d2e713269e/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/worker-interception-redirect.https-expected.txt
[modify] https://crrev.com/ab18be089fb2906d84bb3069e0dab4d2e713269e/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/worker-interception-redirect.https.html
►

Sign in to add a comment