Disable "Create shortcut" from incognito mode |
|||
Issue descriptionChrome Version: 67 OS: Chrome, Windows, Linux, macOS What steps will reproduce the problem? (1) Open an incognito window. (2) Chrome menu -> More tools -> Create shortcut. What is the expected result? Create shortcut (formerly "Add to desktop") does not exist in Incognito. What happens instead? Create shortcut creates a shortcut to the site. Opening the shortcut opens the site in a non-incognito context. This has always worked this way (since at least 2015), but note that this feature is disabled on Android in incognito. For consistency, it should be disabled on Desktop. It makes little sense to allow the user to create shortcuts to a non-incognito context from incognito.
,
Apr 27 2018
Oops, I thought this one was assigned to me, my bad... WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/1032273
,
Apr 27 2018
It is now! :)
,
Apr 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e956a35b53cfb450e09d123a7026ff297586a20 commit 1e956a35b53cfb450e09d123a7026ff297586a20 Author: Alan Cutter <alancutter@chromium.org> Date: Mon Apr 30 04:56:18 2018 Disable creating page shortcuts in incognito mode This change disables the menu item for creating page/PWA shortcuts while in incognito mode. This makes desktop consistent with Android's behaviour. The test added by this CL uncovered a feature list DCHECK hit when calling GetPwaForSecureActiveTab(). This CL cleans up that minor bug as well. Bug: 829716 Change-Id: I5818a280724e65c8af5e0a0c6a1d24a0809c77bb Reviewed-on: https://chromium-review.googlesource.com/1032273 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#554696} [modify] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/extensions/tab_helper.cc [modify] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/ui/extensions/hosted_app_browsertest.cc [modify] https://crrev.com/1e956a35b53cfb450e09d123a7026ff297586a20/chrome/browser/ui/toolbar/app_menu_model.cc
,
Apr 30 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by alancutter@chromium.org
, Apr 13 2018