"Restore pages" popover is not top-aligned with bottom of omnibox
Reported by
pranjali...@etouch.net,
Apr 6 2018
|
|||||
Issue descriptionChrome Version: 67.0.3389.0 (Official Build) 58f84d059486796cc3652797eab5eab997720cad-refs/heads/master@{#548273}(64 bit) OS: Mac(10.12.6 , 10.13.1 , 10.13.4) OS Steps to reproduce: (1) Launch Chrome, open NTP and enter chrome://inducebrowsercrashforrealz/ in omnibox. (2) Now relaunch chrome and observe the Restore bubble . Actual: Overlapping of 'Restore bubble' is seen on omnibox. Expected: Such overlapping should not be seen. This is a Non-regression issue seen from 'M67' series i.e 67.0.3373.0 NOTE: Issue is not seen on Linux(14.04 LTS) and Windows(7,8,8.1,10) .
,
Apr 13 2018
I think this is intended / expected. Chrome often makes bubbles overlap the top bar slightly to indicate they are real Chrome-created bubbles and not something created within the web page that can look like Chrome.
,
Apr 13 2018
W.r.t comment#2 In case of translate bubble it appears slightly below the omnibox and does not overlap with omnibox border and same is the case with permission bubbles. So when comparing with these bubbles, the restore bubble seems to appear on top of the omnibox border. Kindly request you to look again into this and please refer the attached screenshot. Thank you.
,
Apr 18 2018
Thanks for the screenshot. Oh, UI inconsistency. Over to pkasting@
,
Apr 18 2018
For clarity, the issue here is that the "Restore pages?" popover, which is anchored to the browser menu (I think; we don't inkdrop-highlight that menu when this bubble is visible, which might or might not be a bug), is not top-aligned with the bottom stroke of the omnibox. This is a cross-platform issue, it's just that it manifests differently on different platforms. For example, on Windows, the top border of the bubble is 1 DIP below the omnibox bottom stroke. I'm not sure whether this is really a bug. The popover is not owned by a child of the omnibox. Maybe its existing positioning is fine. ->bsep as Harmony TL to triage.
,
Apr 18 2018
Yeah, it's anchored to the hamburger button and not the omnibox. The fact that it's missing a button highlight is covered by bug 824536 . I don't think anything is wrong with its position per se. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rbasuvula@chromium.org
, Apr 6 2018