New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829665 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 782034
issue 819292



Sign in to add a comment

Slaves should use the master build status to clear their chroots

Project Member Reported by bmgordon@chromium.org, Apr 6 2018

Issue description

Blocking: 782034 819292
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/d8670c049fbe96b57ad8146645149632731a8467

commit d8670c049fbe96b57ad8146645149632731a8467
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Thu Apr 26 06:00:08 2018

build_summary: Helper class to represent build summaries

BuildSummary is a simple class to represent a local summary of a build.
It contains the needed info to find a build or its affiliated master in
CIDB, but doesn't contain any of the other CIDB data.  This will be used
to store and pass local build status between cbuildbot_launch and
cbuildbot.

BUG= chromium:829665 
TEST=New unit tests

Change-Id: I0547036dfdb6525a0271cd54a09afb156e555014
Reviewed-on: https://chromium-review.googlesource.com/1014947
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[add] https://crrev.com/d8670c049fbe96b57ad8146645149632731a8467/lib/build_summary.py
[add] https://crrev.com/d8670c049fbe96b57ad8146645149632731a8467/lib/build_summary_unittest.py
[add] https://crrev.com/d8670c049fbe96b57ad8146645149632731a8467/lib/build_summary_unittest

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0443cb8b843b7cdf70a83c5665455a49cefc91d1

commit 0443cb8b843b7cdf70a83c5665455a49cefc91d1
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Thu Apr 26 06:00:08 2018

cbuildbot: Add --previous-build-state option

cbuildbot_launch will start passing this option when it loads
locally-saved build state.  We need to add it to cbuildbot first so that
it won't reject the option.

BUG= chromium:829665 
TEST=local tryjobs

Change-Id: I5ffdfe6d8e6dd48407575a92800100b9b1c79c42
Reviewed-on: https://chromium-review.googlesource.com/1015648
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/0443cb8b843b7cdf70a83c5665455a49cefc91d1/scripts/cbuildbot.py
[modify] https://crrev.com/0443cb8b843b7cdf70a83c5665455a49cefc91d1/lib/constants.py

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/344eacf147bf39d4754fadc5b39408840f28fdcb

commit 344eacf147bf39d4754fadc5b39408840f28fdcb
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Apr 26 08:06:09 2018

Roll src/third_party/chromite/ 48a13aacf..aa6cca469 (9 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/48a13aacf880..aa6cca46950b

$ git log 48a13aacf..aa6cca469 --date=short --no-merges --format='%ad %ae %s'
2018-04-19 lepton cros_vm: Use a smaller virtual network.
2018-04-24 laszio afdo: refining codes
2018-04-10 dgarrett chromeos_config: TRYBOT -> SWARMING.
2018-04-24 rockot Include libmojo_core.so in Chrome deployment
2018-04-19 pberny chromeos_config: Add sign_types to meowth release
2018-04-20 achuith cros_run_vm_test: Support for fetching results.
2018-04-17 bmgordon cbuildbot: Add --previous-build-state option
2018-04-13 bmgordon build_summary: Helper class to represent build summaries
2018-04-24 dgarrett cros tryjob: Always use PRODUCTION_TRYJOB display label.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:808045,chromium:829170,chromium:None,chromium:822034,chromium:835061,chromium:829665,chromium:829665,chromium:832768


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7d1aa5c4c4bd153fd47f6d7cc7532ac35cdff73b
Reviewed-on: https://chromium-review.googlesource.com/1029771
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553948}
[modify] https://crrev.com/344eacf147bf39d4754fadc5b39408840f28fdcb/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/90b2dd9bdcf6592571767d76d436c113c16393ee

commit 90b2dd9bdcf6592571767d76d436c113c16393ee
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Thu Apr 26 20:01:43 2018

cbuildbot_launch: Track state of the previous build

Attempt to load the state of the previous build from
<root>/.cbuildbot_build_state.json.  When a valid previous state is
loaded from the file, pass it to cbuildbot through
--previous-build-state.

Write the state of the current build to the same file when starting up
and after running cbuildbot.

This will be used by cbuildbot to decide if it is safe to reuse its
chroot (see go/cros-chroot-reuse-master).

BUG= chromium:829665 
TEST=local tryjobs

Change-Id: I22bb1f92a1dab7dd68a585e676b5420d3891962f
Reviewed-on: https://chromium-review.googlesource.com/1014948
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/90b2dd9bdcf6592571767d76d436c113c16393ee/scripts/cbuildbot_launch.py
[modify] https://crrev.com/90b2dd9bdcf6592571767d76d436c113c16393ee/scripts/cbuildbot_launch_unittest.py

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/942fac472373af6a535d5bf7d93343cdd3964ff9

commit 942fac472373af6a535d5bf7d93343cdd3964ff9
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Apr 26 23:46:55 2018

Roll src/third_party/chromite/ aa6cca469..74d7d171a (3 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/aa6cca46950b..74d7d171a121

$ git log aa6cca469..74d7d171a --date=short --no-merges --format='%ad %ae %s'
2018-04-25 yunlian chromeos_config: only set USE=thinlto for amd64 toolchain builders.
2018-04-12 bmgordon cbuildbot_launch: Track state of the previous build
2018-04-23 levarum Copy ndk-translation artifacts when uprevving android

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:827217 , chromium:829665 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ida506a20c73f9feffdc2c0aac80d5eb872ae115d
Reviewed-on: https://chromium-review.googlesource.com/1031170
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554191}
[modify] https://crrev.com/942fac472373af6a535d5bf7d93343cdd3964ff9/DEPS

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/665f43a5d1ecbdde51d55876c20b69e879a51e5d

commit 665f43a5d1ecbdde51d55876c20b69e879a51e5d
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Fri Apr 27 19:22:37 2018

cbuildbot: Use previous build state for chroot reuse

Look up the previous local build and previous master build from the info
passed in --previous-build-state.  If the chroot is otherwise eligible
for reuse (same branch, replace_chroot=False, etc.), make sure the
previous build and master build both succeeded before reusing the
chroot.

BUG= chromium:829665 
TEST=local tryjobs; new unit tests

Change-Id: I278f729763da760a824a88e9bf6d31e6ee006536
Reviewed-on: https://chromium-review.googlesource.com/1014949
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/665f43a5d1ecbdde51d55876c20b69e879a51e5d/cbuildbot/stages/build_stages.py
[modify] https://crrev.com/665f43a5d1ecbdde51d55876c20b69e879a51e5d/cbuildbot/stages/build_stages_unittest.py

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f7781e9bb60bd6a58e02911d1c35d6031c7a520

commit 9f7781e9bb60bd6a58e02911d1c35d6031c7a520
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Apr 28 00:05:06 2018

Roll src/third_party/chromite/ 6b3c651c4..7c0757b09 (7 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/6b3c651c4ed2..7c0757b099e5

$ git log 6b3c651c4..7c0757b09 --date=short --no-merges --format='%ad %ae %s'
2018-04-27 levarum Revert "Copy ndk-translation artifacts when uprevving android"
2018-04-24 dgarrett som: Remove Gardener SOM tree.
2018-04-13 bmgordon cbuildbot: Use previous build state for chroot reuse
2018-04-25 dgarrett config_lib: Define LUCI_BUILDER constants.
2018-04-25 jclinton appengine/cq_stats: Set the Python SSL version to latest
2018-04-26 jclinton appengine: Update the SDK version to support new SSL
2018-04-26 jclinton lib/clactions*: Refactor into separate clactions_metrics for ts_mon

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:None,chromium:829665,chromium:824550,chromium:826372,chromium:826372,chromium:826372


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ic622485c6d32417602f5aff7bc2cc02047e49f9a
Reviewed-on: https://chromium-review.googlesource.com/1033960
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554572}
[modify] https://crrev.com/9f7781e9bb60bd6a58e02911d1c35d6031c7a520/DEPS

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f578e9249f18adad7bf910ffe9fd26a43f100b7a

commit f578e9249f18adad7bf910ffe9fd26a43f100b7a
Author: Don Garrett <dgarrett@chromium.org>
Date: Sat Apr 28 21:56:41 2018

Revert "cbuildbot: Use previous build state for chroot reuse"

This reverts commit 665f43a5d1ecbdde51d55876c20b69e879a51e5d.

Reason for revert: Fix the builds fast.

BUG=chromium:1014949

Original change's description:
> cbuildbot: Use previous build state for chroot reuse
> 
> Look up the previous local build and previous master build from the info
> passed in --previous-build-state.  If the chroot is otherwise eligible
> for reuse (same branch, replace_chroot=False, etc.), make sure the
> previous build and master build both succeeded before reusing the
> chroot.
> 
> BUG= chromium:829665 
> TEST=local tryjobs; new unit tests
> 
> Change-Id: I278f729763da760a824a88e9bf6d31e6ee006536
> Reviewed-on: https://chromium-review.googlesource.com/1014949
> Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
> Tested-by: Benjamin Gordon <bmgordon@chromium.org>
> Reviewed-by: Don Garrett <dgarrett@chromium.org>

Bug:  chromium:829665 
Change-Id: Ie764f9f883192f023d48e4471f3d7052d98e5450
Reviewed-on: https://chromium-review.googlesource.com/1034312
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/f578e9249f18adad7bf910ffe9fd26a43f100b7a/cbuildbot/stages/build_stages.py
[modify] https://crrev.com/f578e9249f18adad7bf910ffe9fd26a43f100b7a/cbuildbot/stages/build_stages_unittest.py

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb21222c5a991ad172c8aa1bfdddf4ab312f9aa0

commit fb21222c5a991ad172c8aa1bfdddf4ab312f9aa0
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Apr 28 23:17:18 2018

Roll src/third_party/chromite/ ae26814f3..f578e9249 (1 commit)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ae26814f310e..f578e9249f18

$ git log ae26814f3..f578e9249 --date=short --no-merges --format='%ad %ae %s'
2018-04-28 dgarrett Revert "cbuildbot: Use previous build state for chroot reuse"

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:1014949, chromium:829665 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I969623ebc1f77fd01e3f65def944d980d6831199
Reviewed-on: https://chromium-review.googlesource.com/1034293
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554659}
[modify] https://crrev.com/fb21222c5a991ad172c8aa1bfdddf4ab312f9aa0/DEPS

Project Member

Comment 11 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8b6d412457eaf00755121e579ae2620df7c18c8e

commit 8b6d412457eaf00755121e579ae2620df7c18c8e
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Tue May 01 15:20:45 2018

cbuildbot_launch: Migrate state to new JSON file

The new JSON state file introduced in crrev.com/c/1014948 contains a
dictionary, so it can track arbitrary keys.  Move the existing state
file into the new file so that we can track one state instead of two.

BUG= chromium:829665 
TEST=local tryjobs

Change-Id: I0adeada6e014948b8bb95533fe17a56f4b512a20
Reviewed-on: https://chromium-review.googlesource.com/1033546
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Trybot-Ready: Benjamin Gordon <bmgordon@chromium.org>

[modify] https://crrev.com/8b6d412457eaf00755121e579ae2620df7c18c8e/lib/build_summary.py
[modify] https://crrev.com/8b6d412457eaf00755121e579ae2620df7c18c8e/scripts/cbuildbot_launch.py
[modify] https://crrev.com/8b6d412457eaf00755121e579ae2620df7c18c8e/scripts/cbuildbot_launch_unittest.py

Project Member

Comment 12 by bugdroid1@chromium.org, May 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a4ae95b47bc433d4512ff511f8ad8488e677b72

commit 8a4ae95b47bc433d4512ff511f8ad8488e677b72
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue May 01 17:36:34 2018

Roll src/third_party/chromite/ 394dddbed..8b6d41245 (1 commit)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/394dddbed8e1..8b6d412457ea

$ git log 394dddbed..8b6d41245 --date=short --no-merges --format='%ad %ae %s'
2018-04-26 bmgordon cbuildbot_launch: Migrate state to new JSON file

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:829665 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I67c030f44692b21e0f22f460fabbe0e176a0adcf
Reviewed-on: https://chromium-review.googlesource.com/1037191
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555094}
[modify] https://crrev.com/8a4ae95b47bc433d4512ff511f8ad8488e677b72/DEPS

Project Member

Comment 13 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9dea5038cdf1358c766cf4bd55bfdbcde7b49b8e

commit 9dea5038cdf1358c766cf4bd55bfdbcde7b49b8e
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Wed May 02 17:10:10 2018

Reland "cbuildbot: Use previous build state for chroot reuse"

The bug that required the revert was fixed in CL:1034294.

BUG= chromium:829665 
TEST=local tryjobs

Change-Id: Iecc6650a3df4ee34241407fe1986c6ed2a04d03f
Reviewed-on: https://chromium-review.googlesource.com/1037193
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Trybot-Ready: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/9dea5038cdf1358c766cf4bd55bfdbcde7b49b8e/cbuildbot/stages/build_stages.py
[modify] https://crrev.com/9dea5038cdf1358c766cf4bd55bfdbcde7b49b8e/cbuildbot/stages/build_stages_unittest.py

Project Member

Comment 14 by bugdroid1@chromium.org, May 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8bbc95a0f901de4e9706d99aea2d85815a50b2e

commit d8bbc95a0f901de4e9706d99aea2d85815a50b2e
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 02 21:01:10 2018

Roll src/third_party/chromite/ 5d4cebe79..9dea5038c (1 commit)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/5d4cebe797eb..9dea5038cdf1

$ git log 5d4cebe79..9dea5038c --date=short --no-merges --format='%ad %ae %s'
2018-05-01 bmgordon Reland "cbuildbot: Use previous build state for chroot reuse"

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:829665 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib2d03b9830dbc167cc5111d0f16a0d6eec7fab1b
Reviewed-on: https://chromium-review.googlesource.com/1040113
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555513}
[modify] https://crrev.com/d8bbc95a0f901de4e9706d99aea2d85815a50b2e/DEPS

Project Member

Comment 15 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8642bcc3248fa1a791d9c287420487c817782ae6

commit 8642bcc3248fa1a791d9c287420487c817782ae6
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Thu May 03 14:18:09 2018

cbuildbot_launch: Remove old state handling

CL:1033546 migrated the saved cbuildbot_launch state to a new format.
This has been running on all the builders for long enough to get most of
them migrated, so delete the code that handled the old state file.

BUG= chromium:829665 
TEST=unit tests; local tryjobs

Change-Id: I339b4478162690a83102b91512af43edaea98126
Reviewed-on: https://chromium-review.googlesource.com/1040846
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>

[modify] https://crrev.com/8642bcc3248fa1a791d9c287420487c817782ae6/scripts/cbuildbot_launch.py
[modify] https://crrev.com/8642bcc3248fa1a791d9c287420487c817782ae6/scripts/cbuildbot_launch_unittest.py

Project Member

Comment 16 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28029b0df039f11aa916cc0c5c65f4ebd4ccd038

commit 28029b0df039f11aa916cc0c5c65f4ebd4ccd038
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu May 03 17:11:27 2018

Roll src/third_party/chromite/ 5295eaac6..8642bcc32 (1 commit)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/5295eaac6d22..8642bcc3248f

$ git log 5295eaac6..8642bcc32 --date=short --no-merges --format='%ad %ae %s'
2018-05-01 bmgordon cbuildbot_launch: Remove old state handling

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:829665 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I657a9225a76249b9e4a18304f426bc5bee42a305
Reviewed-on: https://chromium-review.googlesource.com/1042378
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#555779}
[modify] https://crrev.com/28029b0df039f11aa916cc0c5c65f4ebd4ccd038/DEPS

Project Member

Comment 17 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/6cf26f13cd9fd243dd311500e7fd78a92a8a2523

commit 6cf26f13cd9fd243dd311500e7fd78a92a8a2523
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Wed May 09 19:11:39 2018

build_stages: Consolidate chroot reuse logic

Most of the logic for chroot reuse was previously moved into the
CanReuseChroot function, but there was one check left in PerformStage.
Move the remaining check for consistency.

BUG= chromium:829665 
TEST=local tryjobs

Change-Id: I1c97fd5483e3eb1cbf1838c3b3361bbf3b739db2
Reviewed-on: https://chromium-review.googlesource.com/1040681
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/6cf26f13cd9fd243dd311500e7fd78a92a8a2523/cbuildbot/stages/build_stages.py
[modify] https://crrev.com/6cf26f13cd9fd243dd311500e7fd78a92a8a2523/cbuildbot/stages/build_stages_unittest.py

Project Member

Comment 18 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed353509d36e0c2dc2df427861f70bd2f5e12b5c

commit ed353509d36e0c2dc2df427861f70bd2f5e12b5c
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 09 20:47:36 2018

Roll src/third_party/chromite/ 7aaefdbb7..6cf26f13c (1 commit)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/7aaefdbb734f..6cf26f13cd9f

$ git log 7aaefdbb7..6cf26f13c --date=short --no-merges --format='%ad %ae %s'
2018-05-02 bmgordon build_stages: Consolidate chroot reuse logic

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:829665 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ide45e5f3e4d1f488100a9c9fa73554cf19c0565d
Reviewed-on: https://chromium-review.googlesource.com/1052822
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557309}
[modify] https://crrev.com/ed353509d36e0c2dc2df427861f70bd2f5e12b5c/DEPS

Project Member

Comment 19 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/d917507c36fa84f5b93f5e615881cda6d517682e

commit d917507c36fa84f5b93f5e615881cda6d517682e
Author: Benjamin Gordon <bmgordon@chromium.org>
Date: Thu May 10 22:10:02 2018

build_stages: Use snapshot to clean up chroot.

When the chroot could potentially be reused by the running build config
but needs to be deleted on this run, try to revert to a clean snapshot
instead of deleting.  If the chroot can't be reused or the revert fails,
delete as normal.

BUG= chromium:829665 , chromium:730144
TEST=unit tests; local tryjobs

Change-Id: I1e2b0fe11b6b034c0ca3e06d6938b6b53afb66b6
Reviewed-on: https://chromium-review.googlesource.com/1043001
Commit-Ready: Benjamin Gordon <bmgordon@chromium.org>
Tested-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/d917507c36fa84f5b93f5e615881cda6d517682e/lib/constants.py
[modify] https://crrev.com/d917507c36fa84f5b93f5e615881cda6d517682e/cbuildbot/stages/build_stages.py
[modify] https://crrev.com/d917507c36fa84f5b93f5e615881cda6d517682e/cbuildbot/stages/build_stages_unittest.py

Project Member

Comment 20 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6297b2be6ab0dde891052b935537b2b29ab499a

commit b6297b2be6ab0dde891052b935537b2b29ab499a
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri May 11 00:15:20 2018

Roll src/third_party/chromite/ 0aae1c1fc..3c311c157 (4 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/0aae1c1fc30a..3c311c15709b

$ git log 0aae1c1fc..3c311c157 --date=short --no-merges --format='%ad %ae %s'
2018-05-09 manojgupta cbuildbot: Disable unit tests in fuzzer builds.
2018-04-20 bmgordon build_stages: Use snapshot to clean up chroot.
2018-05-04 yunlian generic_stages: temporarily ignore all target prebuilts.
2018-05-08 guocb auto_updater: filter more directories when copy devserver to DUT

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:841512 , chromium:829665 ,chromium:730144, chromium:826418 , chromium:840975 ,chromium:824580


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I0abebd960beb44b1560aca995781fed1b91f453f
Reviewed-on: https://chromium-review.googlesource.com/1054619
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557735}
[modify] https://crrev.com/b6297b2be6ab0dde891052b935537b2b29ab499a/DEPS

Status: Fixed (was: Started)

Comment 22 by sjg@chromium.org, May 15 2018

Cc: akes...@chromium.org
Great to see this done, congrats Ben!

Sign in to add a comment