This came up during codereview: https://chromium-review.googlesource.com/c/chromium/src/+/997096/1/chrome/browser/chromeos/extensions/wallpaper_api.cc#192 From the comment: WallpaperSetWallpaperFunction continues to do work after responding (SendResponse/Respond). It would be cleaner to tweak this so that we only respond once the work is done. Assigning to wallpaper OWNER to triage.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb2837fb977d7f2754e2c417d69cda5648b6a67f commit cb2837fb977d7f2754e2c417d69cda5648b6a67f Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Tue Apr 10 01:22:25 2018 Turn wallpaper related api functions into UIThreadExtensionFunction. AsynExtensionFunction is deprecated and soon will be removed. This CL makes remaining wallpaper.* and wallpaperPrivate.* functions extend from UIThreadExtensionFunction. Bug: 829174 , 829653 Change-Id: I132bcea28e3406feb4f09743eea466214cc27a8d Reviewed-on: https://chromium-review.googlesource.com/997096 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549361} [modify] https://crrev.com/cb2837fb977d7f2754e2c417d69cda5648b6a67f/chrome/browser/chromeos/extensions/wallpaper_api.cc [modify] https://crrev.com/cb2837fb977d7f2754e2c417d69cda5648b6a67f/chrome/browser/chromeos/extensions/wallpaper_api.h [modify] https://crrev.com/cb2837fb977d7f2754e2c417d69cda5648b6a67f/chrome/browser/chromeos/extensions/wallpaper_function_base.cc [modify] https://crrev.com/cb2837fb977d7f2754e2c417d69cda5648b6a67f/chrome/browser/chromeos/extensions/wallpaper_function_base.h [modify] https://crrev.com/cb2837fb977d7f2754e2c417d69cda5648b6a67f/chrome/browser/chromeos/extensions/wallpaper_private_api.cc [modify] https://crrev.com/cb2837fb977d7f2754e2c417d69cda5648b6a67f/chrome/browser/chromeos/extensions/wallpaper_private_api.h [modify] https://crrev.com/cb2837fb977d7f2754e2c417d69cda5648b6a67f/chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc
Fixed by commit cb2837fb977d7f2754e2c417d69cda5648b6a67f
Comment 1 by achuith@chromium.org
, Apr 9 2018Labels: OS-Chrome
Owner: x...@chromium.org