New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829640 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Detection - Implement ui to back detected flakes

Project Member Reported by wylieb@chromium.org, Apr 6 2018

Issue description

First step is minimal ui to backup bugs
Second step is to browse
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ca05c1b912121a90c0d44e5a7f2f2a921ff6683f

commit ca05c1b912121a90c0d44e5a7f2f2a921ff6683f
Author: Brandon Wylie <wylieb@chromium.org>
Date: Fri Apr 13 23:00:15 2018

[Findit] Flake Detection - Polymer components for detected flakes

Flaky tests and flake occurrences now have polymer models. These
models work by getting passed a json serialization of the ndb
model associated with them.

Notable changes here:
* Fixed up the expandable card so it centers the header div
  and left-aligns the text.
* Added (and tested) two polymer classes, one for flaky tests and
  the other for child occurrences.
* These polymer elements work by grabbing the json serialized version
  of the ndb classes, which seems like a great idea to me, but I
  could be completely wrong.

Bug:829640
Change-Id: I9359dc2a5b306b94dbb287b9d25748db46b8c05a
Reviewed-on: https://chromium-review.googlesource.com/999258
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[add] https://crrev.com/ca05c1b912121a90c0d44e5a7f2f2a921ff6683f/appengine/findit/ui/elements/detection/flaky-test-demo.html
[add] https://crrev.com/ca05c1b912121a90c0d44e5a7f2f2a921ff6683f/appengine/findit/ui/elements/detection/flaky-test.html
[add] https://crrev.com/ca05c1b912121a90c0d44e5a7f2f2a921ff6683f/appengine/findit/ui/elements/detection/flake-occurrence.html
[modify] https://crrev.com/ca05c1b912121a90c0d44e5a7f2f2a921ff6683f/appengine/findit/ui/elements/components/expandable-card.html
[add] https://crrev.com/ca05c1b912121a90c0d44e5a7f2f2a921ff6683f/appengine/findit/ui/elements/detection/flake-occurrence-demo.html

Comment 2 by wylieb@chromium.org, Apr 20 2018

Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment