For some reasons, the current value description is overridden but doesn't do anything. We should use aria-valuetext to have a human understandable description instead of reading the digits of pi.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f0f9ceb2c3f5acf36ef55d620d3f0e6ea7d8d01 commit 8f0f9ceb2c3f5acf36ef55d620d3f0e6ea7d8d01 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Fri Apr 06 15:00:03 2018 Media Controls: expose current time in timeline accessibility value description. Instead of the proper value that may have many digits and make no sense to a human. Bug: 829627 Change-Id: I467354edc416af46de0f1c625e6b890414f8ae6f Reviewed-on: https://chromium-review.googlesource.com/998915 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#548775} [add] https://crrev.com/8f0f9ceb2c3f5acf36ef55d620d3f0e6ea7d8d01/third_party/WebKit/LayoutTests/media/controls/accessibility-timeline.html [modify] https://crrev.com/8f0f9ceb2c3f5acf36ef55d620d3f0e6ea7d8d01/third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp [modify] https://crrev.com/8f0f9ceb2c3f5acf36ef55d620d3f0e6ea7d8d01/third_party/WebKit/Source/modules/accessibility/AXMediaControls.h [modify] https://crrev.com/8f0f9ceb2c3f5acf36ef55d620d3f0e6ea7d8d01/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [modify] https://crrev.com/8f0f9ceb2c3f5acf36ef55d620d3f0e6ea7d8d01/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h [modify] https://crrev.com/8f0f9ceb2c3f5acf36ef55d620d3f0e6ea7d8d01/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d27a19d5cf15726b08a8d3254f281fe2c05f767 commit 7d27a19d5cf15726b08a8d3254f281fe2c05f767 Author: Takumi Fujimoto <takumif@chromium.org> Date: Fri Apr 06 16:21:58 2018 Revert "Media Controls: expose current time in timeline accessibility value description." This reverts commit 8f0f9ceb2c3f5acf36ef55d620d3f0e6ea7d8d01. Reason for revert: Speculative revert I think this CL is making media/controls/accessibility-timeline.html fail on WebKit Mac10.10, etc: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/45448 Original change's description: > Media Controls: expose current time in timeline accessibility value description. > > Instead of the proper value that may have many digits and make no sense > to a human. > > Bug: 829627 > Change-Id: I467354edc416af46de0f1c625e6b890414f8ae6f > Reviewed-on: https://chromium-review.googlesource.com/998915 > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548775} TBR=mlamouri@chromium.org,steimel@chromium.org Change-Id: I14730aa64a3b51e7fa4698eeb003d386b02e4b34 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829627 Reviewed-on: https://chromium-review.googlesource.com/999105 Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#548799} [delete] https://crrev.com/cffaa6f6b1e36a3914ef181078f304f861793cce/third_party/WebKit/LayoutTests/media/controls/accessibility-timeline.html [modify] https://crrev.com/7d27a19d5cf15726b08a8d3254f281fe2c05f767/third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp [modify] https://crrev.com/7d27a19d5cf15726b08a8d3254f281fe2c05f767/third_party/WebKit/Source/modules/accessibility/AXMediaControls.h [modify] https://crrev.com/7d27a19d5cf15726b08a8d3254f281fe2c05f767/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [modify] https://crrev.com/7d27a19d5cf15726b08a8d3254f281fe2c05f767/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h [modify] https://crrev.com/7d27a19d5cf15726b08a8d3254f281fe2c05f767/third_party/WebKit/Source/modules/media_controls/elements/MediaControlTimelineElement.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7257d870da987c5fa89efba37453e81035d767e commit b7257d870da987c5fa89efba37453e81035d767e Author: Mounir Lamouri <mlamouri@chromium.org> Date: Tue Apr 10 10:50:27 2018 Media Controls: expose current time in timeline accessibility value description. Instead of the proper value that may have many digits and make no sense to a human. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/998915 It is fixing the test to make it more reliable and rebased the CL. Bug: 829627 Change-Id: Ic550051859367dcd92237d527285f00210098142 Reviewed-on: https://chromium-review.googlesource.com/1000864 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#549480} [add] https://crrev.com/b7257d870da987c5fa89efba37453e81035d767e/third_party/WebKit/LayoutTests/media/controls/accessibility-timeline.html [modify] https://crrev.com/b7257d870da987c5fa89efba37453e81035d767e/third_party/blink/renderer/modules/accessibility/ax_media_controls.cc [modify] https://crrev.com/b7257d870da987c5fa89efba37453e81035d767e/third_party/blink/renderer/modules/accessibility/ax_media_controls.h [modify] https://crrev.com/b7257d870da987c5fa89efba37453e81035d767e/third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_element.cc [modify] https://crrev.com/b7257d870da987c5fa89efba37453e81035d767e/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc [modify] https://crrev.com/b7257d870da987c5fa89efba37453e81035d767e/third_party/blink/renderer/modules/media_controls/media_controls_impl.h
Comment 1 by bugdroid1@chromium.org
, Apr 6 2018