New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829622 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 757605



Sign in to add a comment

Implement font remoting

Project Member Reported by enne@chromium.org, Apr 5 2018

Issue description

This is a placeholder bug to implement whatever is needed for font remoting / glyph rasterization for OOP-R.

This covers implementing, investigating pull vs push, investigating corner cases where cache warming fails, and measuring performance.

 
Forgot to add the bug id to the change. The skia and chromium side changes have landed: https://chromium-review.googlesource.com/c/chromium/src/+/1006181 and https://skia-review.googlesource.com/c/skia/+/125326.
Project Member

Comment 2 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d1ad1fd2c26e0707f9ae80b92595904e9fd0d6d

commit 9d1ad1fd2c26e0707f9ae80b92595904e9fd0d6d
Author: Khushal <khushalsagar@chromium.org>
Date: Thu May 03 07:19:13 2018

oop: Fix uninitialized memory use in OopPixelTest.

We were not initializing the position buffer for a text run.

TBR=enne@chromium.org

Bug:  829622 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie64d63b18431198d12abc70a091ce2e24ea0d4d0
Reviewed-on: https://chromium-review.googlesource.com/1041656
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555676}
[modify] https://crrev.com/9d1ad1fd2c26e0707f9ae80b92595904e9fd0d6d/cc/paint/oop_pixeltest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/b2e71274fe1f5a66c9c4befd2e86b6cf39c783b5

commit b2e71274fe1f5a66c9c4befd2e86b6cf39c783b5
Author: Khushal <khushalsagar@chromium.org>
Date: Tue May 15 22:58:23 2018

fonts: Fix memory accounting for deserialized glyphs.

When deserializing glyphs in the SkRemoteGlyphCache, we allocate from
the arena for the SkGlyphCache but don't account for it in the total
memory used by the cache. Fix that and avoid exposing the SkArenaAlloc
from SkGlyphCache, since that can result in such brittle use.

R=herb@google.com

Bug:  829622 
Change-Id: Iecff9ce6e0ed2c641957535363edec3e3fad178d
Reviewed-on: https://skia-review.googlesource.com/128112
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>

[modify] https://crrev.com/b2e71274fe1f5a66c9c4befd2e86b6cf39c783b5/src/core/SkStrikeCache.h
[modify] https://crrev.com/b2e71274fe1f5a66c9c4befd2e86b6cf39c783b5/src/core/SkGlyphCache.cpp
[modify] https://crrev.com/b2e71274fe1f5a66c9c4befd2e86b6cf39c783b5/src/core/SkGlyphCache.h
[modify] https://crrev.com/b2e71274fe1f5a66c9c4befd2e86b6cf39c783b5/tests/SkRemoteGlyphCacheTest.cpp
[modify] https://crrev.com/b2e71274fe1f5a66c9c4befd2e86b6cf39c783b5/src/core/SkRemoteGlyphCache.cpp
[modify] https://crrev.com/b2e71274fe1f5a66c9c4befd2e86b6cf39c783b5/src/core/SkStrikeCache.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c90af86063f80e46bf3104469c2999f21cc15551

commit c90af86063f80e46bf3104469c2999f21cc15551
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 16 02:50:45 2018

Roll src/third_party/skia/ 81f60ecd9..5b8b472b3 (27 commits)

https://skia.googlesource.com/skia.git/+log/81f60ecd9cc0..5b8b472b3373

$ git log 81f60ecd9..5b8b472b3 --date=short --no-merges --format='%ad %ae %s'
2018-05-15 liyuqian Revert "Check atlasPageCount before accessing the proxy array"
2018-05-15 khushalsagar fonts: Fix memory accounting for deserialized glyphs.
2018-05-15 jcgregorio [docker] Add Dockerfile that builds skiaserve.
2018-05-15 enne Driver bug workaround: max_msaa_sample_count_4
2018-05-15 enne Driver bug workaround: disallow_large_instanced_draw
2018-05-15 caryclark remove typedef Info
2018-05-15 csmartdalton Add a vknostencils config
2018-05-15 skcms-skia-autoroll Roll skia/third_party/skcms 14c31bf..ce2fabc (1 commits)
2018-05-15 csmartdalton Check atlasPageCount before accessing the proxy array
2018-05-15 fmalita Scrub SkPictureData/SkPictureRecord
2018-05-15 enne Driver bug workaround: max_texture_size_limit_4096
2018-05-15 mtklein remove unused SkColorSpace::Make
2018-05-15 benjaminwagner Run only canonical configs for 32-bit Test tasks.
2018-05-15 bungeman Remove non-smart SkFontConfigInterface::SetGlobal.
2018-05-15 borenet [recipes] BUILDTYPE and SKIA_OUT are no longer used
2018-05-15 rmistry Add chromium first to .gclient
2018-05-15 bungeman Revert "Remove non-smart SkFontConfigInterface::SetGlobal."
2018-05-15 bungeman Remove non-smart SkFontConfigInterface::SetGlobal.
2018-05-15 enne Reland "Driver bug workaround: disable_discard_framebuffer"
2018-05-14 enne Reland "Driver bug workaround: disable_blend_equation_advanced"
2018-05-15 angle-skia-autoroll Roll third_party/externals/angle2/ 74a763205..2a849bf31 (10 commits)
2018-05-15 kjlubick Add preflight checks for SkImage deserialization
2018-05-15 mtklein switch skia to use skcms.gni
2018-05-15 brianosman Roll third_party/externals/angle2/ 5d2ccc534..a00ef3144 (10 commits)
2018-05-15 bungeman Mark SkFontMgr_FCI methods as not implmented.
2018-05-15 skcms-skia-autoroll Roll skia/third_party/skcms 28e8b32..14c31bf (6 commits)
2018-05-14 bungeman SkSharedMutex::acquire to check thread state.

Created with:
  roll-dep src/third_party/skia
BUG= chromium:829622 ,chromium: 829614,chromium: 829614,chromium: 829614,chromium: 829614,chromium: 829614


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: I5a7325acbeb0907d22e4ad901f2804db4d202cb1
Reviewed-on: https://chromium-review.googlesource.com/1060592
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558939}
[modify] https://crrev.com/c90af86063f80e46bf3104469c2999f21cc15551/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67c8c7456c0c691da8802a0361486ac5e2187fbc

commit 67c8c7456c0c691da8802a0361486ac5e2187fbc
Author: Khushal <khushalsagar@chromium.org>
Date: Wed May 16 18:05:05 2018

cc: Fix a bunch of scaling issues with oop raster.

1) Image shaders are currently first decoded at the raster scale, but
then serialized at the original size. This is because all the decoding
happens in ScopedRasterFlags, but eventually the serialization needs to
happen in PaintOpWriter. For record shaders, we would overwrite the
shader with the correct scale, that would eventually be used in raster.

Clean up all of this to not use ScopedRasterFlags for any image
decoding during serialization. The logic for getting the scales is
pulled into common methods on PaintShader used by ScopedRasterFlags
for in process raster, and PaintOpWriter for oop serialization. This
also fixes #3.

2) When decoding an image using the ImageProvider, a component of the
scale is already applied to the decoded image. This needs to be
accounted for during raster, which is missed for oop-r. Fix this by
adding this scale to DrawImage/DrawImageRect ops. Image shaders
already take care of this on their local matrix.

3) Decoding of PaintRecord backed shaders also fixes the raster scale
for them. But since this was being done in ScopedRasterFlags, we would
only do them for cases where these records have images. In order to get
the font analysis correct for oop-r, this needs to be done for records
with text also. This change ensures that we always serialize scaled
records for these shaders, ensuring that we use the same scale during
font analysis and raster.

R=enne@chromium.org

Bug:  829622 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If567d192220450306b15b94993c86e610c7885cb
Reviewed-on: https://chromium-review.googlesource.com/1053528
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559182}
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/paint_filter.cc
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/paint_op_buffer_serializer.cc
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/paint_op_reader.cc
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/paint_op_writer.cc
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/paint_op_writer.h
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/paint_shader.cc
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/paint_shader.h
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/scoped_raster_flags.cc
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/scoped_raster_flags.h
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/scoped_raster_flags_unittest.cc
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/skia_paint_canvas.cc
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/paint/skia_paint_canvas.h
[modify] https://crrev.com/67c8c7456c0c691da8802a0361486ac5e2187fbc/cc/test/test_options_provider.cc

Project Member

Comment 6 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22204a4f102169cf7654ec72450865acdb5b9133

commit 22204a4f102169cf7654ec72450865acdb5b9133
Author: Khushal <khushalsagar@chromium.org>
Date: Thu May 17 23:06:21 2018

gpu: Fix font cache unlocking for oop raster.

We currently unlock the glyph caches in DoRasterCHROMIUM, but this needs
to be deferred until DoEndRasterCHROMIUM. This is because skia
internally batches Gr operations for rendering which lazily access the
glyph cache.

R=piman@chromium.org

Bug:  829622 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I06fdfc897e14f71197fecfebb6ac59252e15df18
Reviewed-on: https://chromium-review.googlesource.com/1065024
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559722}
[modify] https://crrev.com/22204a4f102169cf7654ec72450865acdb5b9133/gpu/command_buffer/service/raster_decoder.cc

Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, May 18 2018

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/13aef824240000

All of the attempts failed. See the individual attempts for details on each error.
Project Member

Comment 9 by bugdroid1@chromium.org, May 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec01f347957e672187f1a90cd77dbee8a24206ba

commit ec01f347957e672187f1a90cd77dbee8a24206ba
Author: Khushal <khushalsagar@chromium.org>
Date: Sat May 19 00:36:26 2018

cc: Handle PaintRecord backed filters for font analysis.

If a PaintRecord backed PaintFilter is used in a PaintOpBuffer, we need
to make sure that font analysis uses the correct raster scale when
pushing glyphs to the gpu.

R=enne@chromium.org

Bug:  829622 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I92d10e6b0b659c24556567b49a5cf4f63fc96183
Reviewed-on: https://chromium-review.googlesource.com/1066813
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560121}
[modify] https://crrev.com/ec01f347957e672187f1a90cd77dbee8a24206ba/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/ec01f347957e672187f1a90cd77dbee8a24206ba/cc/paint/paint_op_buffer_serializer.cc
[modify] https://crrev.com/ec01f347957e672187f1a90cd77dbee8a24206ba/cc/paint/paint_op_buffer_serializer.h
[modify] https://crrev.com/ec01f347957e672187f1a90cd77dbee8a24206ba/cc/paint/paint_op_writer.cc
[modify] https://crrev.com/ec01f347957e672187f1a90cd77dbee8a24206ba/cc/paint/paint_op_writer.h

Project Member

Comment 10 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/2b8a0d1844ed236259284fbc2efe08dab0ed539f

commit 2b8a0d1844ed236259284fbc2efe08dab0ed539f
Author: Khushal <khushalsagar@chromium.org>
Date: Tue May 22 22:01:35 2018

fonts: Cleanup cache miss logging for font remoting.

Add hooks to notify the embedder if there is a cache miss during draw.
Also remove the reference to SkStrikeClient from SkTypefaceProxy and
SkScalerContextProxy, since the proxies can outlive the client.

R=herb@google.com

Bug:  829622 
Change-Id: Ib2fd1b91ebd057856c1d4e717cf50b49f08c903b
Reviewed-on: https://skia-review.googlesource.com/129402
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>

[modify] https://crrev.com/2b8a0d1844ed236259284fbc2efe08dab0ed539f/src/core/SkRemoteGlyphCache.h
[modify] https://crrev.com/2b8a0d1844ed236259284fbc2efe08dab0ed539f/src/core/SkRemoteGlyphCache.cpp
[modify] https://crrev.com/2b8a0d1844ed236259284fbc2efe08dab0ed539f/src/core/SkTypeface_remote.cpp
[modify] https://crrev.com/2b8a0d1844ed236259284fbc2efe08dab0ed539f/src/core/SkTypeface_remote.h
[modify] https://crrev.com/2b8a0d1844ed236259284fbc2efe08dab0ed539f/tests/SkRemoteGlyphCacheTest.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/fc6cf92e4b21c92ead769fae557534056eac6d83

commit fc6cf92e4b21c92ead769fae557534056eac6d83
Author: Mike Klein <mtklein@google.com>
Date: Wed May 23 00:16:56 2018

Revert "fonts: Cleanup cache miss logging for font remoting."

This reverts commit 2b8a0d1844ed236259284fbc2efe08dab0ed539f.

Reason for revert: reverting a CL this builds on

Original change's description:
> fonts: Cleanup cache miss logging for font remoting.
> 
> Add hooks to notify the embedder if there is a cache miss during draw.
> Also remove the reference to SkStrikeClient from SkTypefaceProxy and
> SkScalerContextProxy, since the proxies can outlive the client.
> 
> R=​herb@google.com
> 
> Bug:  829622 
> Change-Id: Ib2fd1b91ebd057856c1d4e717cf50b49f08c903b
> Reviewed-on: https://skia-review.googlesource.com/129402
> Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
> Reviewed-by: Herb Derby <herb@google.com>

TBR=herb@google.com,khushalsagar@chromium.org

Change-Id: I8a331545988885c620685008f4b60240d80f3712
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  829622 
Reviewed-on: https://skia-review.googlesource.com/129682
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>

[modify] https://crrev.com/fc6cf92e4b21c92ead769fae557534056eac6d83/src/core/SkRemoteGlyphCache.h
[modify] https://crrev.com/fc6cf92e4b21c92ead769fae557534056eac6d83/src/core/SkRemoteGlyphCache.cpp
[modify] https://crrev.com/fc6cf92e4b21c92ead769fae557534056eac6d83/src/core/SkTypeface_remote.cpp
[modify] https://crrev.com/fc6cf92e4b21c92ead769fae557534056eac6d83/src/core/SkTypeface_remote.h
[modify] https://crrev.com/fc6cf92e4b21c92ead769fae557534056eac6d83/tests/SkRemoteGlyphCacheTest.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b845d098abd36338ff9dd7874e9de4726927b57c

commit b845d098abd36338ff9dd7874e9de4726927b57c
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 23 06:45:58 2018

Roll src/third_party/skia/ 91dfa3b57..7257e22e4 (11 commits)

https://skia.googlesource.com/skia.git/+log/91dfa3b571f1..7257e22e43a5

$ git log 91dfa3b57..7257e22e4 --date=short --no-merges --format='%ad %ae %s'
2018-05-23 mtklein Revert "fonts: Add support for distance field text to font remoting."
2018-05-23 mtklein Revert "fonts: Cleanup cache miss logging for font remoting."
2018-05-23 mtklein Revert "start cleaning up non-skcms SkColorSpaceXforms"
2018-05-22 angle-skia-autoroll Roll third_party/externals/angle2/ 534b00dbd..64ac5d9eb (2 commits)
2018-05-22 khushalsagar fonts: Cleanup cache miss logging for font remoting.
2018-05-22 bungeman IWYU for tools/fiddle/egl_context.cpp
2018-05-22 brianosman Clip to perspective quad in viewer
2018-05-22 egdaniel MoltenVk fix for fuchsia again.
2018-05-22 bungeman Remove include/gpu/vk from include paths.
2018-05-22 khushalsagar fonts: Add support for distance field text to font remoting.
2018-05-22 csmartdalton ccpr: Remove local matrix data from path instances

Created with:
  roll-dep src/third_party/skia
BUG= chromium:829622 , chromium:829622 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: I6c530de43df351c926623d3543b37ddca1e3a26f
Reviewed-on: https://chromium-review.googlesource.com/1069938
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560972}
[modify] https://crrev.com/b845d098abd36338ff9dd7874e9de4726927b57c/DEPS

Project Member

Comment 13 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/315f2fd68d9b44ad050a581993e36dbd2f49ee33

commit 315f2fd68d9b44ad050a581993e36dbd2f49ee33
Author: Khushal <khushalsagar@chromium.org>
Date: Tue May 29 03:20:39 2018

cc/gpu: Plumb bits required for font analysis from gpu.

This depends on the skia change:
https://skia-review.googlesource.com/c/skia/+/128970

R=enne@chromium.org, piman@chromium.org

Bug:  829622 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia00ee76b3be34b5cc28c7123328424ff4afc3dc2
Reviewed-on: https://chromium-review.googlesource.com/1067730
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562317}
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/cc/paint/image_transfer_cache_entry.cc
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/cc/paint/paint_op_buffer_fuzzer.cc
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/cc/paint/paint_op_buffer_serializer.cc
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/cc/paint/paint_op_buffer_serializer.h
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/cc/paint/paint_op_perftest.cc
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/cc/paint/paint_op_writer.cc
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/cc/test/test_options_provider.cc
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/cc/test/test_options_provider.h
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/components/viz/test/test_context_provider.cc
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/components/viz/test/test_context_provider.h
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/gpu/command_buffer/client/raster_implementation.cc
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/gpu/command_buffer/common/capabilities.h
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/gpu/ipc/common/gpu_command_buffer_traits_multi.h
[modify] https://crrev.com/315f2fd68d9b44ad050a581993e36dbd2f49ee33/services/viz/public/cpp/compositing/paint_filter_struct_traits.cc

Project Member

Comment 14 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b

commit 08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b
Author: Khushal <khushalsagar@chromium.org>
Date: Tue May 29 03:23:56 2018

ui/gpu: Initialize lcd config in the gpu process.

With skia running in the gpu process with oop raster, SkFontLCDConfig
needs to be initialized here in addition to the renderer process.

R=derat@chromium.org, piman@chromium.org

Bug:  829622 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I1ac12febd66b05a888f3795033be1f83a229a983
Reviewed-on: https://chromium-review.googlesource.com/1069725
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562324}
[modify] https://crrev.com/08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b/components/viz/service/main/viz_main_impl.cc
[modify] https://crrev.com/08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b/components/viz/service/main/viz_main_impl.h
[modify] https://crrev.com/08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b/content/browser/browser_main_loop.cc
[modify] https://crrev.com/08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b/services/ui/ws/gpu_host.cc
[modify] https://crrev.com/08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b/services/viz/privileged/interfaces/BUILD.gn
[modify] https://crrev.com/08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b/services/viz/privileged/interfaces/viz_main.mojom
[modify] https://crrev.com/08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b/ui/gfx/font_render_params_win.cc
[modify] https://crrev.com/08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b/ui/gfx/mojo/BUILD.gn
[add] https://crrev.com/08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b/ui/gfx/mojo/font_render_params.mojom
[add] https://crrev.com/08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b/ui/gfx/mojo/font_render_params.typemap
[add] https://crrev.com/08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b/ui/gfx/mojo/font_render_params_struct_traits.h
[modify] https://crrev.com/08d7c3dfdd5d70a8a41cfd5a5f7cec7ff846bc1b/ui/gfx/typemaps.gni

Project Member

Comment 15 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/4f078f7cfac6580dce6e213c022708922739ac6d

commit 4f078f7cfac6580dce6e213c022708922739ac6d
Author: Khushal <khushalsagar@chromium.org>
Date: Tue May 29 20:36:37 2018

fonts: Use correct SurfaceProps in analysis canvas for remoting.

SaveLayer may not preserve the behaviour for lcd text, in which case
the surfaceProps used for desc generation are inconsistent.

R=herb@google.com

Bug:  829622 
Change-Id: I3adfc6780f26e4eb333a8aff76eaa4b5a9f0a0a7
Reviewed-on: https://skia-review.googlesource.com/129557
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>

[modify] https://crrev.com/4f078f7cfac6580dce6e213c022708922739ac6d/src/core/SkRemoteGlyphCache.h
[modify] https://crrev.com/4f078f7cfac6580dce6e213c022708922739ac6d/src/core/SkRemoteGlyphCache.cpp
[modify] https://crrev.com/4f078f7cfac6580dce6e213c022708922739ac6d/tests/SkRemoteGlyphCacheTest.cpp

Project Member

Comment 16 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/cd21d676b782cf27a9ded17a69c0393e4d3e34cc

commit cd21d676b782cf27a9ded17a69c0393e4d3e34cc
Author: Ravi Mistry <rmistry@google.com>
Date: Tue May 29 21:45:58 2018

Revert "fonts: Use correct SurfaceProps in analysis canvas for remoting."

This reverts commit 4f078f7cfac6580dce6e213c022708922739ac6d.

Reason for revert: Seems to have caused these breakages:
* https://chromium-swarm.appspot.com/task?id=3dc6788dc7b77010&refresh=10
* https://chromium-swarm.appspot.com/task?id=3dc67452db797c10&refresh=10

Original change's description:
> fonts: Use correct SurfaceProps in analysis canvas for remoting.
> 
> SaveLayer may not preserve the behaviour for lcd text, in which case
> the surfaceProps used for desc generation are inconsistent.
> 
> R=​herb@google.com
> 
> Bug:  829622 
> Change-Id: I3adfc6780f26e4eb333a8aff76eaa4b5a9f0a0a7
> Reviewed-on: https://skia-review.googlesource.com/129557
> Reviewed-by: Herb Derby <herb@google.com>
> Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>

TBR=herb@google.com,khushalsagar@chromium.org

Change-Id: I0372a3d834f8c4c929feb71c2b6b13739443eaaa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  829622 
Reviewed-on: https://skia-review.googlesource.com/130680
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>

[modify] https://crrev.com/cd21d676b782cf27a9ded17a69c0393e4d3e34cc/src/core/SkRemoteGlyphCache.h
[modify] https://crrev.com/cd21d676b782cf27a9ded17a69c0393e4d3e34cc/src/core/SkRemoteGlyphCache.cpp
[modify] https://crrev.com/cd21d676b782cf27a9ded17a69c0393e4d3e34cc/tests/SkRemoteGlyphCacheTest.cpp

Project Member

Comment 17 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea18a841705eb5bfd5ceda2d84b1e118a29c860c

commit ea18a841705eb5bfd5ceda2d84b1e118a29c860c
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 30 00:08:10 2018

Roll src/third_party/skia 8363be1..61f36d3 (8 commits)

https://skia.googlesource.com/skia.git/+log/8363be1..61f36d3


git log 8363be1..61f36d3 --date=short --no-merges --format='%ad %ae %s'
2018-05-29 brucewang@google.com Check file name valid or not.
2018-05-29 rmistry@google.com Revert "fonts: Use correct SurfaceProps in analysis canvas for remoting."
2018-05-29 brianosman@google.com Enable skcms on skqp
2018-05-29 bungeman@google.com Update multi_repo_trybots documentation.
2018-05-29 brianosman@google.com Implement onDrawDrawable in SkDebugCanvas
2018-05-29 brianosman@google.com SkDrawCommand cleanup, continued
2018-05-29 reed@google.com support image-subsets in serialization
2018-05-29 khushalsagar@chromium.org fonts: Use correct SurfaceProps in analysis canvas for remoting.

Created with:
  gclient setdep -r src/third_party/skia@61f36d3

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:829622 , chromium:829622 

TBR=rmistry@chromium.org

Change-Id: I449cf04f34133827b8d0cca3cf3c64d52be8b677
Reviewed-on: https://chromium-review.googlesource.com/1077500
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#562663}
[modify] https://crrev.com/ea18a841705eb5bfd5ceda2d84b1e118a29c860c/DEPS

Project Member

Comment 18 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db6ea3c03b2bd02447752a6617d4535132d291d0

commit db6ea3c03b2bd02447752a6617d4535132d291d0
Author: Khushal <khushalsagar@chromium.org>
Date: Thu May 31 00:53:09 2018

gpu: Fix oop raster font cache memory leak.

The code for tracking locked font handles on the service currently
assumes that only one DoRasterCHROMIUM command is interleaved between a
Begin/EndRaster sequence, which is an incorrect assumption. As a result
since we clear the vector of locked handles in each DoRasterCHROMIUM,
this leaks ref-counts if multiple DoRasterCHROMIUM commands are present
between a single Begin/EndRaster sequence.

Fix this by appending ref-counts on the service instead of over-writing
the current list.

R=piman@chromium.org

Bug:  829622 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I15025153fe887e712e0879cbeb32944c3e258e92
Reviewed-on: https://chromium-review.googlesource.com/1077819
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563092}
[modify] https://crrev.com/db6ea3c03b2bd02447752a6617d4535132d291d0/cc/paint/oop_pixeltest.cc
[modify] https://crrev.com/db6ea3c03b2bd02447752a6617d4535132d291d0/cc/test/test_in_process_context_provider.cc
[modify] https://crrev.com/db6ea3c03b2bd02447752a6617d4535132d291d0/cc/test/test_in_process_context_provider.h
[modify] https://crrev.com/db6ea3c03b2bd02447752a6617d4535132d291d0/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/db6ea3c03b2bd02447752a6617d4535132d291d0/gpu/command_buffer/service/service_font_manager.cc
[modify] https://crrev.com/db6ea3c03b2bd02447752a6617d4535132d291d0/gpu/command_buffer/service/service_font_manager.h
[modify] https://crrev.com/db6ea3c03b2bd02447752a6617d4535132d291d0/gpu/ipc/in_process_command_buffer.h
[modify] https://crrev.com/db6ea3c03b2bd02447752a6617d4535132d291d0/gpu/ipc/raster_in_process_context.cc
[modify] https://crrev.com/db6ea3c03b2bd02447752a6617d4535132d291d0/gpu/ipc/raster_in_process_context.h

Project Member

Comment 19 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/489e2bdae83e849d12695044dc61837c06d3f76d

commit 489e2bdae83e849d12695044dc61837c06d3f76d
Author: Khushal <khushalsagar@chromium.org>
Date: Thu May 31 16:18:23 2018

fonts: Fix image cache miss from glyphs too large for atlas.

R=herb@google.com

Bug:  829622 
Change-Id: I17994663318c8db3537e99ef11aaee7beb2da23f
Reviewed-on: https://skia-review.googlesource.com/131056
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>

[modify] https://crrev.com/489e2bdae83e849d12695044dc61837c06d3f76d/src/core/SkRemoteGlyphCache.cpp

Project Member

Comment 20 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/458f40a43e12260a3b73ee170b30d966d6c1fe56

commit 458f40a43e12260a3b73ee170b30d966d6c1fe56
Author: Khushal <khushalsagar@chromium.org>
Date: Thu May 31 20:12:44 2018

font remoting: Fix errors with sub-pixel positioning mismatch.

1) Use correct offset from SkTextBlobRunIterator. Only
kHorizontal_Positioning needs to use the y offset specified on the run.

2) Use the same mapping function from SkFindAndPlaceGlyph for mapping
the glyph position from transform for the run. This avoids minor
rounding differences between analysis and draw.

R=bungeman@google.com,herb@google.com

Bug:829622
Change-Id: Iaef74a8d01f0850ce042149458b2ea795c2a2b61
Reviewed-on: https://skia-review.googlesource.com/131169
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>

[modify] https://crrev.com/458f40a43e12260a3b73ee170b30d966d6c1fe56/src/core/SkRemoteGlyphCache.cpp
[modify] https://crrev.com/458f40a43e12260a3b73ee170b30d966d6c1fe56/src/core/SkFindAndPlaceGlyph.h

Project Member

Comment 21 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46e1f84bd6c158226bc338de75a96cd9babc830f

commit 46e1f84bd6c158226bc338de75a96cd9babc830f
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu May 31 21:45:12 2018

Roll src/third_party/skia e45752e..ec07324 (14 commits)

https://skia.googlesource.com/skia.git/+log/e45752e..ec07324


git log e45752e..ec07324 --date=short --no-merges --format='%ad %ae %s'
2018-05-31 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader e92a88e..f459b04 (1 commits)
2018-05-31 brianosman@google.com Require the GPU backend to build our internal tools
2018-05-31 brianosman@google.com Enable GPU support in MSAN builds
2018-05-31 robertphillips@google.com Add DDL skpbench bot for just DDL recording time
2018-05-31 robertphillips@google.com Allow CCPR in DDL mode (take 2)
2018-05-31 mtklein@chromium.org remove map() from SkRasterPipeline_opts.h
2018-05-31 halcanary@google.com skqp: update apk list script
2018-05-31 fmalita@chromium.org [skottie] Make the resource provider factory argument optional
2018-05-31 robertphillips@google.com Add a DDL Skpbench bot
2018-05-31 khushalsagar@chromium.org fonts: Fix image cache miss from glyphs too large for atlas.
2018-05-31 robertphillips@google.com Fix fuzzer bugs
2018-05-31 mtklein@chromium.org binary literals!
2018-05-31 bungeman@google.com Roll FreeType to pick up color stuff.
2018-05-31 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 86ce210..05cd6df (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@ec07324

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:829622 
TBR=rmistry@chromium.org

Change-Id: I7409d10d1959533715941a3d8aaaa0aee07830c1
Reviewed-on: https://chromium-review.googlesource.com/1081118
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Ravi Mistry <rmistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563384}
[modify] https://crrev.com/46e1f84bd6c158226bc338de75a96cd9babc830f/DEPS

Project Member

Comment 22 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/e70c5fb602047dc6ece0183ad49684c4d403ee0d

commit e70c5fb602047dc6ece0183ad49684c4d403ee0d
Author: Khushal <khushalsagar@chromium.org>
Date: Thu May 31 22:43:44 2018

Reland fonts: Use correct SurfaceProps in analysis canvas for remoting.

This reverts commit cd21d676b782cf27a9ded17a69c0393e4d3e34cc.

TBR=herb@google.com
Bug:  829622 
Change-Id: I515fdf67fde118db774ab170e021100eef13ce68
Reviewed-on: https://skia-review.googlesource.com/130701
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Reviewed-by: Khusal Sagar <khushalsagar@chromium.org>

[modify] https://crrev.com/e70c5fb602047dc6ece0183ad49684c4d403ee0d/src/core/SkRemoteGlyphCache.h
[modify] https://crrev.com/e70c5fb602047dc6ece0183ad49684c4d403ee0d/src/core/SkRemoteGlyphCache.cpp

Project Member

Comment 23 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c2117cd99e97d4240ea5b2428dea3df0fd219ee

commit 5c2117cd99e97d4240ea5b2428dea3df0fd219ee
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jun 01 04:22:20 2018

Roll src/third_party/skia ec07324..db33ee1 (13 commits)

https://skia.googlesource.com/skia.git/+log/ec07324..db33ee1


git log ec07324..db33ee1 --date=short --no-merges --format='%ad %ae %s'
2018-06-01 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 05cd6df..46bcea5 (6 commits)
2018-05-31 khushalsagar@chromium.org Reland fonts: Use correct SurfaceProps in analysis canvas for remoting.
2018-05-31 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader f459b04..8e6ed2e (1 commits)
2018-05-31 caryclark@skia.org don't walk off end of pointer
2018-05-31 halcanary@google.com SkFloatToDecimal: optimize the less common cases.
2018-05-31 khushalsagar@chromium.org font remoting: Fix errors with sub-pixel positioning mismatch.
2018-05-31 bungeman@google.com Make CMakeLists.txt less relative.
2018-05-31 mtklein@chromium.org add std::sort() to SortBench
2018-05-31 bsalomon@google.com Stop using legacy pixel ops on windows builds
2018-05-31 reed@google.com draw skottie in 3d
2018-05-31 brianosman@google.com Remove SK_SUPPORT_GPU checks in tool-only code
2018-05-31 djsollen@google.com Expose API for temporary use by the Android WebView.
2018-05-31 egdaniel@google.com Reland "Use GrVkMemoryAllocator for vulkan memory allocations in ganesh."


Created with:
  gclient setdep -r src/third_party/skia@db33ee1

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:829622 ,chromium:836282, chromium:829622 
TBR=rmistry@chromium.org

Change-Id: I636bce3fe9a5e3426dbac54cd171264c4e5783b5
Reviewed-on: https://chromium-review.googlesource.com/1081945
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#563532}
[modify] https://crrev.com/5c2117cd99e97d4240ea5b2428dea3df0fd219ee/DEPS

Project Member

Comment 24 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/a05a31aef4a0dc1af797aa454a2864a36260956b

commit a05a31aef4a0dc1af797aa454a2864a36260956b
Author: Khushal <khushalsagar@chromium.org>
Date: Fri Jun 08 20:34:23 2018

fonts: Perform blob analysis at SkBaseDevice layer instead of canvas.

Currently we use the onDrawTextBlob hook to analyze the text blob,
which requires replicating the logic for applying the SkDrawLooper and
misses the optimization for skipping ops outside the current clip.

Avoid this by using SkBaseDevice::drawTextBlob instead to ensure we
re-use all the SkCanvas code until the device level.

R=herb@google.com

Bug:  829622 
Change-Id: I2721c02541d337e2fb3744132e85758f7c804841
Reviewed-on: https://skia-review.googlesource.com/133101
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Reviewed-by: Herb Derby <herb@google.com>

[modify] https://crrev.com/a05a31aef4a0dc1af797aa454a2864a36260956b/src/core/SkRemoteGlyphCache.h
[modify] https://crrev.com/a05a31aef4a0dc1af797aa454a2864a36260956b/src/core/SkRemoteGlyphCache.cpp

Project Member

Comment 25 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a415686313d6b2ad3ecac5bf1adc6e2cc914fb40

commit a415686313d6b2ad3ecac5bf1adc6e2cc914fb40
Author: Khushal <khushalsagar@chromium.org>
Date: Fri Jun 08 22:46:02 2018

gpu: Fix off by 1 error in paint op deserialization.

PaintOps with no extra data are of size 4 bytes. The current loop for
processing deserialized ops will miss the last op in the buffer if it
is a simple op.

R=ericrk@chromium.org

Bug:  829622 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ifa58d2211bc46d10bd51175bbd9dd9c010f34e48
Reviewed-on: https://chromium-review.googlesource.com/1093211
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565763}
[modify] https://crrev.com/a415686313d6b2ad3ecac5bf1adc6e2cc914fb40/gpu/command_buffer/service/raster_decoder.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Jun 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f975070e3f09231441706cbdce0b4e5c110b5b4b

commit f975070e3f09231441706cbdce0b4e5c110b5b4b
Author: Khushal <khushalsagar@chromium.org>
Date: Sat Jun 09 00:42:13 2018

cc/gpu: Plumb more bits required for font analysis in OOP raster.

Initialize the max texture size and max texture bytes for the glyph
cache from GPU to renderer process. This is required to send the correct
glyphs to the GPU in certain fallback cases.

R=piman@chromium.org, tsepez@chromium.org

Bug:  829622 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I77b4d843e76d1ded51a22d38d5cb168a14770757
Reviewed-on: https://chromium-review.googlesource.com/1088237
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565796}
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/cc/paint/image_transfer_cache_entry.cc
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/cc/paint/paint_op_buffer.cc
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/cc/paint/paint_op_buffer.h
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/cc/paint/paint_op_buffer_serializer.cc
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/cc/paint/paint_op_buffer_serializer.h
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/cc/paint/paint_op_buffer_unittest.cc
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/cc/paint/paint_op_perftest.cc
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/cc/paint/paint_op_writer.cc
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/cc/test/test_options_provider.cc
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/cc/test/test_options_provider.h
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/gpu/command_buffer/client/raster_implementation.cc
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/gpu/command_buffer/client/raster_implementation.h
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/gpu/command_buffer/common/capabilities.h
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/gpu/ipc/common/gpu_command_buffer_traits_multi.h
[modify] https://crrev.com/f975070e3f09231441706cbdce0b4e5c110b5b4b/services/viz/public/cpp/compositing/paint_filter_struct_traits.cc

Project Member

Comment 27 by bugdroid1@chromium.org, Jun 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef8fdfca306d8a99f5e1e194b5e1f7fa6a59c08f

commit ef8fdfca306d8a99f5e1e194b5e1f7fa6a59c08f
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Jun 09 17:18:41 2018

Roll src/third_party/skia 7a45dd1..5ebb90d (40 commits)

https://skia.googlesource.com/skia.git/+log/7a45dd1..5ebb90d


git log 7a45dd1..5ebb90d --date=short --no-merges --format='%ad %ae %s'
2018-06-09 senorblanco@chromium.org Revert "remove half float workaround in GrGLGpu::onReadPixels"
2018-06-09 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-08 mtklein@chromium.org remove unused parts of SkTypes.h
2018-06-08 egdaniel@google.com Fall back to bilerp if we are undable to do a copy for mips.
2018-06-08 egdaniel@google.com Reland "Reland "Require mips to be allocated at texture creation time and disable late allocations.""
2018-06-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 c3907ef..f15f886 (6 commits)
2018-06-08 bsalomon@google.com Stop passing GrPrimitiveProcessor to GrMesh::sendToGpu.
2018-06-08 herb@google.com Glyph search of desperation
2018-06-08 egdaniel@google.com Revert "Reland "Require mips to be allocated at texture creation time and disable late allocations.""
2018-06-08 borenet@google.com [recipes] Make ct_skps use binaries from a build task
2018-06-08 brianosman@google.com Avoid degenerate matrices (that trigger asserts) in test code
2018-06-08 mtklein@chromium.org see if we can remove this hack
2018-06-08 caryclark@skia.org rebase
2018-06-08 khushalsagar@chromium.org fonts: Perform blob analysis at SkBaseDevice layer instead of canvas.
2018-06-08 mtklein@chromium.org remove unimportant bench
2018-06-08 csmartdalton@google.com Make the SkPathRef GenIDChangeListener ref counted
2018-06-08 bsalomon@google.com Remove include of GrGLProgramBuilder.h from GrGLProgram.h and GrVkPipelineState.h
2018-06-08 csmartdalton@google.com Add a front() accessor to GrAllocator
2018-06-08 herb@google.com New more efficient run builder
2018-06-08 brucewang@google.com Add SkTypeface::makeClone.
2018-06-08 bsalomon@google.com remove half float workaround in GrGLGpu::onReadPixels
2018-06-08 brianosman@google.com Fix A2B JPEG images on GPU backed xform or color-managed canvas
2018-06-08 bungeman@google.com Add text size override to Viewer.
2018-06-08 csmartdalton@google.com Implement Sk2f::floor
2018-06-08 mtklein@chromium.org remove linear blending from SkWebpCodec
2018-06-08 senorblanco@chromium.org GrTessellator: catch missing intersections.
2018-06-08 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-08 fmalita@chromium.org SkJson
2018-06-08 enne@chromium.org Fix SkImageInfo::computeByteSize underflow
2018-06-08 egdaniel@google.com Reland "Require mips to be allocated at texture creation time and disable late allocations."
2018-06-08 bsalomon@google.com Revert "Reland "Workaround constexpr bug in MSVC 2015 in GrTextureOp""
2018-06-08 caryclark@skia.org update SkColor
2018-06-08 caryclark@skia.org fix define comments
2018-06-08 mtklein@chromium.org remove final SkTypes dependencies in SkArenaAlloc
2018-06-08 benjaminwagner@google.com Remove Win2k8 GPU jobs.
2018-06-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 81970bc..c3907ef (2 commits)
2018-06-08 timliang@google.com fixed vec3 size differences and mod calculation of skslc msl backend
2018-06-08 brianosman@google.com srgb config is gone. Stop testing it.
2018-06-08 borenet@google.com Update gen_tasks.go to use unforked glog
2018-06-08 robertphillips@google.com Add a factory to any GrOp-derived class that lacked one


Created with:
  gclient setdep -r src/third_party/skia@5ebb90d

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:830651 , chromium:829622 , chromium:843135 ,chromium: 819616
TBR=halcanary@chromium.org

Change-Id: If58892b6b6b2061e1b52168911b4fb49a1b990e7
Reviewed-on: https://chromium-review.googlesource.com/1094454
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565887}
[modify] https://crrev.com/ef8fdfca306d8a99f5e1e194b5e1f7fa6a59c08f/DEPS

Project Member

Comment 28 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/8523b6bd0d22083266d990191764a0460885fd6e

commit 8523b6bd0d22083266d990191764a0460885fd6e
Author: Khushal <khushalsagar@chromium.org>
Date: Tue Jun 12 20:42:34 2018

fonts: Fix memory allocation for fallback glyphs.

When allocating the mask for a fallback glyph, we allocate it on the
arena on the SkScalerContext while the image belongs to a glyph on a
different cache. This can lead to use-after-free bugs if accessing the
image after the context owning that memory is destroyed. Fix this by
allocating on the arena from the owning cache.

R=herb@google.com, mtklein@google.com

Bug:  829622 
Change-Id: Ife53e24f5bc868f36c43f2adcd7a2629ab5577fe
Reviewed-on: https://skia-review.googlesource.com/134182
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>

[modify] https://crrev.com/8523b6bd0d22083266d990191764a0460885fd6e/src/core/SkStrikeCache.h
[modify] https://crrev.com/8523b6bd0d22083266d990191764a0460885fd6e/src/core/SkRemoteGlyphCache.h
[modify] https://crrev.com/8523b6bd0d22083266d990191764a0460885fd6e/src/core/SkGlyphCache.cpp
[modify] https://crrev.com/8523b6bd0d22083266d990191764a0460885fd6e/src/core/SkGlyphCache.h
[modify] https://crrev.com/8523b6bd0d22083266d990191764a0460885fd6e/tests/SkRemoteGlyphCacheTest.cpp
[modify] https://crrev.com/8523b6bd0d22083266d990191764a0460885fd6e/src/core/SkRemoteGlyphCache.cpp
[modify] https://crrev.com/8523b6bd0d22083266d990191764a0460885fd6e/src/core/SkTypeface_remote.cpp
[modify] https://crrev.com/8523b6bd0d22083266d990191764a0460885fd6e/src/core/SkGlyph.h
[modify] https://crrev.com/8523b6bd0d22083266d990191764a0460885fd6e/src/core/SkStrikeCache.cpp
[modify] https://crrev.com/8523b6bd0d22083266d990191764a0460885fd6e/src/core/SkTypeface_remote.h

Project Member

Comment 29 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/4010c792c6bd0378087225ae16b0131bd2c303f2

commit 4010c792c6bd0378087225ae16b0131bd2c303f2
Author: Khushal <khushalsagar@chromium.org>
Date: Wed Jun 13 17:10:56 2018

fonts: Ignore re-initialization of fallback glyphs from the server.

If the client finds that the server re-initializes a cached path/image,
we consider this an error and invalid data. But since we might
initialize a glyph using a fallback on the client, and receive the
correct version from the server later, this is not longer true.

Bug:  829622 
Change-Id: I34ab17b54139d89a15179265d4aed4a1fe36fd47
Reviewed-on: https://skia-review.googlesource.com/133566
Commit-Queue: Khusal Sagar <khushalsagar@chromium.org>
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>

[modify] https://crrev.com/4010c792c6bd0378087225ae16b0131bd2c303f2/src/core/SkGlyphCache.cpp
[modify] https://crrev.com/4010c792c6bd0378087225ae16b0131bd2c303f2/tests/SkRemoteGlyphCacheTest.cpp
[modify] https://crrev.com/4010c792c6bd0378087225ae16b0131bd2c303f2/src/core/SkGlyphCache.h
[modify] https://crrev.com/4010c792c6bd0378087225ae16b0131bd2c303f2/src/core/SkGlyph.h
[modify] https://crrev.com/4010c792c6bd0378087225ae16b0131bd2c303f2/src/core/SkRemoteGlyphCache.cpp

Project Member

Comment 30 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/543be0a1616e2daabb6db122a2dc4b1a63fcaff1

commit 543be0a1616e2daabb6db122a2dc4b1a63fcaff1
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Jun 14 00:26:22 2018

Roll src/third_party/skia 7c525e62d405..fdcfb8b7c23f (17 commits)

https://skia.googlesource.com/skia.git/+log/7c525e62d405..fdcfb8b7c23f


git log 7c525e62d405..fdcfb8b7c23f --date=short --no-merges --format='%ad %ae %s'
2018-06-13 halcanary@google.com Revert "SkTypes: extract SkTo"
2018-06-12 halcanary@google.com SkTypes: add static back
2018-06-12 bungeman@google.com Remove SkBool8.
2018-06-12 brucewang@google.com Implement DWriteFontTypeface::onGetVariationDesignPosition on win10.
2018-06-12 mtklein@google.com Revert "simplify SkTFitsIn"
2018-06-12 khushalsagar@chromium.org fonts: Fix memory allocation for fallback glyphs.
2018-06-12 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a8802477752f..7ce4a15115cb (3 commits)
2018-06-12 halcanary@google.com SkTypes:  more into SkMacros
2018-06-12 halcanary@google.com SkTypes: templates are usually better than macros
2018-06-12 ethannicholas@google.com renamed SkSL's assert macros
2018-06-12 halcanary@google.com SkMacros split from SkTypes.h
2018-06-12 mtklein@chromium.org avoid immintrin.h in SkNx_sse.h
2018-06-12 benjaminwagner@google.com Add Vulkan jobs for GalaxyS7.
2018-06-12 mtklein@chromium.org remove __cplusplus guard
2018-06-12 mtklein@chromium.org simplify SkTFitsIn
2018-06-12 egdaniel@google.com Add blacklist to failing vulkan gtx660 test.
2018-06-12 halcanary@google.com SkTypes: extract SkTo


Created with:
  gclient setdep -r src/third_party/skia@fdcfb8b7c23f

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:829622 
TBR=csmartdalton@chromium.org

Change-Id: I896d8a03a7b21a46f08d6c14e79548f5b37148cf
Reviewed-on: https://chromium-review.googlesource.com/1098939
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567061}
[modify] https://crrev.com/543be0a1616e2daabb6db122a2dc4b1a63fcaff1/DEPS

Project Member

Comment 31 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc05af85f063f98f51ee43fa556deb8779ba3df0

commit cc05af85f063f98f51ee43fa556deb8779ba3df0
Author: Khushal <khushalsagar@chromium.org>
Date: Thu Jun 14 03:59:33 2018

gpu: Add metrics for tracking GlyphCache miss for OOP raster.

When using OOP raster, the renderer must send the requisite glyphs for
rasterization with the paint commands that need them. If the glyph can't
be found, the GPU will fallback to using the closest match available in
the cache. Ideally, this should never happen and indicates an error in
the analysis code in the renderer for identifying these glyphs.

Add an UMA to record the number of such instances and in the extreme
case where no fallback can be found and we skip drawing this glyph, do a
DumpWithoutCrashing.

R=piman@chromium.org

Bug:  829622 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibcdaf408009a085d11374a6e7ef2897ff8e61fc8
Reviewed-on: https://chromium-review.googlesource.com/1096543
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567124}
[modify] https://crrev.com/cc05af85f063f98f51ee43fa556deb8779ba3df0/gpu/command_buffer/service/service_font_manager.cc
[modify] https://crrev.com/cc05af85f063f98f51ee43fa556deb8779ba3df0/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/cc05af85f063f98f51ee43fa556deb8779ba3df0/tools/metrics/histograms/histograms.xml

Project Member

Comment 32 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b91daa8df790da14d7ba894b7c769a227736653

commit 6b91daa8df790da14d7ba894b7c769a227736653
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Jun 14 04:02:00 2018

Roll src/third_party/skia fdcfb8b7c23f..657edbede4e3 (27 commits)

https://skia.googlesource.com/skia.git/+log/fdcfb8b7c23f..657edbede4e3


git log fdcfb8b7c23f..657edbede4e3 --date=short --no-merges --format='%ad %ae %s'
2018-06-13 bungeman@google.com Remove SkBool8 (again).
2018-06-13 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 3e313805e5a2..4cc753e01054 (8 commits)
2018-06-13 bungeman@google.com Adjust FreeType matrix based on what came back.
2018-06-13 csmartdalton@google.com ccpr: Initialize the atlas size more intelligently
2018-06-13 fmalita@chromium.org Handle missing json resource gracefully in 3dgm
2018-06-13 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-13 benjaminwagner@google.com Update Win version in Skolo.
2018-06-13 bungeman@google.com Remove SkString fwd decl from SkTypes.h.
2018-06-13 robertphillips@google.com Revert "Add --gpuThreads support to skpbench.py"
2018-06-13 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-13 mtklein@google.com Revert "simplify SkTFitsIn, try 2"
2018-06-13 mtklein@google.com Revert "use std::enable_if instead of assert()"
2018-06-13 robertphillips@google.com Add --gpuThreads support to skpbench.py
2018-06-13 robertphillips@google.com Pull non-substantive changes out of omnibus CL
2018-06-13 egdaniel@google.com Remove unused code that was used for late mip allocations.
2018-06-13 egdaniel@google.com Fix ImageTest to check if gpu mip maps are supported.
2018-06-13 caryclark@skia.org minor fixes to SkRRect
2018-06-13 khushalsagar@chromium.org fonts: Ignore re-initialization of fallback glyphs from the server.
2018-06-13 mtklein@chromium.org use std::enable_if instead of assert()
2018-06-13 mtklein@chromium.org Does everyone support __has_include() now?
2018-06-13 bungeman@google.com Remove SkMulDiv.
2018-06-13 bungeman@google.com Always FreeType autohint when requested.
2018-06-13 timliang@google.com consolidated writing fields logic and added more builtins for skslc msl backend
2018-06-13 egdaniel@google.com Allow caller to specify if the want mip maps in makeTextureImage call.
2018-06-13 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 7ce4a15115cb..3e313805e5a2 (2 commits)
2018-06-13 mtklein@chromium.org simplify SkTFitsIn, try 2
2018-06-13 robertphillips@google.com Fix IsFunctionallyExact


Created with:
  gclient setdep -r src/third_party/skia@657edbede4e3

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:829622 , chromium:834837 , chromium:849034 
TBR=csmartdalton@chromium.org

Change-Id: If651c755d8ea6b2cf1bb3c8f84e8709e80f352a4
Reviewed-on: https://chromium-review.googlesource.com/1100316
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567125}
[modify] https://crrev.com/6b91daa8df790da14d7ba894b7c769a227736653/DEPS

Status: Fixed (was: Assigned)

Sign in to add a comment