New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 829618 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression
Proj-XR



Sign in to add a comment

9.5%-28.7% regression in xr.vr.common_perftests at 548059:548145

Project Member Reported by bsheedy@google.com, Apr 5 2018

Issue description

Culprit CL is https://chromium-review.googlesource.com/993760.

I have no idea how this caused a perf regression...
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=829618

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=a13bf3edbca793b79c9d8e105fe9f009e0821b2f57736175c2e34594cbe79f0c


Bot(s) for this bug's original alert(s):

pixel_xl
Components: Internals>VR
Labels: Proj-VR VR-Perf
Yeah, nor can I. The only functional code added is a trace event. Was this a bisect?
Sorry, I should have read more closely to see that this is the perftests that have changed. I did update the perftests, but the refactor I did for these is pretty trivial, so I'm still pretty surprised about this.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5453a2b31ad469be7b4be5af2ee74ad16d972e52

commit 5453a2b31ad469be7b4be5af2ee74ad16d972e52
Author: Ian Vollick <vollick@chromium.org>
Date: Sat Apr 07 06:00:19 2018

Revert "[vr] Add a perftest for UI cpu work"

This reverts commit d4ce3da707ac4ec32c3f23ff1eb5e450a4c310b9.

Reason for revert: hoping this will fix a perf regression.

Original change's description:
> [vr] Add a perftest for UI cpu work
>
> This adds a perftest which moves the reticle around and measures the
> UI costs.
>
> Bug: None
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I688ad47adb6e3ba4f6cf5fd19410d348ba154e30
> Reviewed-on: https://chromium-review.googlesource.com/993760
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548068}

TBR=vollick@chromium.org,tiborg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  829618 
Change-Id: Ia43e3e937f8ad3ef1699f2970213373111620d20
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1000793
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549042}
[modify] https://crrev.com/5453a2b31ad469be7b4be5af2ee74ad16d972e52/chrome/browser/vr/BUILD.gn
[delete] https://crrev.com/0cc8f9ef9cfe9fb3bcb9d4bfae9635e0a75a58b9/chrome/browser/vr/test/perf_test_utils.cc
[delete] https://crrev.com/0cc8f9ef9cfe9fb3bcb9d4bfae9635e0a75a58b9/chrome/browser/vr/test/perf_test_utils.h
[delete] https://crrev.com/0cc8f9ef9cfe9fb3bcb9d4bfae9635e0a75a58b9/chrome/browser/vr/test/ui_perftest.cc
[modify] https://crrev.com/5453a2b31ad469be7b4be5af2ee74ad16d972e52/chrome/browser/vr/test/ui_test.h
[modify] https://crrev.com/5453a2b31ad469be7b4be5af2ee74ad16d972e52/chrome/browser/vr/text_perftest.cc
[modify] https://crrev.com/5453a2b31ad469be7b4be5af2ee74ad16d972e52/chrome/browser/vr/ui_scene.cc

Reverted, but I'll wait for the graphs to clear up before marking this fixed.
Looks like the affected graphs did revert to their old values with the revert.
Status: Fixed (was: Assigned)
Yep. Marking as fixed.
Labels: Test-Complete
Components: Internals>XR

Sign in to add a comment