Issue metadata
Sign in to add a comment
|
9.5%-28.7% regression in xr.vr.common_perftests at 548059:548145 |
||||||||||||||||||||||
Issue descriptionCulprit CL is https://chromium-review.googlesource.com/993760. I have no idea how this caused a perf regression...
,
Apr 5 2018
,
Apr 7 2018
Yeah, nor can I. The only functional code added is a trace event. Was this a bisect?
,
Apr 7 2018
Sorry, I should have read more closely to see that this is the perftests that have changed. I did update the perftests, but the refactor I did for these is pretty trivial, so I'm still pretty surprised about this.
,
Apr 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5453a2b31ad469be7b4be5af2ee74ad16d972e52 commit 5453a2b31ad469be7b4be5af2ee74ad16d972e52 Author: Ian Vollick <vollick@chromium.org> Date: Sat Apr 07 06:00:19 2018 Revert "[vr] Add a perftest for UI cpu work" This reverts commit d4ce3da707ac4ec32c3f23ff1eb5e450a4c310b9. Reason for revert: hoping this will fix a perf regression. Original change's description: > [vr] Add a perftest for UI cpu work > > This adds a perftest which moves the reticle around and measures the > UI costs. > > Bug: None > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I688ad47adb6e3ba4f6cf5fd19410d348ba154e30 > Reviewed-on: https://chromium-review.googlesource.com/993760 > Commit-Queue: Ian Vollick <vollick@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548068} TBR=vollick@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 829618 Change-Id: Ia43e3e937f8ad3ef1699f2970213373111620d20 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1000793 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#549042} [modify] https://crrev.com/5453a2b31ad469be7b4be5af2ee74ad16d972e52/chrome/browser/vr/BUILD.gn [delete] https://crrev.com/0cc8f9ef9cfe9fb3bcb9d4bfae9635e0a75a58b9/chrome/browser/vr/test/perf_test_utils.cc [delete] https://crrev.com/0cc8f9ef9cfe9fb3bcb9d4bfae9635e0a75a58b9/chrome/browser/vr/test/perf_test_utils.h [delete] https://crrev.com/0cc8f9ef9cfe9fb3bcb9d4bfae9635e0a75a58b9/chrome/browser/vr/test/ui_perftest.cc [modify] https://crrev.com/5453a2b31ad469be7b4be5af2ee74ad16d972e52/chrome/browser/vr/test/ui_test.h [modify] https://crrev.com/5453a2b31ad469be7b4be5af2ee74ad16d972e52/chrome/browser/vr/text_perftest.cc [modify] https://crrev.com/5453a2b31ad469be7b4be5af2ee74ad16d972e52/chrome/browser/vr/ui_scene.cc
,
Apr 7 2018
Reverted, but I'll wait for the graphs to clear up before marking this fixed.
,
Apr 9 2018
Looks like the affected graphs did revert to their old values with the revert.
,
Apr 9 2018
Yep. Marking as fixed.
,
May 8 2018
,
Jul 4
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Apr 5 2018