Add command buffer workarounds to Skia |
||||||
Issue descriptionOOP-R is going to run without using the command buffer and so needs to have most of these implemented in Skia to avoid regressing things: https://docs.google.com/spreadsheets/d/1dwy4-HrBgXFaQFAq5FyfpjGhLZ94KAvB-uNXYoaDjbE/edit#gid=0 Ideally, we can share similar workaround metadata so that the same workaround names and conditions apply to both the command buffer and Skia.
,
Apr 9 2018
Doing some brainstorming of how this feature might work. I think it's important to share the workaround names (gpu_driver_bug_workaround_type.h) and also the control list (gpu_driver_bug_list.json) for consistency. We already have inconsistency issues with Skia disagreeing with Chrome about what's allowed, so sharing these directly at some level seems important. Secondarily, I think it's a non-starter for Chrome to require a Skia roll to update workarounds. Skia also needs to be able to build independently of Chrome. Here's one potential solution: Generate gpu_driver_bug_workaround_type.h from a text list file of features. Some python script can slurp this in and then spit out some gpu_driver_bug_workaround_type.h. We can move out everything that's not the GPU_OP list into some other common file. Once we are autogenerating this, then both Chrome and Skia can create their own list of features that they support, since there is C++ code that uses those workaround names explicitly. So, if there's Skia code that uses some workaround, then it can independently list it. Similarly, for Chrome. Modify the autogenerating python script to use multiple feature lists. Skia-in-Chrome builds can inject an additional Chrome file as a part of this build step so that Skia-in-Chrome and Chrome both use the same workaround names / ids. To avoid code sharing issues of GpuControlList and all the parsing of gpu_driver_bug_list.json, Chrome can initialize Skia directly with the workarounds that it needs via something similar to GpuDriverBugWorkarounds IntSetToWorkarounds. Skia can probably implement its own version of gpu_driver_bug_workarounds.h/cc as there's only ~20 lines of code there. The only downside here is that this only provides a consistent way to turn on Chrome workarounds in Skia. Any Skia-only workarounds that want to be applied in standalone Skia that's not inside a Chrome build need some other mechanism to get turned on and can't reuse the same json. Currently it looks like a lot of these get turned on externally via GrContextOptions which then set GrCaps. Other ones are detected inside of GrCaps doing much of the same work that gpu_driver_bug_list.json does. It seems like optionally some of these workarounds could get moved to a new GpuDriverBugWorkarounds structure for consistency / visibility, although that's just cleanup. Maybe this is fine as-is.
,
Apr 9 2018
Another situation that needs to be considered. When Chrome runs in MANGLE mode (soon on Windows platform), Chrome and ANGLE also needs to share one copy of workarounds. I agree with enne@ that it's better to avoid Chrome's workarounds depending on Skia. As far as I understand, in theory we should be able to turn off GPU driver bug workarounds in Skia if it runs on top of command buffer, because whatever bugs / issues from the underlying driver, command buffer should works around that so anything above command buffer doesn't need to care about them. If Skia runs in places other than Chrome, then it needs all the workarounds.
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92f16ea7c0a121caf3f73a75c87f407b545647dc commit 92f16ea7c0a121caf3f73a75c87f407b545647dc Author: Adrienne Walker <enne@chromium.org> Date: Wed Apr 11 22:35:17 2018 Generate gpu workaround list from text files This will enable Skia to also have its own independent workaround list, that Chrome can also include while building. This prevents the need for rolls as there is just a loose coupling of workaround names. After this patch, Skia can be updated to have its own workaround list and some header defined at build time to either use Chrome's version or its own internal version of the autogen'd header. Bug: 829614 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I596d315d41bb543106a5f656402043356fdf2737 Reviewed-on: https://chromium-review.googlesource.com/1005362 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#549957} [modify] https://crrev.com/92f16ea7c0a121caf3f73a75c87f407b545647dc/gpu/config/BUILD.gn [add] https://crrev.com/92f16ea7c0a121caf3f73a75c87f407b545647dc/gpu/config/build_workaround_header.py [modify] https://crrev.com/92f16ea7c0a121caf3f73a75c87f407b545647dc/gpu/config/gpu_driver_bug_workaround_type.h [add] https://crrev.com/92f16ea7c0a121caf3f73a75c87f407b545647dc/gpu/config/gpu_workaround_list.txt [modify] https://crrev.com/92f16ea7c0a121caf3f73a75c87f407b545647dc/gpu/config/process_json.py
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3fdac1b401f3e573a906577d61a18bb4fc20a08 commit b3fdac1b401f3e573a906577d61a18bb4fc20a08 Author: Adrienne Walker <enne@chromium.org> Date: Tue Apr 17 17:10:34 2018 skia: Add workaround header define Chromium-side changes for: https://skia-review.googlesource.com/c/skia/+/120608 Bug: 829614 Change-Id: I59dc05ae1d66622ce3c771311ec3e1b64023b66f Reviewed-on: https://chromium-review.googlesource.com/1008924 Reviewed-by: Brian Salomon <bsalomon@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#551370} [modify] https://crrev.com/b3fdac1b401f3e573a906577d61a18bb4fc20a08/skia/BUILD.gn
,
Apr 18 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/94d25b970b97c68ddd0b4ceb71f2233aac05e6b5 commit 94d25b970b97c68ddd0b4ceb71f2233aac05e6b5 Author: Adrienne Walker <enne@chromium.org> Date: Wed Apr 18 23:10:33 2018 Add stub gpu workaround generators Like https://chromium-review.googlesource.com/c/chromium/src/+/1005362, this patch adds a way for Chrome and Skia to share a set of driver workaround names so that they can be turned on by Chrome (or Skia) as needed. To avoid weird cross-repository dependencies, the generator script is duplicated in Skia. This patch just adds a few dummy workaround names to make sure the build process is working. The followup to this is to add workaround init to GrContext/GrContextOptions and to start implementing individual workarounds. Implementing these workarounds is to support Chrome's "out of process raster" which will use Ganesh without a command buffer, and so will not have the workarounds that the command buffer provides. Bug: chromium:829614 Change-Id: I40745a777a95805995991fedb81657ae418b52d9 Reviewed-on: https://skia-review.googlesource.com/120608 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org> [modify] https://crrev.com/94d25b970b97c68ddd0b4ceb71f2233aac05e6b5/BUILD.gn [add] https://crrev.com/94d25b970b97c68ddd0b4ceb71f2233aac05e6b5/src/gpu/GrDriverBugWorkaroundsAutogen.h [add] https://crrev.com/94d25b970b97c68ddd0b4ceb71f2233aac05e6b5/tools/build_workaround_header.py [modify] https://crrev.com/94d25b970b97c68ddd0b4ceb71f2233aac05e6b5/gn/gpu.gni [add] https://crrev.com/94d25b970b97c68ddd0b4ceb71f2233aac05e6b5/src/gpu/gpu_workaround_list.txt [add] https://crrev.com/94d25b970b97c68ddd0b4ceb71f2233aac05e6b5/src/gpu/GrDriverBugWorkarounds.h [add] https://crrev.com/94d25b970b97c68ddd0b4ceb71f2233aac05e6b5/src/gpu/GrDriverBugWorkarounds.cpp
,
Apr 19 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/2ae45ae83a5778910a86afdbda5329a92bfef066 commit 2ae45ae83a5778910a86afdbda5329a92bfef066 Author: Leon Scroggins <scroggo@google.com> Date: Thu Apr 19 12:25:14 2018 Revert "Add stub gpu workaround generators" This reverts commit 94d25b970b97c68ddd0b4ceb71f2233aac05e6b5. Reason for revert: Breaking the Chromium roll Original change's description: > Add stub gpu workaround generators > > Like https://chromium-review.googlesource.com/c/chromium/src/+/1005362, > this patch adds a way for Chrome and Skia to share a set of driver > workaround names so that they can be turned on by Chrome (or Skia) as > needed. > > To avoid weird cross-repository dependencies, the generator script is > duplicated in Skia. > > This patch just adds a few dummy workaround names to make sure the build > process is working. The followup to this is to add workaround init > to GrContext/GrContextOptions and to start implementing individual > workarounds. > > Implementing these workarounds is to support Chrome's "out of process > raster" which will use Ganesh without a command buffer, and so will not > have the workarounds that the command buffer provides. > > Bug: chromium:829614 > Change-Id: I40745a777a95805995991fedb81657ae418b52d9 > Reviewed-on: https://skia-review.googlesource.com/120608 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Adrienne Walker <enne@chromium.org> TBR=bsalomon@google.com,enne@chromium.org Change-Id: Ie0b69d7d028dabca1fd70813b6920386c8838247 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:829614 Reviewed-on: https://skia-review.googlesource.com/122240 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com> [modify] https://crrev.com/2ae45ae83a5778910a86afdbda5329a92bfef066/BUILD.gn [delete] https://crrev.com/dbc59ba23b5cb70cdf77cfdb6cbe372223a17832/src/gpu/GrDriverBugWorkaroundsAutogen.h [delete] https://crrev.com/dbc59ba23b5cb70cdf77cfdb6cbe372223a17832/tools/build_workaround_header.py [modify] https://crrev.com/2ae45ae83a5778910a86afdbda5329a92bfef066/gn/gpu.gni [delete] https://crrev.com/dbc59ba23b5cb70cdf77cfdb6cbe372223a17832/src/gpu/gpu_workaround_list.txt [delete] https://crrev.com/dbc59ba23b5cb70cdf77cfdb6cbe372223a17832/src/gpu/GrDriverBugWorkarounds.h [delete] https://crrev.com/dbc59ba23b5cb70cdf77cfdb6cbe372223a17832/src/gpu/GrDriverBugWorkarounds.cpp
,
Apr 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbf12bb49278f24340aaf765c3595d996dfdf5b8 commit fbf12bb49278f24340aaf765c3595d996dfdf5b8 Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Apr 19 13:40:00 2018 Roll src/third_party/skia/ 4c32956b1..2ae45ae83 (9 commits) https://skia.googlesource.com/skia.git/+log/4c32956b1fee..2ae45ae83a57 $ git log 4c32956b1..2ae45ae83 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 scroggo Revert "Add stub gpu workaround generators" 2018-04-19 caryclark path is rect track corners 2018-04-17 borenet Reland "[infra] Run recipes through Kitchen" 2018-04-19 angle-skia-autoroll Roll third_party/externals/angle2/ aaa19de06..eeec3b14c (1 commit) 2018-04-18 angle-skia-autoroll Roll third_party/externals/angle2/ 5804dc8ea..aaa19de06 (9 commits) 2018-04-18 enne Add stub gpu workaround generators 2018-04-18 herb Move strike cache Find*() to strike cache 2018-04-18 liyuqian Remove SK_SUPPORT_LEGACY_PATH_DAA_BIT 2018-04-18 fmalita Prevent unnecessary/unbounded growth of SkTDynamicHash capacity Created with: roll-dep src/third_party/skia BUG= chromium:829614 , chromium:824145 , chromium:829614 , chromium:832482 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I6d92732f2ff872d7b5c1df456c66cc54a4615abc Reviewed-on: https://chromium-review.googlesource.com/1019381 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551999} [modify] https://crrev.com/fbf12bb49278f24340aaf765c3595d996dfdf5b8/DEPS
,
Apr 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0af73307ddef5da0c758b180d25746d6b1262600 commit 0af73307ddef5da0c758b180d25746d6b1262600 Author: enne <enne@chromium.org> Date: Fri Apr 20 01:17:50 2018 Revert "skia: Add workaround header define" This reverts commit b3fdac1b401f3e573a906577d61a18bb4fc20a08. Reason for revert: no longer needed Causes breakages in https://chromium-review.googlesource.com/c/chromium/src/+/1018402 Will roll Skia patch first and then reland this. Original change's description: > skia: Add workaround header define > > Chromium-side changes for: > https://skia-review.googlesource.com/c/skia/+/120608 > > Bug: 829614 > Change-Id: I59dc05ae1d66622ce3c771311ec3e1b64023b66f > Reviewed-on: https://chromium-review.googlesource.com/1008924 > Reviewed-by: Brian Salomon <bsalomon@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551370} TBR=bsalomon@chromium.org,enne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 829614 Change-Id: I7512e16d2023c51407c2d3bc8b2969dc067d5f91 Reviewed-on: https://chromium-review.googlesource.com/1019730 Reviewed-by: enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#552223} [modify] https://crrev.com/0af73307ddef5da0c758b180d25746d6b1262600/skia/BUILD.gn
,
Apr 20 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/1df7cd871224adeca1d0491c061a16fe4e6d28bc commit 1df7cd871224adeca1d0491c061a16fe4e6d28bc Author: Adrienne Walker <enne@chromium.org> Date: Fri Apr 20 17:50:45 2018 Reland "Add stub gpu workaround generators" This is a reland of 94d25b970b97c68ddd0b4ceb71f2233aac05e6b5 Original change's description: > Add stub gpu workaround generators > > Like https://chromium-review.googlesource.com/c/chromium/src/+/1005362, > this patch adds a way for Chrome and Skia to share a set of driver > workaround names so that they can be turned on by Chrome (or Skia) as > needed. > > To avoid weird cross-repository dependencies, the generator script is > duplicated in Skia. > > This patch just adds a few dummy workaround names to make sure the build > process is working. The followup to this is to add workaround init > to GrContext/GrContextOptions and to start implementing individual > workarounds. > > Implementing these workarounds is to support Chrome's "out of process > raster" which will use Ganesh without a command buffer, and so will not > have the workarounds that the command buffer provides. > > Bug: chromium:829614 > Change-Id: I40745a777a95805995991fedb81657ae418b52d9 > Reviewed-on: https://skia-review.googlesource.com/120608 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Adrienne Walker <enne@chromium.org> Bug: chromium:829614 Change-Id: Idb3309ffa894f7585ee493388b56565e9d4a3101 Reviewed-on: https://skia-review.googlesource.com/122800 Auto-Submit: Adrienne Walker <enne@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/1df7cd871224adeca1d0491c061a16fe4e6d28bc/BUILD.gn [add] https://crrev.com/1df7cd871224adeca1d0491c061a16fe4e6d28bc/src/gpu/GrDriverBugWorkaroundsAutogen.h [add] https://crrev.com/1df7cd871224adeca1d0491c061a16fe4e6d28bc/tools/build_workaround_header.py [modify] https://crrev.com/1df7cd871224adeca1d0491c061a16fe4e6d28bc/gn/gpu.gni [add] https://crrev.com/1df7cd871224adeca1d0491c061a16fe4e6d28bc/src/gpu/gpu_workaround_list.txt [add] https://crrev.com/1df7cd871224adeca1d0491c061a16fe4e6d28bc/src/gpu/GrDriverBugWorkarounds.h [add] https://crrev.com/1df7cd871224adeca1d0491c061a16fe4e6d28bc/src/gpu/GrDriverBugWorkarounds.cpp
,
Apr 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2564c15a034a4460cc4b647c5755ff9bf9f0d637 commit 2564c15a034a4460cc4b647c5755ff9bf9f0d637 Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Apr 21 01:27:19 2018 Roll src/third_party/skia/ 0d24c5021..5209d7fce (18 commits) https://skia.googlesource.com/skia.git/+log/0d24c502113b..5209d7fce35f $ git log 0d24c5021..5209d7fce --date=short --no-merges --format='%ad %ae %s' 2018-04-20 bsalomon Fix starting location in GrRTC::drawOval when converting to GrShape 2018-04-20 bsalomon Analytic dashing of circles with single on/off intervals and butt caps. 2018-04-20 brianosman Fix argument names and documentation for SkMatrix44::set3x3() 2018-04-18 enne Reland "Add stub gpu workaround generators" 2018-04-20 robertphillips Add ability to dump opList info at flush-time 2018-04-20 benjaminwagner Fix Housekeeper-PerCommit-InfraTests 2018-04-20 scroggo Reduce threads used for DNG decodes on Android 2018-04-19 benjaminwagner Add SwiftShader Build jobs. 2018-04-19 benjaminwagner Add cmake_linux asset. 2018-04-20 egdaniel Add discard check when deciding if we should execute op list or not. 2018-04-20 robertphillips Remove another writePixels instance 2018-04-18 csmartdalton ccpr: Don't solve for cubic roots that are out of range 2018-04-19 benjaminwagner Add SwiftShader to DEPS. 2018-04-19 csmartdalton ccpr: Fix flatness and triangle-ness detection for conics 2018-04-20 robertphillips Prevent matrix stack from being corrupted if a rotated image filter is clipped out 2018-04-20 caryclark guard against NaN in path is rect 2018-04-19 fmalita Fix use-of-uninitialized-value in SkPictureShader::onMakeContext 2018-04-19 benjaminwagner Disable retries for Build, CT, and Calmbench tasks. Created with: roll-dep src/third_party/skia BUG= chromium:829614 ,chromium:b/78120086,chromium:835048 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I1547f2fccadcd1c6ca11f12d08bbf615a0fa1305 Reviewed-on: https://chromium-review.googlesource.com/1022719 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552541} [modify] https://crrev.com/2564c15a034a4460cc4b647c5755ff9bf9f0d637/DEPS
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3cc46b708ba53b3aca17d273221766d4d88a83a8 commit 3cc46b708ba53b3aca17d273221766d4d88a83a8 Author: Adrienne Walker <enne@chromium.org> Date: Mon Apr 23 23:45:17 2018 Reland "skia: Add workaround header define" This is a reland of b3fdac1b401f3e573a906577d61a18bb4fc20a08 Original change's description: > skia: Add workaround header define > > Chromium-side changes for: > https://skia-review.googlesource.com/c/skia/+/120608 > > Bug: 829614 > Change-Id: I59dc05ae1d66622ce3c771311ec3e1b64023b66f > Reviewed-on: https://chromium-review.googlesource.com/1008924 > Reviewed-by: Brian Salomon <bsalomon@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551370} Bug: 829614 Change-Id: I206bed834a1819aea819648ba1f3ca486af94657 Reviewed-on: https://chromium-review.googlesource.com/1024310 Reviewed-by: Brian Salomon <bsalomon@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#552903} [modify] https://crrev.com/3cc46b708ba53b3aca17d273221766d4d88a83a8/skia/BUILD.gn
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d97939d2e3d2613ffd9a46fc1e0dac3d89bf5d2e commit d97939d2e3d2613ffd9a46fc1e0dac3d89bf5d2e Author: Adrienne Walker <enne@chromium.org> Date: Wed Apr 25 00:22:23 2018 gpu: merge skia workaround names with gpu workarounds Now that Skia has its own list of workaround names, build the list of workarounds from a combined list of Skia's and Chrome's. Bug: 829614 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2d33190fba17421799aed6786f1e675a37601aed Reviewed-on: https://chromium-review.googlesource.com/1026804 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#553387} [modify] https://crrev.com/d97939d2e3d2613ffd9a46fc1e0dac3d89bf5d2e/gpu/config/BUILD.gn
,
Apr 25 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/6f719aeeae5fc600faaf4b55e7efc11fe2df19b3 commit 6f719aeeae5fc600faaf4b55e7efc11fe2df19b3 Author: Adrienne Walker <enne@chromium.org> Date: Wed Apr 25 19:26:27 2018 Add CheckGeneratedFiles recipe check for gpu workarounds Followup to https://skia-review.googlesource.com/122800 Bug: chromium: 829614 Change-Id: Idde753e0f8943290208625ba5b6332a5fdc07184 Reviewed-on: https://skia-review.googlesource.com/123536 Commit-Queue: Adrienne Walker <enne@chromium.org> Commit-Queue: Eric Boren <borenet@google.com> Auto-Submit: Adrienne Walker <enne@chromium.org> Reviewed-by: Eric Boren <borenet@google.com> [modify] https://crrev.com/6f719aeeae5fc600faaf4b55e7efc11fe2df19b3/infra/bots/recipe_modules/flavor/examples/full.expected/Housekeeper-PerCommit-CheckGeneratedFiles.json [modify] https://crrev.com/6f719aeeae5fc600faaf4b55e7efc11fe2df19b3/infra/bots/recipe_modules/flavor/gn_flavor.py [modify] https://crrev.com/6f719aeeae5fc600faaf4b55e7efc11fe2df19b3/src/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/6f719aeeae5fc600faaf4b55e7efc11fe2df19b3/tools/build_workaround_header.py [modify] https://crrev.com/6f719aeeae5fc600faaf4b55e7efc11fe2df19b3/infra/bots/recipes/check_generated_files.expected/Housekeeper-PerCommit-CheckGeneratedFiles.json
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/063237496a9efaff3ad048a0dd810d61ea41b863 commit 063237496a9efaff3ad048a0dd810d61ea41b863 Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Apr 25 21:33:50 2018 Roll src/third_party/skia/ 27988f76b..25af671a3 (21 commits) https://skia.googlesource.com/skia.git/+log/27988f76b25e..25af671a3d7d $ git log 27988f76b..25af671a3 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 egdaniel Add GrCap check for whether we can do a copy or not, and implement in Vk backend 2018-04-25 borenet [infra] Run presubmit like a normal bot 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms a893aa3..2c9b55f (1 commits) 2018-04-25 enne Add CheckGeneratedFiles recipe check for gpu workarounds 2018-04-25 bungeman Clean up xfermodes3 gm. 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 509a65e..a893aa3 (1 commits) 2018-04-25 liyuqian Snap bitmap for SkThreadedBMPDevice::drawBitmapRect 2018-04-25 bsalomon Revert "Revert "Add arcs as a specialized geometry to GrShape."" 2018-04-25 kjlubick Move Baytrail to stretch 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 48c6ca0..509a65e (1 commits) 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 9e351c0..48c6ca0 (1 commits) 2018-04-25 angle-skia-autoroll Roll third_party/externals/angle2/ 023371b3a..f827123d9 (5 commits) 2018-04-25 brianosman Don't 'require' external image extensions, 'enable' them 2018-04-25 reed Experiment to track coverage in a layer 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms f3a576b..9e351c0 (1 commits) 2018-04-24 ethannicholas cache SkSL headers 2018-04-24 benjaminwagner Upgrade Win Radeon driver. 2018-04-25 robertphillips Fix GrRRectBlurEffect.fp 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 40a5028..f3a576b (1 commits) 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 86807d3..40a5028 (1 commits) 2018-04-25 kjlubick Migrate ShuttleA bots to Debian9 stretch Created with: roll-dep src/third_party/skia BUG=chromium: 829614 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I573306e5aee3463fe005e9f9ae679ee0fa7bdf95 Reviewed-on: https://chromium-review.googlesource.com/1028625 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553758} [modify] https://crrev.com/063237496a9efaff3ad048a0dd810d61ea41b863/DEPS
,
May 10 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/328490c6a1625ce51d0e81688e0c85c79c400d86 commit 328490c6a1625ce51d0e81688e0c85c79c400d86 Author: Adrienne Walker <enne@chromium.org> Date: Thu May 10 14:54:15 2018 Add driver bug workarounds to GrCaps This moves GrDriverBugWorkarounds to include so that it can be included by GrCaps. This also makes GrContextOptions a nearly empty class in the case of !SK_SUPPORT_GPU so that non-gpu builds don't need to build in GrDriverBugWorkarounds.cpp. Bug: chromium: 829614 Change-Id: Iedf73677fd09e9a487cfe618a696fd4b25c8703d Reviewed-on: https://skia-review.googlesource.com/126581 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org> [modify] https://crrev.com/328490c6a1625ce51d0e81688e0c85c79c400d86/dm/DMSrcSink.cpp [rename] https://crrev.com/328490c6a1625ce51d0e81688e0c85c79c400d86/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/328490c6a1625ce51d0e81688e0c85c79c400d86/include/gpu/GrCaps.h [modify] https://crrev.com/328490c6a1625ce51d0e81688e0c85c79c400d86/BUILD.gn [rename] https://crrev.com/328490c6a1625ce51d0e81688e0c85c79c400d86/include/gpu/GrDriverBugWorkarounds.h [modify] https://crrev.com/328490c6a1625ce51d0e81688e0c85c79c400d86/gn/gpu.gni [modify] https://crrev.com/328490c6a1625ce51d0e81688e0c85c79c400d86/src/gpu/GrDriverBugWorkarounds.cpp [modify] https://crrev.com/328490c6a1625ce51d0e81688e0c85c79c400d86/include/gpu/GrContextOptions.h [modify] https://crrev.com/328490c6a1625ce51d0e81688e0c85c79c400d86/src/gpu/GrCaps.cpp
,
May 10 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/f31fece6581a46b40403fc78c83c7eebe50816ba commit f31fece6581a46b40403fc78c83c7eebe50816ba Author: Adrienne Walker <enne@chromium.org> Date: Thu May 10 16:01:15 2018 Driver bug workaround: disable_blend_equation_advanced Bug: chromium: 829614 Change-Id: If8eaec6d22412ec36aad8a143f84080be05f2926 Reviewed-on: https://skia-review.googlesource.com/126748 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org> [modify] https://crrev.com/f31fece6581a46b40403fc78c83c7eebe50816ba/include/gpu/GrCaps.h [modify] https://crrev.com/f31fece6581a46b40403fc78c83c7eebe50816ba/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/f31fece6581a46b40403fc78c83c7eebe50816ba/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/f31fece6581a46b40403fc78c83c7eebe50816ba/src/gpu/gl/GrGLCaps.cpp
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/035c0c8f116fe792a3052e44cefdd99409ee8283 commit 035c0c8f116fe792a3052e44cefdd99409ee8283 Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu May 10 16:49:19 2018 Roll src/third_party/skia/ d31b2f674..2d46a0092 (9 commits) https://skia.googlesource.com/skia.git/+log/d31b2f674acc..2d46a0092661 $ git log d31b2f674..2d46a0092 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 reed allow divide by zero 2018-05-10 fmalita Validate readByteArrayAsData size 2018-05-07 enne Add driver bug workarounds to GrCaps 2018-05-03 egdaniel Remove GrBackendObject and all related functions from Skia. 2018-05-10 fmalita Validate gradient DescriptorScope size during deserialization 2018-05-10 bsalomon Revert "Revert "Don't use GrRRectBlurEffect for large rects when highp is not full float"" 2018-05-03 egdaniel Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter. 2018-05-09 bungeman Add all SkPaint::Flags to Viewer app. 2018-05-09 robertphillips Fix clipping of SkMatrixImageFilter input (take 2) Created with: roll-dep src/third_party/skia BUG=chromium: 829614 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I88cde5822b6f84857587f5a06861489d9eae6dbc Reviewed-on: https://chromium-review.googlesource.com/1053760 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557555} [modify] https://crrev.com/035c0c8f116fe792a3052e44cefdd99409ee8283/DEPS
,
May 10 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/8aa0dca395d49b136ab59f6e96c4446342c9ebd2 commit 8aa0dca395d49b136ab59f6e96c4446342c9ebd2 Author: Adrienne Walker <enne@chromium.org> Date: Thu May 10 17:00:25 2018 Driver bug workaround: disable_discard_framebuffer Bug: chromium: 829614 Change-Id: I285b39b31a370247518e3a0b56ac4ea54f38c0c0 Reviewed-on: https://skia-review.googlesource.com/126749 Commit-Queue: Adrienne Walker <enne@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/8aa0dca395d49b136ab59f6e96c4446342c9ebd2/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/8aa0dca395d49b136ab59f6e96c4446342c9ebd2/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/8aa0dca395d49b136ab59f6e96c4446342c9ebd2/src/gpu/gl/GrGLCaps.cpp
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b2722307920997a657fbd5472c10f3d27409b07 commit 4b2722307920997a657fbd5472c10f3d27409b07 Author: Robert Phillips <robertphillips@google.com> Date: Thu May 10 17:20:45 2018 Revert "Roll src/third_party/skia/ d31b2f674..2d46a0092 (9 commits)" This reverts commit 035c0c8f116fe792a3052e44cefdd99409ee8283. Reason for revert: compile failures Original change's description: > Roll src/third_party/skia/ d31b2f674..2d46a0092 (9 commits) > > https://skia.googlesource.com/skia.git/+log/d31b2f674acc..2d46a0092661 > > $ git log d31b2f674..2d46a0092 --date=short --no-merges --format='%ad %ae %s' > 2018-05-10 reed allow divide by zero > 2018-05-10 fmalita Validate readByteArrayAsData size > 2018-05-07 enne Add driver bug workarounds to GrCaps > 2018-05-03 egdaniel Remove GrBackendObject and all related functions from Skia. > 2018-05-10 fmalita Validate gradient DescriptorScope size during deserialization > 2018-05-10 bsalomon Revert "Revert "Don't use GrRRectBlurEffect for large rects when highp is not full float"" > 2018-05-03 egdaniel Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter. > 2018-05-09 bungeman Add all SkPaint::Flags to Viewer app. > 2018-05-09 robertphillips Fix clipping of SkMatrixImageFilter input (take 2) > > Created with: > roll-dep src/third_party/skia > BUG=chromium: 829614 > > > The AutoRoll server is located here: https://autoroll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=egdaniel@chromium.org > > Change-Id: I88cde5822b6f84857587f5a06861489d9eae6dbc > Reviewed-on: https://chromium-review.googlesource.com/1053760 > Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#557555} TBR=egdaniel@chromium.org,skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Change-Id: I8f3ada64dc671959da55bc34763a706bcd7cf86d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium: 829614 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1054048 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#557565} [modify] https://crrev.com/4b2722307920997a657fbd5472c10f3d27409b07/DEPS
,
May 10 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/0b1e628835309e09412ebe4b60b0d2b66a8290e1 commit 0b1e628835309e09412ebe4b60b0d2b66a8290e1 Author: Greg Daniel <egdaniel@google.com> Date: Thu May 10 17:24:56 2018 Revert "Driver bug workaround: disable_discard_framebuffer" This reverts commit 8aa0dca395d49b136ab59f6e96c4446342c9ebd2. Reason for revert: need to revert to revert original change breaking chrome compile Original change's description: > Driver bug workaround: disable_discard_framebuffer > > Bug: chromium: 829614 > Change-Id: I285b39b31a370247518e3a0b56ac4ea54f38c0c0 > Reviewed-on: https://skia-review.googlesource.com/126749 > Commit-Queue: Adrienne Walker <enne@chromium.org> > Commit-Queue: Brian Salomon <bsalomon@google.com> > Auto-Submit: Adrienne Walker <enne@chromium.org> > Reviewed-by: Brian Salomon <bsalomon@google.com> TBR=bsalomon@google.com,enne@chromium.org Change-Id: I563808025a8f77807478c0f0d42c3009c3b57ea5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium: 829614 Reviewed-on: https://skia-review.googlesource.com/127302 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> [modify] https://crrev.com/0b1e628835309e09412ebe4b60b0d2b66a8290e1/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/0b1e628835309e09412ebe4b60b0d2b66a8290e1/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/0b1e628835309e09412ebe4b60b0d2b66a8290e1/src/gpu/gl/GrGLCaps.cpp
,
May 10 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/636d8033229e1a70944e77470b9ed593bedf78e5 commit 636d8033229e1a70944e77470b9ed593bedf78e5 Author: Greg Daniel <egdaniel@google.com> Date: Thu May 10 17:25:26 2018 Revert "Driver bug workaround: disable_blend_equation_advanced" This reverts commit f31fece6581a46b40403fc78c83c7eebe50816ba. Reason for revert: need to revert to revert original change breaking chrome compile Original change's description: > Driver bug workaround: disable_blend_equation_advanced > > Bug: chromium: 829614 > Change-Id: If8eaec6d22412ec36aad8a143f84080be05f2926 > Reviewed-on: https://skia-review.googlesource.com/126748 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Adrienne Walker <enne@chromium.org> TBR=bsalomon@google.com,enne@chromium.org Change-Id: Ic870fbbad615d13569254c355ef6b8281332d60d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium: 829614 Reviewed-on: https://skia-review.googlesource.com/127301 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> [modify] https://crrev.com/636d8033229e1a70944e77470b9ed593bedf78e5/include/gpu/GrCaps.h [modify] https://crrev.com/636d8033229e1a70944e77470b9ed593bedf78e5/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/636d8033229e1a70944e77470b9ed593bedf78e5/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/636d8033229e1a70944e77470b9ed593bedf78e5/src/gpu/gl/GrGLCaps.cpp
,
May 10 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/024615e9752d93c842ad3cad597fd65382ddb678 commit 024615e9752d93c842ad3cad597fd65382ddb678 Author: Greg Daniel <egdaniel@google.com> Date: Thu May 10 17:30:00 2018 Revert "Add driver bug workarounds to GrCaps" This reverts commit 328490c6a1625ce51d0e81688e0c85c79c400d86. Reason for revert: Breaking compiles inside chrome Original change's description: > Add driver bug workarounds to GrCaps > > This moves GrDriverBugWorkarounds to include so that it can be included > by GrCaps. This also makes GrContextOptions a nearly empty class in > the case of !SK_SUPPORT_GPU so that non-gpu builds don't need to build > in GrDriverBugWorkarounds.cpp. > > Bug: chromium: 829614 > Change-Id: Iedf73677fd09e9a487cfe618a696fd4b25c8703d > Reviewed-on: https://skia-review.googlesource.com/126581 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Adrienne Walker <enne@chromium.org> TBR=bsalomon@google.com,enne@chromium.org Change-Id: I3b35bf65a7b78d2fe16d7c2bcd0e4b3f9bb7fdff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium: 829614 Reviewed-on: https://skia-review.googlesource.com/127303 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> [modify] https://crrev.com/024615e9752d93c842ad3cad597fd65382ddb678/dm/DMSrcSink.cpp [modify] https://crrev.com/024615e9752d93c842ad3cad597fd65382ddb678/include/gpu/GrCaps.h [modify] https://crrev.com/024615e9752d93c842ad3cad597fd65382ddb678/BUILD.gn [rename] https://crrev.com/024615e9752d93c842ad3cad597fd65382ddb678/src/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/024615e9752d93c842ad3cad597fd65382ddb678/gn/gpu.gni [modify] https://crrev.com/024615e9752d93c842ad3cad597fd65382ddb678/src/gpu/GrDriverBugWorkarounds.cpp [modify] https://crrev.com/024615e9752d93c842ad3cad597fd65382ddb678/include/gpu/GrContextOptions.h [rename] https://crrev.com/024615e9752d93c842ad3cad597fd65382ddb678/src/gpu/GrDriverBugWorkarounds.h [modify] https://crrev.com/024615e9752d93c842ad3cad597fd65382ddb678/src/gpu/GrCaps.cpp
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90e1b8beea0150dccf0bd906d39a13b241717cc6 commit 90e1b8beea0150dccf0bd906d39a13b241717cc6 Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu May 10 20:01:42 2018 Roll src/third_party/skia/ d31b2f674..024615e97 (20 commits) https://skia.googlesource.com/skia.git/+log/d31b2f674acc..024615e9752d $ git log d31b2f674..024615e97 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 egdaniel Revert "Add driver bug workarounds to GrCaps" 2018-05-10 egdaniel Revert "Driver bug workaround: disable_blend_equation_advanced" 2018-05-10 egdaniel Revert "Driver bug workaround: disable_discard_framebuffer" 2018-05-10 fmalita [skottie] Clean up AttachLayerContext 2018-05-10 enne Driver bug workaround: disable_discard_framebuffer 2018-05-10 mtklein rm SkColorSpace_New 2018-05-10 angle-skia-autoroll Roll third_party/externals/angle2/ a932b6b51..6110763fe (1 commit) 2018-05-08 enne Driver bug workaround: disable_blend_equation_advanced 2018-05-09 benjaminwagner Switch machine-type for Coverage tasks. 2018-05-10 reed use 64bit math in TArray realloc 2018-05-10 fmalita [skottie] Allow divide-by-zero in PolyStarAdapter::apply 2018-05-10 reed allow divide by zero 2018-05-10 fmalita Validate readByteArrayAsData size 2018-05-07 enne Add driver bug workarounds to GrCaps 2018-05-03 egdaniel Remove GrBackendObject and all related functions from Skia. 2018-05-10 fmalita Validate gradient DescriptorScope size during deserialization 2018-05-10 bsalomon Revert "Revert "Don't use GrRRectBlurEffect for large rects when highp is not full float"" 2018-05-03 egdaniel Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter. 2018-05-09 bungeman Add all SkPaint::Flags to Viewer app. 2018-05-09 robertphillips Fix clipping of SkMatrixImageFilter input (take 2) Created with: roll-dep src/third_party/skia BUG=chromium: 829614,chromium: 829614,chromium: 829614,chromium: 829614,chromium: 829614,chromium: 829614 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I10d8ab894715912522758a757c4aa084f63e49e9 Reviewed-on: https://chromium-review.googlesource.com/1054215 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557639} [modify] https://crrev.com/90e1b8beea0150dccf0bd906d39a13b241717cc6/DEPS
,
May 14 2018
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4576d44eadc3e3729a8a6ad26a16a2932ef538b commit d4576d44eadc3e3729a8a6ad26a16a2932ef538b Author: Adrienne Walker <enne@chromium.org> Date: Mon May 14 22:14:45 2018 skia: fix workaround include for core_and_effects This source set also needs to have the workaround built in Chrome for this to work. This should fix the compile error that caused https://skia-review.googlesource.com/c/skia/+/126581 to be reverted. Bug: 829614 Change-Id: I5226c74ea0b458a9ddb12fba560ad05a3077c09a Reviewed-on: https://chromium-review.googlesource.com/1058145 Reviewed-by: Brian Salomon <bsalomon@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#558488} [modify] https://crrev.com/d4576d44eadc3e3729a8a6ad26a16a2932ef538b/skia/BUILD.gn
,
May 14 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/ab7181daad5dae205b8dbd9de318aa3438a1cabf commit ab7181daad5dae205b8dbd9de318aa3438a1cabf Author: Adrienne Walker <enne@chromium.org> Date: Mon May 14 23:46:49 2018 Reland "Add driver bug workarounds to GrCaps" This is a reland of 328490c6a1625ce51d0e81688e0c85c79c400d86 Original change's description: > Add driver bug workarounds to GrCaps > > This moves GrDriverBugWorkarounds to include so that it can be included > by GrCaps. This also makes GrContextOptions a nearly empty class in > the case of !SK_SUPPORT_GPU so that non-gpu builds don't need to build > in GrDriverBugWorkarounds.cpp. > > Bug: chromium: 829614 > Change-Id: Iedf73677fd09e9a487cfe618a696fd4b25c8703d > Reviewed-on: https://skia-review.googlesource.com/126581 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Adrienne Walker <enne@chromium.org> Bug: chromium: 829614 Change-Id: I7b539f99caa3032c8c595dd5068dc3b179747ccd Reviewed-on: https://skia-review.googlesource.com/127304 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/ab7181daad5dae205b8dbd9de318aa3438a1cabf/dm/DMSrcSink.cpp [rename] https://crrev.com/ab7181daad5dae205b8dbd9de318aa3438a1cabf/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/ab7181daad5dae205b8dbd9de318aa3438a1cabf/BUILD.gn [rename] https://crrev.com/ab7181daad5dae205b8dbd9de318aa3438a1cabf/include/gpu/GrDriverBugWorkarounds.h [modify] https://crrev.com/ab7181daad5dae205b8dbd9de318aa3438a1cabf/gn/gpu.gni [modify] https://crrev.com/ab7181daad5dae205b8dbd9de318aa3438a1cabf/src/gpu/GrDriverBugWorkarounds.cpp [modify] https://crrev.com/ab7181daad5dae205b8dbd9de318aa3438a1cabf/include/gpu/GrContextOptions.h [modify] https://crrev.com/ab7181daad5dae205b8dbd9de318aa3438a1cabf/src/gpu/GrCaps.h [modify] https://crrev.com/ab7181daad5dae205b8dbd9de318aa3438a1cabf/src/gpu/GrCaps.cpp
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94d597b4cb48b328d3cece1b9bed0184ef8f055f commit 94d597b4cb48b328d3cece1b9bed0184ef8f055f Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue May 15 01:37:02 2018 Roll src/third_party/skia/ 4c3cb3767..ab7181daa (19 commits) https://skia.googlesource.com/skia.git/+log/4c3cb3767f5a..ab7181daad5d $ git log 4c3cb3767..ab7181daa --date=short --no-merges --format='%ad %ae %s' 2018-05-14 enne Reland "Add driver bug workarounds to GrCaps" 2018-05-14 fmalita [skottie] Sanitize polystar point counts 2018-05-14 reed handle huge normalize requests (including non-finite x or y) 2018-05-14 bsalomon Make drawBitmap[Rect]() use GrTextureOp 2018-05-14 herb Centralize UTFN code point counting 2018-05-14 reed share impl for setlength 2018-05-14 mtklein asan_device_setup has moved 2018-05-14 bsalomon Clear temp buffer in GrContextPriv::readSurfacePixels2 2018-05-14 bungeman Move SkFontConfigInterface to smart pointers. 2018-05-14 mtklein update to NDK r17 2018-05-14 liyuqian Avoid dividing by zero in SkTwoPointConicalGradient::Create 2018-05-14 reed Revert "Revert "implement SkScalar versions in terms of float versions"" 2018-05-14 borenet [recipes] Separate build and test flavors 2018-05-14 benjaminwagner [infra] Switch back to 16-core GCE VMs for Perf and Test. 2018-05-14 bungeman Correctly handle empty outer blurs. 2018-05-14 reed Revert "implement SkScalar versions in terms of float versions" 2018-05-14 jvanverth Merge duplicate umbra points in spot shadow. 2018-05-14 angle-skia-autoroll Roll third_party/externals/angle2/ 66aafcb46..5d2ccc534 (1 commit) 2018-05-11 bungeman Don't set luminance color if not used in MakeRecAndEffects. Created with: roll-dep src/third_party/skia BUG=chromium: 829614 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I701ebf2faef0c604ecbfd8843b6fa3200ed0fe8d Reviewed-on: https://chromium-review.googlesource.com/1058602 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558576} [modify] https://crrev.com/94d597b4cb48b328d3cece1b9bed0184ef8f055f/DEPS
,
May 15 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/683148419e88eb1e39d543688b0c531814e287ee commit 683148419e88eb1e39d543688b0c531814e287ee Author: Adrienne Walker <enne@chromium.org> Date: Tue May 15 18:09:43 2018 Reland "Driver bug workaround: disable_blend_equation_advanced" This is a reland of f31fece6581a46b40403fc78c83c7eebe50816ba Original change's description: > Driver bug workaround: disable_blend_equation_advanced > > Bug: chromium: 829614 > Change-Id: If8eaec6d22412ec36aad8a143f84080be05f2926 > Reviewed-on: https://skia-review.googlesource.com/126748 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Adrienne Walker <enne@chromium.org> Bug: chromium: 829614 Change-Id: Idd36ff90a99336521ef5d47f0d7baf079c1bda09 Reviewed-on: https://skia-review.googlesource.com/128107 Commit-Queue: Adrienne Walker <enne@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/683148419e88eb1e39d543688b0c531814e287ee/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/683148419e88eb1e39d543688b0c531814e287ee/src/gpu/GrCaps.h [modify] https://crrev.com/683148419e88eb1e39d543688b0c531814e287ee/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/683148419e88eb1e39d543688b0c531814e287ee/src/gpu/gl/GrGLCaps.cpp
,
May 15 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/0e38394ffc341478b4385b9a85be02098abd0603 commit 0e38394ffc341478b4385b9a85be02098abd0603 Author: Adrienne Walker <enne@chromium.org> Date: Tue May 15 18:58:23 2018 Reland "Driver bug workaround: disable_discard_framebuffer" This is a reland of f31fece6581a46b40403fc78c83c7eebe50816ba Original change's description: > Driver bug workaround: disable_discard_framebuffer > > Bug: chromium: 829614 > Change-Id: I285b39b31a370247518e3a0b56ac4ea54f38c0c0 > Reviewed-on: https://skia-review.googlesource.com/126749 > Commit-Queue: Adrienne Walker <enne@chromium.org> > Commit-Queue: Brian Salomon <bsalomon@google.com> > Auto-Submit: Adrienne Walker <enne@chromium.org> > Reviewed-by: Brian Salomon <bsalomon@google.com> Bug: chromium: 829614 Change-Id: I6cc2de11a6315ff224c90551e8dd3e1d1dd4139a Reviewed-on: https://skia-review.googlesource.com/128108 Commit-Queue: Adrienne Walker <enne@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/0e38394ffc341478b4385b9a85be02098abd0603/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/0e38394ffc341478b4385b9a85be02098abd0603/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/0e38394ffc341478b4385b9a85be02098abd0603/src/gpu/gl/GrGLCaps.cpp
,
May 15 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/724afe8b2da2cd32394921096d5c738519b5a51e commit 724afe8b2da2cd32394921096d5c738519b5a51e Author: Adrienne Walker <enne@chromium.org> Date: Tue May 15 19:56:23 2018 Driver bug workaround: max_texture_size_limit_4096 Bug: chromium: 829614 Change-Id: I127157fa04df2ec6505411aa42f1232910e251d4 Reviewed-on: https://skia-review.googlesource.com/126608 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/724afe8b2da2cd32394921096d5c738519b5a51e/src/gpu/vk/GrVkCaps.cpp [modify] https://crrev.com/724afe8b2da2cd32394921096d5c738519b5a51e/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/724afe8b2da2cd32394921096d5c738519b5a51e/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/724afe8b2da2cd32394921096d5c738519b5a51e/src/gpu/gl/GrGLCaps.cpp
,
May 15 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/001cae07d386038a5602663e1ce149cc51c6ebe9 commit 001cae07d386038a5602663e1ce149cc51c6ebe9 Author: Adrienne Walker <enne@chromium.org> Date: Tue May 15 22:06:43 2018 Driver bug workaround: disallow_large_instanced_draw Bug: chromium: 829614 Change-Id: I3c64cd360674f08b4ca3c4a2d0ef946e40a5c60a Reviewed-on: https://skia-review.googlesource.com/126751 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Chris Dalton <csmartdalton@google.com> [modify] https://crrev.com/001cae07d386038a5602663e1ce149cc51c6ebe9/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/001cae07d386038a5602663e1ce149cc51c6ebe9/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/001cae07d386038a5602663e1ce149cc51c6ebe9/src/gpu/gl/GrGLCaps.cpp
,
May 15 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/d7c7978d8c231894e8437e05db9ecd10f4b77c01 commit d7c7978d8c231894e8437e05db9ecd10f4b77c01 Author: Adrienne Walker <enne@chromium.org> Date: Tue May 15 22:10:43 2018 Driver bug workaround: max_msaa_sample_count_4 Bug: chromium: 829614 Change-Id: I54054191815ace6159585dab7dd811ebdc863095 Reviewed-on: https://skia-review.googlesource.com/126983 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/d7c7978d8c231894e8437e05db9ecd10f4b77c01/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/d7c7978d8c231894e8437e05db9ecd10f4b77c01/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/d7c7978d8c231894e8437e05db9ecd10f4b77c01/src/gpu/gl/GrGLCaps.cpp
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c90af86063f80e46bf3104469c2999f21cc15551 commit c90af86063f80e46bf3104469c2999f21cc15551 Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed May 16 02:50:45 2018 Roll src/third_party/skia/ 81f60ecd9..5b8b472b3 (27 commits) https://skia.googlesource.com/skia.git/+log/81f60ecd9cc0..5b8b472b3373 $ git log 81f60ecd9..5b8b472b3 --date=short --no-merges --format='%ad %ae %s' 2018-05-15 liyuqian Revert "Check atlasPageCount before accessing the proxy array" 2018-05-15 khushalsagar fonts: Fix memory accounting for deserialized glyphs. 2018-05-15 jcgregorio [docker] Add Dockerfile that builds skiaserve. 2018-05-15 enne Driver bug workaround: max_msaa_sample_count_4 2018-05-15 enne Driver bug workaround: disallow_large_instanced_draw 2018-05-15 caryclark remove typedef Info 2018-05-15 csmartdalton Add a vknostencils config 2018-05-15 skcms-skia-autoroll Roll skia/third_party/skcms 14c31bf..ce2fabc (1 commits) 2018-05-15 csmartdalton Check atlasPageCount before accessing the proxy array 2018-05-15 fmalita Scrub SkPictureData/SkPictureRecord 2018-05-15 enne Driver bug workaround: max_texture_size_limit_4096 2018-05-15 mtklein remove unused SkColorSpace::Make 2018-05-15 benjaminwagner Run only canonical configs for 32-bit Test tasks. 2018-05-15 bungeman Remove non-smart SkFontConfigInterface::SetGlobal. 2018-05-15 borenet [recipes] BUILDTYPE and SKIA_OUT are no longer used 2018-05-15 rmistry Add chromium first to .gclient 2018-05-15 bungeman Revert "Remove non-smart SkFontConfigInterface::SetGlobal." 2018-05-15 bungeman Remove non-smart SkFontConfigInterface::SetGlobal. 2018-05-15 enne Reland "Driver bug workaround: disable_discard_framebuffer" 2018-05-14 enne Reland "Driver bug workaround: disable_blend_equation_advanced" 2018-05-15 angle-skia-autoroll Roll third_party/externals/angle2/ 74a763205..2a849bf31 (10 commits) 2018-05-15 kjlubick Add preflight checks for SkImage deserialization 2018-05-15 mtklein switch skia to use skcms.gni 2018-05-15 brianosman Roll third_party/externals/angle2/ 5d2ccc534..a00ef3144 (10 commits) 2018-05-15 bungeman Mark SkFontMgr_FCI methods as not implmented. 2018-05-15 skcms-skia-autoroll Roll skia/third_party/skcms 28e8b32..14c31bf (6 commits) 2018-05-14 bungeman SkSharedMutex::acquire to check thread state. Created with: roll-dep src/third_party/skia BUG= chromium:829622 ,chromium: 829614,chromium: 829614,chromium: 829614,chromium: 829614,chromium: 829614 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I5a7325acbeb0907d22e4ad901f2804db4d202cb1 Reviewed-on: https://chromium-review.googlesource.com/1060592 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558939} [modify] https://crrev.com/c90af86063f80e46bf3104469c2999f21cc15551/DEPS
,
May 16 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/3ed3399a932c8906d4c4a7fd1ef108ced30141d4 commit 3ed3399a932c8906d4c4a7fd1ef108ced30141d4 Author: Adrienne Walker <enne@chromium.org> Date: Wed May 16 18:19:52 2018 Driver bug workaround: restore_scissor_on_fbo_change Bug: chromium: 829614 Change-Id: I333aed9a378ab9b7aafaa96bb495378d1db4a61d Reviewed-on: https://skia-review.googlesource.com/127118 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/3ed3399a932c8906d4c4a7fd1ef108ced30141d4/src/gpu/gl/GrGLGpu.cpp [modify] https://crrev.com/3ed3399a932c8906d4c4a7fd1ef108ced30141d4/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/3ed3399a932c8906d4c4a7fd1ef108ced30141d4/src/gpu/gl/GrGLGpu.h [modify] https://crrev.com/3ed3399a932c8906d4c4a7fd1ef108ced30141d4/src/gpu/gl/GrGLRenderTarget.cpp [modify] https://crrev.com/3ed3399a932c8906d4c4a7fd1ef108ced30141d4/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/3ed3399a932c8906d4c4a7fd1ef108ced30141d4/src/gpu/GrCaps.h
,
May 16 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/94f585ed091e252cd3cc741b19c8a226fe4a5eec commit 94f585ed091e252cd3cc741b19c8a226fe4a5eec Author: Adrienne Walker <enne@chromium.org> Date: Wed May 16 18:31:22 2018 Driver bug workaround: gl_clear_broken Skia does not appear to use depth buffers and this appears to be identical to ClearFramebufferResourceManager::ClearFramebuffer in Chromium code. Therefore, just hook up this workaround to turn on these internal Skia workarounds. Bug: chromium: 829614 Change-Id: Icc5f2eb981e39ffef487efa16940d2e50cdbc399 Reviewed-on: https://skia-review.googlesource.com/127220 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org> [modify] https://crrev.com/94f585ed091e252cd3cc741b19c8a226fe4a5eec/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/94f585ed091e252cd3cc741b19c8a226fe4a5eec/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/94f585ed091e252cd3cc741b19c8a226fe4a5eec/src/gpu/gl/GrGLCaps.cpp
,
May 16 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/c48f776682f8d208dd2ede7deb233cf72b840251 commit c48f776682f8d208dd2ede7deb233cf72b840251 Author: Adrienne Walker <enne@chromium.org> Date: Wed May 16 19:45:42 2018 Driver bug workaround: pack_parameters_workaround_with_pack_buffer Bug: chromium: 829614 Change-Id: I3fae2b4181e4a6e37fb31fe2f2e9a6cfacb1860f Reviewed-on: https://skia-review.googlesource.com/128206 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/c48f776682f8d208dd2ede7deb233cf72b840251/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/c48f776682f8d208dd2ede7deb233cf72b840251/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/c48f776682f8d208dd2ede7deb233cf72b840251/src/gpu/gl/GrGLCaps.cpp
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/884da2e9b86220296b2223bd453d7f558fa964ba commit 884da2e9b86220296b2223bd453d7f558fa964ba Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu May 17 02:51:31 2018 Roll src/third_party/skia/ d6b41a276..05da1c16d (15 commits; 1 trivial rolls) https://skia.googlesource.com/skia.git/+log/d6b41a27678f..05da1c16dfb4 $ git log d6b41a276..05da1c16d --date=short --no-merges --format='%ad %ae %s' 2018-05-16 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ c8403ec14..89c43d202 (1 commit) 2018-05-16 angle-skia-autoroll Roll third_party/externals/angle2/ 80c32ccbb..f299a378f (6 commits) 2018-05-16 brianosman Suppress bad-function-cast warning 2018-05-15 enne Driver bug workaround: pack_parameters_workaround_with_pack_buffer 2018-05-16 jvanverth Fix check for valid proxies returned by AtlasManager. 2018-05-16 skcms-skia-autoroll Roll skia/third_party/skcms a7e79c5..5cc905d (1 commits) 2018-05-16 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ 596f653f5..c8403ec14 (1 commit) 2018-05-15 bungeman SkImage::onRefEncoded to return sk_sp. 2018-05-15 enne Driver bug workaround: gl_clear_broken 2018-05-16 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ e475674ef..596f653f5 (1 commit) 2018-05-15 enne Driver bug workaround: restore_scissor_on_fbo_change 2018-05-16 kjlubick Remove problematic pre-allocations when deserializing 2018-05-16 herb Fix compiler warning for MSVC 2018-05-16 skcms-skia-autoroll Roll skia/third_party/skcms e040063..a7e79c5 (2 commits) Created with: roll-dep src/third_party/skia BUG=chromium: 829614,chromium: 829614,chromium: 829614 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: Ic77fdbcc06c7d4ce7c8354c041e9997d3be8bb76 Reviewed-on: https://chromium-review.googlesource.com/1063112 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559404} [modify] https://crrev.com/884da2e9b86220296b2223bd453d7f558fa964ba/DEPS
,
May 18 2018
The following revision refers to this bug: https://skia.googlesource.com/skia/+/4ee88511bc04dcfb66c4c58d3b600f329bedb44e commit 4ee88511bc04dcfb66c4c58d3b600f329bedb44e Author: Adrienne Walker <enne@chromium.org> Date: Fri May 18 17:26:14 2018 Driver bug workaround: unbind_attachments_on_bound_render_fbo_delete Bug: chromium: 829614 Change-Id: Ic6bc276d1203d24f96fe92b41655871e25f69623 Reviewed-on: https://skia-review.googlesource.com/128395 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org> [modify] https://crrev.com/4ee88511bc04dcfb66c4c58d3b600f329bedb44e/src/gpu/gl/GrGLGpu.h [modify] https://crrev.com/4ee88511bc04dcfb66c4c58d3b600f329bedb44e/src/gpu/gl/GrGLGpu.cpp [modify] https://crrev.com/4ee88511bc04dcfb66c4c58d3b600f329bedb44e/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/4ee88511bc04dcfb66c4c58d3b600f329bedb44e/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/4ee88511bc04dcfb66c4c58d3b600f329bedb44e/src/gpu/gl/GrGLRenderTarget.cpp
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/873755a87af77e54620712d4b14c3a4710c1f37f commit 873755a87af77e54620712d4b14c3a4710c1f37f Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 18 19:50:06 2018 Roll src/third_party/skia/ 255ab8d9a..ec79c39a7 (9 commits) https://skia.googlesource.com/skia.git/+log/255ab8d9a55d..ec79c39a7702 $ git log 255ab8d9a..ec79c39a7 --date=short --no-merges --format='%ad %ae %s' 2018-05-18 senorblanco GrTessellator: fix for zombie edge fuzzer crash. 2017-08-14 bungeman Add BOOK and DEMI_LIGHT. 2018-05-17 enne Driver bug workaround: unbind_attachments_on_bound_render_fbo_delete 2018-05-18 kjlubick Prevent SkMatrixConvolutionImageFilter from allocating large buffers it can't fill 2018-05-18 reed validate perlin inputs 2018-05-18 caryclark fix bookmaker typo 2018-05-18 angle-skia-autoroll Roll third_party/externals/angle2/ 4607148c6..8688bf46f (1 commit) 2018-05-18 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ 607771b44..cbb80f5f0 (1 commit) 2018-05-18 bsalomon Modifications to GrTextureOp outsetting, edge equation code. Created with: roll-dep src/third_party/skia BUG=chromium: 829614 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: Iab2699a2613d085cf1570385fe32fe93cfb67c1a Reviewed-on: https://chromium-review.googlesource.com/1066394 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559998} [modify] https://crrev.com/873755a87af77e54620712d4b14c3a4710c1f37f/DEPS
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b664cd6e35a190fb24893cb5847ef9b169c49275 commit b664cd6e35a190fb24893cb5847ef9b169c49275 Author: Adrienne Walker <enne@chromium.org> Date: Mon May 21 21:51:10 2018 gpu: Set Skia workarounds from Chrome workarounds Bug: 829614 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia776792f78d23d2d9536de200de7135e1c4fee9a Reviewed-on: https://chromium-review.googlesource.com/1067515 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#560352} [modify] https://crrev.com/b664cd6e35a190fb24893cb5847ef9b169c49275/gpu/command_buffer/service/raster_decoder.cc [modify] https://crrev.com/b664cd6e35a190fb24893cb5847ef9b169c49275/gpu/config/gpu_driver_bug_workarounds.cc [modify] https://crrev.com/b664cd6e35a190fb24893cb5847ef9b169c49275/gpu/config/gpu_driver_bug_workarounds.h
,
Jun 19 2018
Is there anything remaining on this?
,
Jun 19 2018
Yeah, these are implemented for Android, but not implemented for other platforms yet. https://docs.google.com/spreadsheets/d/1dwy4-HrBgXFaQFAq5FyfpjGhLZ94KAvB-uNXYoaDjbE/edit has the list of what's been completed and what hasn't.
,
Aug 9
The following revision refers to this bug: https://skia.googlesource.com/skia/+/87785d5573d7262c58ee2af40bbd82d5a3d70784 commit 87785d5573d7262c58ee2af40bbd82d5a3d70784 Author: Adrienne Walker <enne@chromium.org> Date: Thu Aug 09 21:13:16 2018 Add max_fragment_uniform_vectors_32 workaround Bug: chromium: 829614 Change-Id: I0ce008d8ebadd90758510ea069f0f4384a95751e Reviewed-on: https://skia-review.googlesource.com/146622 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org> [modify] https://crrev.com/87785d5573d7262c58ee2af40bbd82d5a3d70784/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/87785d5573d7262c58ee2af40bbd82d5a3d70784/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/87785d5573d7262c58ee2af40bbd82d5a3d70784/src/gpu/gl/GrGLCaps.cpp
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61c7343757f0d6de3b10a888849697930dd7c182 commit 61c7343757f0d6de3b10a888849697930dd7c182 Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Aug 10 02:12:16 2018 Roll src/third_party/skia 644d8e7175ae..bc6f9c9a8c6b (12 commits) https://skia.googlesource.com/skia.git/+log/644d8e7175ae..bc6f9c9a8c6b git log 644d8e7175ae..bc6f9c9a8c6b --date=short --no-merges --format='%ad %ae %s' 2018-08-09 herb@google.com Remove GrTextUtil::Paint 2018-08-09 fmalita@chromium.org [skottie] Avoid UB while parsing 1-based indices 2018-08-09 mtklein@google.com in MS land, -include is /FI 2018-08-09 timliang@google.com Reland "implemented GrMtlSampler for metal gpu backend" 2018-08-09 enne@chromium.org Add max_fragment_uniform_vectors_32 workaround 2018-08-09 mtklein@google.com turn on alignment sanitizer 2018-08-09 ethannicholas@google.com fixed early return breaking things in .fp files 2018-08-09 brianosman@google.com Allow any color space when making a picture backed image 2018-08-09 fmalita@chromium.org [skottie] Optimize color filter layerization 2018-08-09 bungeman@google.com Viewer to resize Samples with window resize. 2018-08-09 herb@google.com Remove RunPaint 2018-08-09 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 c43cdad25851..468484201532 (1 commits) Created with: gclient setdep -r src/third_party/skia@bc6f9c9a8c6b The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:864564,chromium: 829614 TBR=djsollen@chromium.org Change-Id: I71da299909970ffe5f2ac7fde0bb6d761e7d1abe Reviewed-on: https://chromium-review.googlesource.com/1169667 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#582016} [modify] https://crrev.com/61c7343757f0d6de3b10a888849697930dd7c182/DEPS
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa0603bbbdbe385af7d7a4654fa8ef1796b262a0 commit fa0603bbbdbe385af7d7a4654fa8ef1796b262a0 Author: Adrienne Walker <enne@chromium.org> Date: Fri Aug 10 22:04:15 2018 Handle avoid_stencil_buffers workaround in OOP-R This could be handled in Skia, but there's already a context option for it, so just forward the workaround setting to that. Bug: 829614 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iaeb625ea327b814d07854dd81eb0458598a0c137 Reviewed-on: https://chromium-review.googlesource.com/1169771 Commit-Queue: enne <enne@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#582353} [modify] https://crrev.com/fa0603bbbdbe385af7d7a4654fa8ef1796b262a0/gpu/command_buffer/service/raster_decoder_context_state.cc
,
Aug 21
The following revision refers to this bug: https://skia.googlesource.com/skia/+/ca0cdef0634904d7be54cd990fddb69fc41881ad commit ca0cdef0634904d7be54cd990fddb69fc41881ad Author: Adrienne Walker <enne@chromium.org> Date: Tue Aug 21 01:10:52 2018 Add flush_on_framebuffer_change workaround Bug: chromium: 829614 Change-Id: Ibd7ebfd74d95e3119f01a3d6ae40a693368ac3de Reviewed-on: https://skia-review.googlesource.com/147128 Auto-Submit: Adrienne Walker <enne@chromium.org> Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/ca0cdef0634904d7be54cd990fddb69fc41881ad/src/gpu/gl/GrGLGpu.h [modify] https://crrev.com/ca0cdef0634904d7be54cd990fddb69fc41881ad/src/gpu/gl/GrGLGpu.cpp [modify] https://crrev.com/ca0cdef0634904d7be54cd990fddb69fc41881ad/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/ca0cdef0634904d7be54cd990fddb69fc41881ad/include/gpu/GrDriverBugWorkaroundsAutogen.h
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/265ebe487012785f0264260bee26658c9bb46c4c commit 265ebe487012785f0264260bee26658c9bb46c4c Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Aug 21 03:23:08 2018 Roll src/third_party/skia 8d744124a6f8..ca0cdef06349 (10 commits) https://skia.googlesource.com/skia.git/+log/8d744124a6f8..ca0cdef06349 git log 8d744124a6f8..ca0cdef06349 --date=short --no-merges --format='%ad %ae %s' 2018-08-21 enne@chromium.org Add flush_on_framebuffer_change workaround 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 f26b27e29535..d20e80b840e4 (1 commits) 2018-08-20 bungeman@google.com Improve name table handling. 2018-08-20 csmartdalton@google.com ccpr: Rename GrCCPathParser to GrCCFiller 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 robertphillips@google.com Remove occluded rrect blur benchmark 2018-08-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-20 robertphillips@google.com Change drawPathWithMaskFilter to drawShapeWithMaskFilter Created with: gclient setdep -r src/third_party/skia@ca0cdef06349 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium: 829614 TBR=fmalita@chromium.org Change-Id: I53a902631a3e1f5d1048232bc64016304574109b Reviewed-on: https://chromium-review.googlesource.com/1182682 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584631} [modify] https://crrev.com/265ebe487012785f0264260bee26658c9bb46c4c/DEPS
,
Aug 21
The following revision refers to this bug: https://skia.googlesource.com/skia/+/ee8295c050704390d538f0090b5af60098630db9 commit ee8295c050704390d538f0090b5af60098630db9 Author: Adrienne Walker <enne@chromium.org> Date: Tue Aug 21 20:03:50 2018 Add add_and_true_to_loop_condition workaround See https://bugs.chromium.org/p/chromium/issues/detail?id=644669#c4 for what this is doing and trying to work around. Bug: chromium: 644669, 829614 Change-Id: I5616eb6f7299c30e5bdf812e55099ac0a8fc9c1d Reviewed-on: https://skia-review.googlesource.com/146856 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org> [modify] https://crrev.com/ee8295c050704390d538f0090b5af60098630db9/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/ee8295c050704390d538f0090b5af60098630db9/src/gpu/GrShaderCaps.h [modify] https://crrev.com/ee8295c050704390d538f0090b5af60098630db9/tests/SkSLGLSLTest.cpp [modify] https://crrev.com/ee8295c050704390d538f0090b5af60098630db9/src/gpu/gl/GrGLCaps.cpp [modify] https://crrev.com/ee8295c050704390d538f0090b5af60098630db9/src/gpu/GrShaderCaps.cpp [modify] https://crrev.com/ee8295c050704390d538f0090b5af60098630db9/src/sksl/SkSLUtil.h [modify] https://crrev.com/ee8295c050704390d538f0090b5af60098630db9/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/ee8295c050704390d538f0090b5af60098630db9/src/sksl/SkSLGLSLCodeGenerator.cpp
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c5f556a079770fe90ebfdd576cb2f1d3fbc3a29 commit 5c5f556a079770fe90ebfdd576cb2f1d3fbc3a29 Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Aug 22 16:51:17 2018 Roll src/third_party/skia ea60b951d735..e6ab998bc2e6 (21 commits) https://skia.googlesource.com/skia.git/+log/ea60b951d735..e6ab998bc2e6 git log ea60b951d735..e6ab998bc2e6 --date=short --no-merges --format='%ad %ae %s' 2018-08-22 egdaniel@google.com Revert "added support for sk_Dimensions to SkSL" 2018-08-22 nigeltao@google.com Update SkCodec::rewindIfNeeded comment 2018-08-22 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 70aeda4942f5..44ae899ae9ce (3 commits) 2018-08-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-22 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 d710fee3861a..70aeda4942f5 (5 commits) 2018-08-21 mtklein@google.com let's like, chill out about all these rules, man 2018-08-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-21 herb@google.com Rename SkGlyphRunListDrawer to SkGlyphRunListPainter 2018-08-21 enne@chromium.org Add add_and_true_to_loop_condition workaround 2018-08-21 fmalita@chromium.org [skottie] Split-up Skottie.cpp 2018-08-21 herb@google.com Use SkGlyphRun directly in SkRemoteGlyphCache 2018-08-21 robertphillips@google.com Address fuzzer issue 2018-08-21 kjlubick@google.com Update Pixels to Android P 2018-08-21 egdaniel@google.com Disable FB Fetch in metal ios 2018-08-21 fmalita@chromium.org [skottie/cleanup] Refactor parser state handling 2018-08-21 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 7a4f6b8c7d5e..d710fee3861a (2 commits) 2018-08-21 herb@google.com Check for too small rect for path 2018-08-21 ethannicholas@google.com added support for sk_Dimensions to SkSL 2018-08-21 mtklein@google.com treat opaque dsts as src alpha type 2018-08-21 bsalomon@google.com Fix op chaining painter's order violation in GrRenderTargetOpList. 2018-08-21 herb@google.com Fix possible nullptr deref Created with: gclient setdep -r src/third_party/skia@e6ab998bc2e6 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium: 644669,chromium:829614,chromium:873020,chromium:873020 TBR=fmalita@chromium.org Change-Id: I4dc802075c67741f2c6db2225eb9e6d3772cd618 Reviewed-on: https://chromium-review.googlesource.com/1185061 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585088} [modify] https://crrev.com/5c5f556a079770fe90ebfdd576cb2f1d3fbc3a29/DEPS
,
Aug 22
The following revision refers to this bug: https://skia.googlesource.com/skia/+/c02165fae11402933e23ad2bb080862220b5a1a8 commit c02165fae11402933e23ad2bb080862220b5a1a8 Author: Adrienne Walker <enne@chromium.org> Date: Wed Aug 22 16:54:26 2018 Add unfold_short_circuit_as_ternary workaround Bug: chromium: 307751,829614 Change-Id: I1fb347e5470eb2a498192f3fc467a6b744b53a79 Reviewed-on: https://skia-review.googlesource.com/147243 Reviewed-by: Ethan Nicholas <ethannicholas@google.com> Commit-Queue: Adrienne Walker <enne@chromium.org> [modify] https://crrev.com/c02165fae11402933e23ad2bb080862220b5a1a8/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/c02165fae11402933e23ad2bb080862220b5a1a8/src/gpu/GrShaderCaps.h [modify] https://crrev.com/c02165fae11402933e23ad2bb080862220b5a1a8/tests/SkSLGLSLTest.cpp [modify] https://crrev.com/c02165fae11402933e23ad2bb080862220b5a1a8/src/gpu/gl/GrGLCaps.cpp [modify] https://crrev.com/c02165fae11402933e23ad2bb080862220b5a1a8/src/gpu/GrShaderCaps.cpp [modify] https://crrev.com/c02165fae11402933e23ad2bb080862220b5a1a8/src/sksl/SkSLUtil.h [modify] https://crrev.com/c02165fae11402933e23ad2bb080862220b5a1a8/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/c02165fae11402933e23ad2bb080862220b5a1a8/src/sksl/SkSLGLSLCodeGenerator.h [modify] https://crrev.com/c02165fae11402933e23ad2bb080862220b5a1a8/src/sksl/SkSLGLSLCodeGenerator.cpp
,
Aug 22
The following revision refers to this bug: https://skia.googlesource.com/skia/+/92b161fab40fe1f90661fed6802e0cb3a1c4e1e3 commit 92b161fab40fe1f90661fed6802e0cb3a1c4e1e3 Author: Adrienne Walker <enne@chromium.org> Date: Wed Aug 22 18:25:13 2018 Add emulate_abs_int_function workaround Bug: chromium: 642227,829614 Change-Id: I23be4105041187a6501f45cd2033ac0143642aa1 Reviewed-on: https://skia-review.googlesource.com/147322 Commit-Queue: Adrienne Walker <enne@chromium.org> Auto-Submit: Adrienne Walker <enne@chromium.org> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> [modify] https://crrev.com/92b161fab40fe1f90661fed6802e0cb3a1c4e1e3/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/92b161fab40fe1f90661fed6802e0cb3a1c4e1e3/src/gpu/GrShaderCaps.h [modify] https://crrev.com/92b161fab40fe1f90661fed6802e0cb3a1c4e1e3/tests/SkSLGLSLTest.cpp [modify] https://crrev.com/92b161fab40fe1f90661fed6802e0cb3a1c4e1e3/src/gpu/gl/GrGLCaps.cpp [modify] https://crrev.com/92b161fab40fe1f90661fed6802e0cb3a1c4e1e3/src/gpu/GrShaderCaps.cpp [modify] https://crrev.com/92b161fab40fe1f90661fed6802e0cb3a1c4e1e3/src/sksl/SkSLUtil.h [modify] https://crrev.com/92b161fab40fe1f90661fed6802e0cb3a1c4e1e3/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/92b161fab40fe1f90661fed6802e0cb3a1c4e1e3/src/sksl/SkSLGLSLCodeGenerator.h [modify] https://crrev.com/92b161fab40fe1f90661fed6802e0cb3a1c4e1e3/src/sksl/SkSLGLSLCodeGenerator.cpp
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63e36b8befd0b142ea9147b7e4d4f57e875077aa commit 63e36b8befd0b142ea9147b7e4d4f57e875077aa Author: Adrienne Walker <enne@chromium.org> Date: Wed Aug 22 19:43:39 2018 Remove texsubimage_faster_than_teximage workaround This is only used for ANGLE, and geofflang suggests that this doesn't apply to ANGLE any more, as it does mostly the same thing in both cases. Bug: 829614 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I25371dcef4043edd0abbdf4e943778771246918e Reviewed-on: https://chromium-review.googlesource.com/1185283 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#585207} [modify] https://crrev.com/63e36b8befd0b142ea9147b7e4d4f57e875077aa/content/test/gpu/gpu_tests/fake_win_amd_gpu_info.py [modify] https://crrev.com/63e36b8befd0b142ea9147b7e4d4f57e875077aa/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc [modify] https://crrev.com/63e36b8befd0b142ea9147b7e4d4f57e875077aa/gpu/command_buffer/service/texture_manager.cc [modify] https://crrev.com/63e36b8befd0b142ea9147b7e4d4f57e875077aa/gpu/command_buffer/service/texture_manager.h [modify] https://crrev.com/63e36b8befd0b142ea9147b7e4d4f57e875077aa/gpu/config/gpu_driver_bug_list.json [modify] https://crrev.com/63e36b8befd0b142ea9147b7e4d4f57e875077aa/gpu/config/gpu_workaround_list.txt
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/064c4f5a3915416c8cdf45b2ac59ff9e8f275ffa commit 064c4f5a3915416c8cdf45b2ac59ff9e8f275ffa Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Aug 22 21:53:10 2018 Roll src/third_party/skia 4a0ba280b94c..92b161fab40f (8 commits) https://skia.googlesource.com/skia.git/+log/4a0ba280b94c..92b161fab40f git log 4a0ba280b94c..92b161fab40f --date=short --no-merges --format='%ad %ae %s' 2018-08-22 enne@chromium.org Add emulate_abs_int_function workaround 2018-08-22 scroggo@google.com Switch SkCodec to use skcms 2018-08-22 brianosman@google.com Remove unused sRGB mip-map support 2018-08-22 kjlubick@google.com [PathKit] Add asm.js build and test jobs 2018-08-22 benjaminwagner@google.com [infra] Remove NexusPlayer Vulkan jobs. 2018-08-22 mtklein@google.com streamline interface to GrColorSpaceXform::Make() 2018-08-22 brianosman@google.com Make SkColor4f <-> SkColor skip sRGB conversion 2018-08-22 enne@chromium.org Add unfold_short_circuit_as_ternary workaround Created with: gclient setdep -r src/third_party/skia@92b161fab40f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium: 642227,chromium:829614,chromium: 307751,chromium:829614 TBR=fmalita@chromium.org Change-Id: I6ed6e1fe370f351b38d74f862a6a79ee5eb9bf20 Reviewed-on: https://chromium-review.googlesource.com/1185501 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585266} [modify] https://crrev.com/064c4f5a3915416c8cdf45b2ac59ff9e8f275ffa/DEPS
,
Aug 22
The following revision refers to this bug: https://skia.googlesource.com/skia/+/8b23ca6406ca73bd914ea50480cd32ca95ced865 commit 8b23ca6406ca73bd914ea50480cd32ca95ced865 Author: Adrienne Walker <enne@chromium.org> Date: Wed Aug 22 22:45:52 2018 Add rewrite_do_while_loops workaround Bug: chromium: 644669, 829614 Change-Id: Ic6a4cbd9f7c73b9b9a78608f1b4ac4ce4c4f2cb9 Reviewed-on: https://skia-review.googlesource.com/148439 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> [modify] https://crrev.com/8b23ca6406ca73bd914ea50480cd32ca95ced865/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/8b23ca6406ca73bd914ea50480cd32ca95ced865/src/gpu/GrShaderCaps.h [modify] https://crrev.com/8b23ca6406ca73bd914ea50480cd32ca95ced865/tests/SkSLGLSLTest.cpp [modify] https://crrev.com/8b23ca6406ca73bd914ea50480cd32ca95ced865/src/gpu/gl/GrGLCaps.cpp [modify] https://crrev.com/8b23ca6406ca73bd914ea50480cd32ca95ced865/src/gpu/GrShaderCaps.cpp [modify] https://crrev.com/8b23ca6406ca73bd914ea50480cd32ca95ced865/src/sksl/SkSLUtil.h [modify] https://crrev.com/8b23ca6406ca73bd914ea50480cd32ca95ced865/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/8b23ca6406ca73bd914ea50480cd32ca95ced865/src/sksl/SkSLGLSLCodeGenerator.cpp
,
Aug 22
The following revision refers to this bug: https://skia.googlesource.com/skia/+/2f4c09b5cae1a7e1d5ad456bcbb4bcd063af6450 commit 2f4c09b5cae1a7e1d5ad456bcbb4bcd063af6450 Author: Adrienne Walker <enne@chromium.org> Date: Wed Aug 22 23:09:36 2018 Add remove_pow_with_constant_exponent workaround Bug: chromium: 477306, 829614 Change-Id: If88c57b15a4cfd6f362a2f5171f8e9c0775cb9d4 Reviewed-on: https://skia-review.googlesource.com/148480 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Ethan Nicholas <ethannicholas@google.com> [modify] https://crrev.com/2f4c09b5cae1a7e1d5ad456bcbb4bcd063af6450/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/2f4c09b5cae1a7e1d5ad456bcbb4bcd063af6450/src/gpu/GrShaderCaps.h [modify] https://crrev.com/2f4c09b5cae1a7e1d5ad456bcbb4bcd063af6450/tests/SkSLGLSLTest.cpp [modify] https://crrev.com/2f4c09b5cae1a7e1d5ad456bcbb4bcd063af6450/src/gpu/gl/GrGLCaps.cpp [modify] https://crrev.com/2f4c09b5cae1a7e1d5ad456bcbb4bcd063af6450/src/gpu/GrShaderCaps.cpp [modify] https://crrev.com/2f4c09b5cae1a7e1d5ad456bcbb4bcd063af6450/src/sksl/SkSLUtil.h [modify] https://crrev.com/2f4c09b5cae1a7e1d5ad456bcbb4bcd063af6450/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/2f4c09b5cae1a7e1d5ad456bcbb4bcd063af6450/src/sksl/SkSLGLSLCodeGenerator.h [modify] https://crrev.com/2f4c09b5cae1a7e1d5ad456bcbb4bcd063af6450/src/sksl/SkSLGLSLCodeGenerator.cpp
,
Aug 22
The following revision refers to this bug: https://skia.googlesource.com/skia/+/70e468f93c4f46800db248e53618e7da2eb5a528 commit 70e468f93c4f46800db248e53618e7da2eb5a528 Author: Adrienne Walker <enne@chromium.org> Date: Wed Aug 22 23:56:23 2018 Add disable_texture_storage workaround Bug: chromium: 521904, 829614 Change-Id: I808d9c80bac86cbc23982eaefdc7f822fd408a3d Reviewed-on: https://skia-review.googlesource.com/148659 Commit-Queue: Adrienne Walker <enne@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> [modify] https://crrev.com/70e468f93c4f46800db248e53618e7da2eb5a528/src/gpu/gpu_workaround_list.txt [modify] https://crrev.com/70e468f93c4f46800db248e53618e7da2eb5a528/include/gpu/GrDriverBugWorkaroundsAutogen.h [modify] https://crrev.com/70e468f93c4f46800db248e53618e7da2eb5a528/src/gpu/gl/GrGLCaps.cpp
,
Aug 22
Done, thank goodness.
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae2eaa7c0800c2128bbb6c910024478ebaa1a672 commit ae2eaa7c0800c2128bbb6c910024478ebaa1a672 Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu Aug 23 03:35:30 2018 Roll src/third_party/skia 33d5394d08f6..9ac87d4472f6 (7 commits) https://skia.googlesource.com/skia.git/+log/33d5394d08f6..9ac87d4472f6 git log 33d5394d08f6..9ac87d4472f6 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-22 enne@chromium.org Add disable_texture_storage workaround 2018-08-22 enne@chromium.org Add remove_pow_with_constant_exponent workaround 2018-08-22 enne@chromium.org Add rewrite_do_while_loops workaround 2018-08-22 mtklein@google.com also set Wno-implicit-fallthrough for Android Created with: gclient setdep -r src/third_party/skia@9ac87d4472f6 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium: 521904,chromium:829614,chromium: 477306,chromium:829614,chromium: 644669,chromium:829614 TBR=fmalita@chromium.org Change-Id: I150b8ac88e7c5dfcb6eefc7bfe4bd50c08180f69 Reviewed-on: https://chromium-review.googlesource.com/1185693 Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585385} [modify] https://crrev.com/ae2eaa7c0800c2128bbb6c910024478ebaa1a672/DEPS |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hcm@google.com
, Apr 6 2018