New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 829604 link

Starred by 0 users
Status: Fixed
Owner:
peter@chromium.org
Closed: Apr 2018
Cc:
jianli@chromium.org
█ dim...@chromium.org
fgor...@chromium.org
khorimoto@chromium.org
zea@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

FakeGCMProfileService should move to //components/gcm_driver

Project Member Reported by khorimoto@chromium.org, Apr 5 2018 
I was attempting to test some code (not in //chrome) which uses GCMProfileService, but unfortunately, FakeGCMProfileService resides in //chrome, so this was not possible.

I took a look at FakeGCMProfileService's implementation, and I found that while it does include profile.h, it does not actually use a Profile at all. The class takes a Profile* in its constructor, but it does not save it or reference it at all.

It would be great if FakeGCMProfileService were a sibling to the normal GCMProfileService for testing purposes.

Comment 1 by peter@chromium.org, Apr 9 2018

Owner: peter@chromium.org
Status: Started (was: Untriaged)
Sure, that's reasonable. Uploaded a CL here:
https://chromium-review.googlesource.com/#/c/chromium/src/+/1001894
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd

commit 3413946bfd65ec4a091eaf22cd66dfb8e59a42bd
Author: Peter Beverloo <peter@chromium.org>
Date: Tue Apr 10 14:18:06 2018

Move the FakeGCMProfileService helper to the GCM Driver component

TBR=jianli, finnur and jamescook for include path changes

Bug:  829604 
Change-Id: Icb53714ede7a4ce40ca38ee4c79740b64c70997a
Reviewed-on: https://chromium-review.googlesource.com/1001894
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Nicolas Zea (slow) <zea@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549519}
[modify] https://crrev.com/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd/chrome/browser/BUILD.gn
[modify] https://crrev.com/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd/chrome/browser/chromeos/net/wake_on_wifi_manager_unittest.cc
[modify] https://crrev.com/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd/chrome/browser/extensions/api/gcm/gcm_apitest.cc
[modify] https://crrev.com/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd/chrome/browser/extensions/api/instance_id/instance_id_apitest.cc
[modify] https://crrev.com/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd/chrome/browser/extensions/service_worker_apitest.cc
[modify] https://crrev.com/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd/chrome/browser/offline_pages/prefetch/prefetch_instance_id_proxy_unittest.cc
[modify] https://crrev.com/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd/chrome/browser/push_messaging/push_messaging_browsertest.cc
[modify] https://crrev.com/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd/chrome/browser/push_messaging/push_messaging_service_unittest.cc
[modify] https://crrev.com/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd/components/gcm_driver/BUILD.gn
[modify] https://crrev.com/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd/components/gcm_driver/DEPS
[rename] https://crrev.com/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd/components/gcm_driver/fake_gcm_profile_service.cc
[rename] https://crrev.com/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd/components/gcm_driver/fake_gcm_profile_service.h
[modify] https://crrev.com/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd/components/gcm_driver/gcm_profile_service.cc
[modify] https://crrev.com/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd/components/gcm_driver/gcm_profile_service.h
[modify] https://crrev.com/3413946bfd65ec4a091eaf22cd66dfb8e59a42bd/components/gcm_driver/instance_id/BUILD.gn

Comment 3 by peter@chromium.org, Apr 10 2018

Status: Fixed (was: Started)

Comment 4 by khorimoto@chromium.org, Apr 10 2018 

Thanks for the fix!
►

Sign in to add a comment